From: Jakub Jelinek <jakub@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>, "Martin Liška" <mliska@suse.cz>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libsanitizer: Add __interceptor_sigsetjmp_internal
Date: Tue, 31 Jan 2023 10:09:03 +0100 [thread overview]
Message-ID: <Y9jarw0AnTXyKJPv@tucnak> (raw)
In-Reply-To: <20221216213132.578277-1-hjl.tools@gmail.com>
On Fri, Dec 16, 2022 at 01:31:32PM -0800, H.J. Lu via Gcc-patches wrote:
> Add an internal alias to __interceptor_sigsetjmp to avoid R_X86_64_PC32
> relocation for "jmp __interceptor_sigsetjmp" with old assemblers.
I think the patch is ok, but because libsanitizer is just downstream
from sanitizers in LLVM, this should be filed in
https://reviews.llvm.org/differential/diff/create/
first (with diff -p -U10000 or something similar I think they want there).
It can be then cherry-picked into GCC, or at least wait until there is
some agreement on what they want or whether they completely reject it
and we'd need to carry it as a GCC local patch (in that case it should
be in libsanitizer/LOCAL_PATCHES).
> PR sanitizer/108106
> * hwasan/hwasan_setjmp_x86_64.S (__interceptor_sigsetjmp): Add
> an internal alias, __interceptor_sigsetjmp_internal.
> ---
> libsanitizer/hwasan/hwasan_setjmp_x86_64.S | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libsanitizer/hwasan/hwasan_setjmp_x86_64.S b/libsanitizer/hwasan/hwasan_setjmp_x86_64.S
> index 7566c1ea0a5..071dcdcf613 100644
> --- a/libsanitizer/hwasan/hwasan_setjmp_x86_64.S
> +++ b/libsanitizer/hwasan/hwasan_setjmp_x86_64.S
> @@ -37,13 +37,14 @@ __interceptor_setjmp:
> CFI_STARTPROC
> _CET_ENDBR
> xorl %esi, %esi
> - jmp __interceptor_sigsetjmp
> + jmp __interceptor_sigsetjmp_internal
> CFI_ENDPROC
> ASM_SIZE(__interceptor_setjmp)
>
> .global __interceptor_sigsetjmp
> ASM_TYPE_FUNCTION(__interceptor_sigsetjmp)
> __interceptor_sigsetjmp:
> +__interceptor_sigsetjmp_internal:
> CFI_STARTPROC
> _CET_ENDBR
>
Jakub
prev parent reply other threads:[~2023-01-31 9:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 21:31 H.J. Lu
2023-01-31 9:09 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9jarw0AnTXyKJPv@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).