[PATCH] libgompd: Fixed Access bug

[PATCH] libgompd: Fixed Access bug

[Mohamed Atef]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

Hello,
  I referenced kind, nthread, and implicit as pointers in my last patch.
This patch fixes this bug. We review patches and even the committed ones.
Another thing, I didn't add gompd_thread_handle_access entries in the
ChangeLog.

libgomp/ChangeLog

2022-06-26  MohamedAtef  <mohamedatef1698@gmail.com>

* ompd-helper.c (gompd_is_final): Change is_ptr from 1 to 0 in
ACCESS_VALUE.
(gompd_is_implicit, and gompd_get_team_size): Likewise.

 Signed-off-by: Mohamed Atef <mohamedatef1698@gmail.com>

[-- Attachment #2: diff.txt --]
[-- Type: text/plain, Size: 1539 bytes --]

diff --git a/libgomp/ompd-helper.c b/libgomp/ompd-helper.c
index 9762b48dff8..ca05ed50c18 100644
--- a/libgomp/ompd-helper.c
+++ b/libgomp/ompd-helper.c
@@ -540,7 +540,7 @@ gompd_is_final (ompd_task_handle_t *task_handle, ompd_word_t *final_task)
   ompd_rc_t ret;
   /* gomp_task->final_task.  */
   ACCESS_VALUE (context, NULL, "gompd_access_gomp_task_final_task", temp_offset,
-		1, ret, symbol_addr, temp_sym_addr, temp_addr);
+		0, ret, symbol_addr, temp_sym_addr, temp_addr);
   DEREFERENCE (context, NULL, symbol_addr, target_sizes.sizeof_char, 1,
 	       res, ret, 0);
   *final_task = res;
@@ -565,7 +565,7 @@ gompd_is_implicit (ompd_task_handle_t *task_handle, ompd_word_t *task_kind)
   ompd_address_space_context_t *context = task_handle->ah->context;
   ompd_rc_t ret;
   /* gomp_task->kind.  */
-  ACCESS_VALUE (context, NULL, "gompd_access_gomp_task_kind", temp_offset, 1,
+  ACCESS_VALUE (context, NULL, "gompd_access_gomp_task_kind", temp_offset, 0,
 		ret, symbol_addr, temp_sym_addr, temp_addr);
   DEREFERENCE (context, NULL, symbol_addr, target_sizes.sizeof_int, 1, res,
 	       ret, 0);
@@ -597,7 +597,7 @@ gompd_get_team_size (ompd_parallel_handle_t *parallel_handle,
   ompd_rc_t ret;
   /* gomp_team->nthreads.  */
   ACCESS_VALUE (context, NULL, "gompd_access_gomp_team_nthreads", temp_offset,
-		1, ret, symbol_addr, temp_sym_addr, temp_addr);
+		0, ret, symbol_addr, temp_sym_addr, temp_addr);
   DEREFERENCE (context, NULL, symbol_addr, target_sizes.sizeof_int, 1,
 	       res, ret, 0);
   *nthreads = res;

Re: [PATCH] libgompd: Fixed Access bug

[Jakub Jelinek]

On Sun, Jun 26, 2022 at 02:26:27AM +0200, Mohamed Atef wrote:
> Hello,
>   I referenced kind, nthread, and implicit as pointers in my last patch.
> This patch fixes this bug. We review patches and even the committed ones.
> Another thing, I didn't add gompd_thread_handle_access entries in the
> ChangeLog.
> 
> libgomp/ChangeLog
> 
> 2022-06-26  MohamedAtef  <mohamedatef1698@gmail.com>

Missing space between your name and surname.
> 
> * ompd-helper.c (gompd_is_final): Change is_ptr from 1 to 0 in
> ACCESS_VALUE.
> (gompd_is_implicit, and gompd_get_team_size): Likewise.

Please take the " and" part out of it.
You could also write
	* ompd-helper.c (gompd_is_final, gompd_is_implicit,
	gompd_get_team_size): Change is_ptr from 1 to 0 in ACCESS_VALUE.

> 
>  Signed-off-by: Mohamed Atef <mohamedatef1698@gmail.com>

Otherwise LGTM.

> diff --git a/libgomp/ompd-helper.c b/libgomp/ompd-helper.c
> index 9762b48dff8..ca05ed50c18 100644
> --- a/libgomp/ompd-helper.c
> +++ b/libgomp/ompd-helper.c
> @@ -540,7 +540,7 @@ gompd_is_final (ompd_task_handle_t *task_handle, ompd_word_t *final_task)
>    ompd_rc_t ret;
>    /* gomp_task->final_task.  */
>    ACCESS_VALUE (context, NULL, "gompd_access_gomp_task_final_task", temp_offset,
> -		1, ret, symbol_addr, temp_sym_addr, temp_addr);
> +		0, ret, symbol_addr, temp_sym_addr, temp_addr);
>    DEREFERENCE (context, NULL, symbol_addr, target_sizes.sizeof_char, 1,
>  	       res, ret, 0);
>    *final_task = res;
> @@ -565,7 +565,7 @@ gompd_is_implicit (ompd_task_handle_t *task_handle, ompd_word_t *task_kind)
>    ompd_address_space_context_t *context = task_handle->ah->context;
>    ompd_rc_t ret;
>    /* gomp_task->kind.  */
> -  ACCESS_VALUE (context, NULL, "gompd_access_gomp_task_kind", temp_offset, 1,
> +  ACCESS_VALUE (context, NULL, "gompd_access_gomp_task_kind", temp_offset, 0,
>  		ret, symbol_addr, temp_sym_addr, temp_addr);
>    DEREFERENCE (context, NULL, symbol_addr, target_sizes.sizeof_int, 1, res,
>  	       ret, 0);
> @@ -597,7 +597,7 @@ gompd_get_team_size (ompd_parallel_handle_t *parallel_handle,
>    ompd_rc_t ret;
>    /* gomp_team->nthreads.  */
>    ACCESS_VALUE (context, NULL, "gompd_access_gomp_team_nthreads", temp_offset,
> -		1, ret, symbol_addr, temp_sym_addr, temp_addr);
> +		0, ret, symbol_addr, temp_sym_addr, temp_addr);
>    DEREFERENCE (context, NULL, symbol_addr, target_sizes.sizeof_int, 1,
>  	       res, ret, 0);
>    *nthreads = res;


	Jakub