* [PATCH v2 2/4] aarch64: Remove qualifier_internal
@ 2022-07-13 13:40 Andrew Carlotti
2022-07-13 16:04 ` Richard Sandiford
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Carlotti @ 2022-07-13 13:40 UTC (permalink / raw)
To: gcc-patches; +Cc: Richard Sandiford
This has been unused since 2014, so there's no reason to retain it.
gcc/ChangeLog:
* config/aarch64/aarch64-builtins.cc
(enum aarch64_type_qualifiers): Remove qualifier_internal.
(aarch64_init_simd_builtin_functions): Remove qualifier_internal check.
---
diff --git a/gcc/config/aarch64/aarch64-builtins.cc b/gcc/config/aarch64/aarch64-builtins.cc
index 52d27c6978990ca3e6c523654fe1cdc952e77ad7..55ad2e8b6831d6cc2b039270c8656d429347092d 100644
--- a/gcc/config/aarch64/aarch64-builtins.cc
+++ b/gcc/config/aarch64/aarch64-builtins.cc
@@ -145,9 +145,7 @@ enum aarch64_type_qualifiers
qualifier_maybe_immediate = 0x10, /* 1 << 4 */
/* void foo (...). */
qualifier_void = 0x20, /* 1 << 5 */
- /* Some patterns may have internal operands, this qualifier is an
- instruction to the initialisation code to skip this operand. */
- qualifier_internal = 0x40, /* 1 << 6 */
+ /* 1 << 6 is now unused */
/* Some builtins should use the T_*mode* encoded in a simd_builtin_datum
rather than using the type of the operand. */
qualifier_map_mode = 0x80, /* 1 << 7 */
@@ -1207,10 +1205,6 @@ aarch64_init_simd_builtin_functions (bool called_from_pragma)
else
type_signature[op_num] = 's';
- /* Skip an internal operand for vget_{low, high}. */
- if (qualifiers & qualifier_internal)
- continue;
-
/* Some builtins have different user-facing types
for certain arguments, encoded in d->mode. */
if (qualifiers & qualifier_map_mode)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2 2/4] aarch64: Remove qualifier_internal
2022-07-13 13:40 [PATCH v2 2/4] aarch64: Remove qualifier_internal Andrew Carlotti
@ 2022-07-13 16:04 ` Richard Sandiford
0 siblings, 0 replies; 2+ messages in thread
From: Richard Sandiford @ 2022-07-13 16:04 UTC (permalink / raw)
To: Andrew Carlotti; +Cc: gcc-patches
Andrew Carlotti <andrew.carlotti@arm.com> writes:
> This has been unused since 2014, so there's no reason to retain it.
>
> gcc/ChangeLog:
>
> * config/aarch64/aarch64-builtins.cc
> (enum aarch64_type_qualifiers): Remove qualifier_internal.
> (aarch64_init_simd_builtin_functions): Remove qualifier_internal check.
OK, thanks.
Richard
> ---
>
> diff --git a/gcc/config/aarch64/aarch64-builtins.cc b/gcc/config/aarch64/aarch64-builtins.cc
> index 52d27c6978990ca3e6c523654fe1cdc952e77ad7..55ad2e8b6831d6cc2b039270c8656d429347092d 100644
> --- a/gcc/config/aarch64/aarch64-builtins.cc
> +++ b/gcc/config/aarch64/aarch64-builtins.cc
> @@ -145,9 +145,7 @@ enum aarch64_type_qualifiers
> qualifier_maybe_immediate = 0x10, /* 1 << 4 */
> /* void foo (...). */
> qualifier_void = 0x20, /* 1 << 5 */
> - /* Some patterns may have internal operands, this qualifier is an
> - instruction to the initialisation code to skip this operand. */
> - qualifier_internal = 0x40, /* 1 << 6 */
> + /* 1 << 6 is now unused */
> /* Some builtins should use the T_*mode* encoded in a simd_builtin_datum
> rather than using the type of the operand. */
> qualifier_map_mode = 0x80, /* 1 << 7 */
> @@ -1207,10 +1205,6 @@ aarch64_init_simd_builtin_functions (bool called_from_pragma)
> else
> type_signature[op_num] = 's';
>
> - /* Skip an internal operand for vget_{low, high}. */
> - if (qualifiers & qualifier_internal)
> - continue;
> -
> /* Some builtins have different user-facing types
> for certain arguments, encoded in d->mode. */
> if (qualifiers & qualifier_map_mode)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-13 16:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-13 13:40 [PATCH v2 2/4] aarch64: Remove qualifier_internal Andrew Carlotti
2022-07-13 16:04 ` Richard Sandiford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).