From: Jakub Jelinek <jakub@redhat.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [Patch] Add libgomp.c-c++-common/pr106449-2.c (was: [committed] openmp: Fix up handling of non-rectangular simd loops with pointer type iterators [PR106449])
Date: Fri, 29 Jul 2022 12:34:06 +0200 [thread overview]
Message-ID: <YuO3nvGPUu/01bQp@tucnak> (raw)
In-Reply-To: <21e39473-5bcc-02a0-fc64-564e0a606ac2@codesourcery.com>
On Fri, Jul 29, 2022 at 11:48:08AM +0200, Tobias Burnus wrote:
> On 29.07.22 10:03, Jakub Jelinek wrote:
> > There were 2 issues visible on this new testcase, one that we didn't have
> > special POINTER_TYPE_P handling in a few spots of expand_omp_simd ...
> > The other issue was that we put n2 expression directly into a
> > comparison in a condition and regimplified that, for the &a[512] case that
> > and with gimplification being destructed that unfortunately meant modification
> > of original fd->loops[?].n2. Fixed by unsharing the expression.
>
> I created a testcase for the non-simd case – and due to messing up, it failed;
> hence, I filled PR middle-end/106467. After fixing the testcase, it passes.
> (→ closed PR as invalid).
>
> However, given that the testcase now exists, I think it makes sense to add it :-)
>
> Changes compared to the simd testcase: replaced '(parallel for) simd' by 'for',
> removed 'linear', used now 'b' and 'c' instead of storing both ptrs in 'b'.
>
> Side remark: Before GCC 12, GCC complained about "q = p + n" with
> "error: initializer expression refers to iteration variable ‘p’".
>
> OK for mainline?
Ok, thanks.
Jakub
prev parent reply other threads:[~2022-07-29 10:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 8:03 [committed] openmp: Fix up handling of non-rectangular simd loops with pointer type iterators [PR106449] Jakub Jelinek
2022-07-29 9:48 ` [Patch] Add libgomp.c-c++-common/pr106449-2.c (was: [committed] openmp: Fix up handling of non-rectangular simd loops with pointer type iterators [PR106449]) Tobias Burnus
2022-07-29 10:34 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuO3nvGPUu/01bQp@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).