From: Marek Polacek <polacek@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: add more C++ name hints
Date: Wed, 17 Aug 2022 08:17:21 -0400 [thread overview]
Message-ID: <YvzcUaWlG4CC4l3H@redhat.com> (raw)
In-Reply-To: <CAP3s5k_2uk-SSPEbZ=Gy_Ri3eAjw8RQH6Nk4fvEDcBYn6fbyEQ@mail.gmail.com>
On Fri, Aug 05, 2022 at 09:35:33PM +0200, Ulrich Drepper via Gcc-patches wrote:
> How about adding a few more names from the std namespace to get appropriate
> hints? This patch compiles and the appropriate messages are printed. Is
> there a problem with just adding more or even at some point all the symbols
> of the standard library?
IMHO if the table in get_std_name_hint gets too big, we should probably see
if we can replace the O(n) search with something more efficient.
> gcc/ChangeLog:
>
> * cp/name-lookup.cc (get_std_name_hint): Add more symbols from the
> <iomanip>, <ios>, <istream> and <ostream> headers.
Please drop the "cp/" prefix here.
Patch LGTM, but I can't approve. Thanks and sorry for the delay,
Marek
prev parent reply other threads:[~2022-08-17 12:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 19:35 Ulrich Drepper
2022-08-17 10:29 ` Ulrich Drepper
2022-08-17 12:17 ` Marek Polacek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvzcUaWlG4CC4l3H@redhat.com \
--to=polacek@redhat.com \
--cc=drepper@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).