public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] tree-optimization/106737 - remove intermediate SSA verification in autopar
@ 2022-08-25  8:44 Richard Biener
  2022-08-27  7:30 ` [PATCH] testsuite: Require fgraphite effective target for pr106737.c test [PR106737] Jakub Jelinek
  0 siblings, 1 reply; 2+ messages in thread
From: Richard Biener @ 2022-08-25  8:44 UTC (permalink / raw)
  To: gcc-patches

The following removes intermediate SSA verification in autopar which
isn't expected to succeed after previous changes delaying (virtual)
SSA update to the end of the pass.

Pushed as obvious.

	PR tree-optimization/106737
	* tree-parloops.cc (transform_to_exit_first_loop_alt): Do not
	verify SSA form.

	* gcc.dg/autopar/pr106737.c: New testcase.
---
 gcc/testsuite/gcc.dg/autopar/pr106737.c | 18 ++++++++++++++++++
 gcc/tree-parloops.cc                    |  2 --
 2 files changed, 18 insertions(+), 2 deletions(-)
 create mode 100644 gcc/testsuite/gcc.dg/autopar/pr106737.c

diff --git a/gcc/testsuite/gcc.dg/autopar/pr106737.c b/gcc/testsuite/gcc.dg/autopar/pr106737.c
new file mode 100644
index 00000000000..3ec8f5dc9e8
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/autopar/pr106737.c
@@ -0,0 +1,18 @@
+/* { dg-do compile } */
+/* { dg-options "-O -floop-parallelize-all -ftree-parallelize-loops=2 -fno-tree-dce" } */
+
+void
+foo (int x)
+{
+  int a[2];
+  int b, c = 0;
+
+  for (b = 0; b < 2; ++b)
+    a[b] = 0;
+  for (b = 0; b < 2; ++b)
+    a[b] = 0;
+
+  while (c < 1)
+    while (x < 1)
+      ++x;
+}
diff --git a/gcc/tree-parloops.cc b/gcc/tree-parloops.cc
index b070527ee6e..76483fcaaa2 100644
--- a/gcc/tree-parloops.cc
+++ b/gcc/tree-parloops.cc
@@ -2484,8 +2484,6 @@ transform_to_exit_first_loop_alt (class loop *loop,
   /* Recalculate dominance info.  */
   free_dominance_info (CDI_DOMINATORS);
   calculate_dominance_info (CDI_DOMINATORS);
-
-  checking_verify_ssa (true, true);
 }
 
 /* Tries to moves the exit condition of LOOP to the beginning of its header
-- 
2.35.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] testsuite: Require fgraphite effective target for pr106737.c test [PR106737]
  2022-08-25  8:44 [PATCH] tree-optimization/106737 - remove intermediate SSA verification in autopar Richard Biener
@ 2022-08-27  7:30 ` Jakub Jelinek
  0 siblings, 0 replies; 2+ messages in thread
From: Jakub Jelinek @ 2022-08-27  7:30 UTC (permalink / raw)
  To: Richard Biener; +Cc: gcc-patches

On Thu, Aug 25, 2022 at 10:44:32AM +0200, Richard Biener via Gcc-patches wrote:
> 	* gcc.dg/autopar/pr106737.c: New testcase.

The test uses -floop-parallelize-all which emits a sorry when graphite
isn't configured in.

Fixed thusly, tested on x86_64-linux (where it PASSed for me before and
keeps PASSing) and on i686-linux (where it FAILed and now is UNSUPPORTED
as I don't have 32-bit libisl installed), committed to trunk as obvious.

2022-08-27  Jakub Jelinek  <jakub@redhat.com>

	PR tree-optimization/106737
	* gcc.dg/autopar/pr106737.c: Require fgraphite effective target.

--- gcc/testsuite/gcc.dg/autopar/pr106737.c.jj	2022-08-25 20:34:49.333893224 +0200
+++ gcc/testsuite/gcc.dg/autopar/pr106737.c	2022-08-27 09:22:07.141807077 +0200
@@ -1,4 +1,4 @@
-/* { dg-do compile } */
+/* { dg-do compile { target fgraphite } } */
 /* { dg-options "-O -floop-parallelize-all -ftree-parallelize-loops=2 -fno-tree-dce" } */
 
 void

	Jakub


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-08-27  7:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-25  8:44 [PATCH] tree-optimization/106737 - remove intermediate SSA verification in autopar Richard Biener
2022-08-27  7:30 ` [PATCH] testsuite: Require fgraphite effective target for pr106737.c test [PR106737] Jakub Jelinek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).