From: Jakub Jelinek <jakub@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Richard Biener <richard.guenther@gmail.com>, gcc-patches@gcc.gnu.org
Subject: [committed] libgcc, arc: Fix build
Date: Fri, 7 Oct 2022 00:19:09 +0200 [thread overview]
Message-ID: <Yz9UXQV4MrH5TbOC@tucnak> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2210062202540.2876845@digraph.polyomino.org.uk>
Hi!
On Thu, Oct 06, 2022 at 10:05:29PM +0000, Joseph Myers wrote:
> I'm seeing the following build failure for arc-linux-gnu after this
> commit. (Note that this is for building GCC *after* glibc, not for an
> initial inhibit_libc bootstrap build of GCC.)
>
> In file included from
> /scratch/jmyers/glibc-bot/src/gcc/libgcc/unwind-dw2.c:413:
> ./md-unwind-support.h: In function 'arc_fallback_frame_state':
> ./md-unwind-support.h:103:10: warning: assignment to 'struct sigcontext *' from incompatible pointer type 'mcontext_t *' [-Wincompatible-pointer-types]
> 103 | sc = &rt_->uc.uc_mcontext;
> | ^
> ./md-unwind-support.h:118:45: error: 'struct <anonymous>' has no member named 'how'
> 118 | fs->regs.reg[register_id_for_index[i]].how = REG_SAVED_OFFSET;
> | ^
> /scratch/jmyers/glibc-bot/src/gcc/libgcc/shared-object.mk:14: recipe for target 'unwind-dw2.o' failed
>
> https://sourceware.org/pipermail/libc-testresults/2022q4/010333.html
Oops, sorry.
Missed one spot in the r13-3108-g146e45914032 change (my sed script
didn't expect nested []s).
Committed to trunk as obvious.
2022-10-07 Jakub Jelinek <jakub@redhat.com>
* config/arc/linux-unwind.h (arc_fallback_frame_state): Use
fs->regs.how[X] instead of fs->regs.reg[X].how.
--- libgcc/config/arc/linux-unwind.h.jj 2022-10-06 11:04:33.254058274 +0200
+++ libgcc/config/arc/linux-unwind.h 2022-10-07 00:10:24.353464043 +0200
@@ -115,7 +115,7 @@ arc_fallback_frame_state (struct _Unwind
{
if (register_id_for_index[i] == -1)
continue;
- fs->regs.reg[register_id_for_index[i]].how = REG_SAVED_OFFSET;
+ fs->regs.how[register_id_for_index[i]] = REG_SAVED_OFFSET;
fs->regs.reg[register_id_for_index[i]].loc.offset
= ((_Unwind_Ptr) &(regs[i])) - new_cfa;
}
Jakub
prev parent reply other threads:[~2022-10-06 22:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 7:58 [PATCH] libgcc: Decrease size of _Unwind_FrameState and even more size of cleared area in uw_frame_state_for Jakub Jelinek
2022-09-19 8:57 ` Richard Biener
2022-09-19 9:16 ` Jakub Jelinek
2022-09-19 9:25 ` Florian Weimer
2022-09-19 9:33 ` Jakub Jelinek
2022-09-19 13:46 ` Florian Weimer
2022-10-05 10:33 ` Patch ping (Re: [PATCH] libgcc: Decrease size of _Unwind_FrameState and even more size of cleared area in uw_frame_state_for) Jakub Jelinek
2022-10-06 8:08 ` Richard Biener
2022-10-06 22:05 ` Joseph Myers
2022-10-06 22:19 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz9UXQV4MrH5TbOC@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).