From: Jakub Jelinek <jakub@redhat.com>
To: Andrew Pinski <apinski@marvell.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCHv2] Fix PR 108980: note without warning due to array bounds check
Date: Thu, 9 Mar 2023 19:13:01 +0100 [thread overview]
Message-ID: <ZAohre8RxVMhb2Ka@tucnak> (raw)
In-Reply-To: <20230309180320.2899452-1-apinski@marvell.com>
On Thu, Mar 09, 2023 at 10:03:20AM -0800, Andrew Pinski via Gcc-patches wrote:
> The problem here is after r13-4748-g2a27ae32fabf85, in some
> cases we were calling inform without a corresponding warning.
> This changes the logic such that we only cause that to happen
> if there was a warning happened before hand.
>
> Changes since
> * v1: Fix formating and dump message as suggested by Jakub.
>
> OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions.
>
> gcc/ChangeLog:
>
> PR tree-optimization/108980
> * gimple-array-bounds.cc (array_bounds_checker::check_array_ref):
> Reorgnize the call to warning for not strict flexible arrays
> to be before the check of warned.
> ---
> gcc/gimple-array-bounds.cc | 41 ++++++++++++++++++++++++--------------
> 1 file changed, 26 insertions(+), 15 deletions(-)
It would be nice to have a testcase with dg-bogus for the messages,
but seems we don't have one in the PR, so ok for trunk.
Jakub
prev parent reply other threads:[~2023-03-09 18:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 18:03 Andrew Pinski
2023-03-09 18:13 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAohre8RxVMhb2Ka@tucnak \
--to=jakub@redhat.com \
--cc=apinski@marvell.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).