* [Patch] OpenMP: Add omp_in_explicit_task to omp_runtime_api_call
@ 2023-03-15 14:24 Tobias Burnus
2023-03-15 14:27 ` Jakub Jelinek
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Burnus @ 2023-03-15 14:24 UTC (permalink / raw)
To: gcc-patches, Jakub Jelinek
[-- Attachment #1: Type: text/plain, Size: 815 bytes --]
When adding a new OpenMP routine, also omp_runtime_api_call needs
to be adapted - to get proper error like:
error: OpenMP runtime API call ‘omp_in_explicit_task’ in a region with ‘order(concurrent)’ clause
OK for mainline?
Tobias
PS: This routine was added in commit r13-3258-g0ec4e93fb9fa5e9d2424683c5fab1310c8ae2f76
PPS: I have not fully checked but I think it should be up to date; at least all
other recent additions include updates to that omp-low.cc function and at some point
I had checked it for completeness.
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
[-- Attachment #2: in-explicit.diff --]
[-- Type: text/x-patch, Size: 469 bytes --]
OpenMP: Add omp_in_explicit_task to omp_runtime_api_call
gcc/
* omp-low.cc (omp_runtime_api_call): Add omp_runtime_api_call.
diff --git a/gcc/omp-low.cc b/gcc/omp-low.cc
index 9757592c635..1818132830f 100644
--- a/gcc/omp-low.cc
+++ b/gcc/omp-low.cc
@@ -4082,6 +4082,7 @@ omp_runtime_api_call (const_tree fndecl)
"get_thread_num",
"get_wtick",
"get_wtime",
+ "in_explicit_task",
"in_final",
"in_parallel",
"init_lock",
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Patch] OpenMP: Add omp_in_explicit_task to omp_runtime_api_call
2023-03-15 14:24 [Patch] OpenMP: Add omp_in_explicit_task to omp_runtime_api_call Tobias Burnus
@ 2023-03-15 14:27 ` Jakub Jelinek
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Jelinek @ 2023-03-15 14:27 UTC (permalink / raw)
To: Tobias Burnus; +Cc: gcc-patches
On Wed, Mar 15, 2023 at 03:24:04PM +0100, Tobias Burnus wrote:
> When adding a new OpenMP routine, also omp_runtime_api_call needs
> to be adapted - to get proper error like:
>
> error: OpenMP runtime API call ‘omp_in_explicit_task’ in a region with ‘order(concurrent)’ clause
>
> OK for mainline?
Yes, thanks.
> OpenMP: Add omp_in_explicit_task to omp_runtime_api_call
>
> gcc/
> * omp-low.cc (omp_runtime_api_call): Add omp_runtime_api_call.
>
> diff --git a/gcc/omp-low.cc b/gcc/omp-low.cc
> index 9757592c635..1818132830f 100644
> --- a/gcc/omp-low.cc
> +++ b/gcc/omp-low.cc
> @@ -4082,6 +4082,7 @@ omp_runtime_api_call (const_tree fndecl)
> "get_thread_num",
> "get_wtick",
> "get_wtime",
> + "in_explicit_task",
> "in_final",
> "in_parallel",
> "init_lock",
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-15 14:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-15 14:24 [Patch] OpenMP: Add omp_in_explicit_task to omp_runtime_api_call Tobias Burnus
2023-03-15 14:27 ` Jakub Jelinek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).