From: Jakub Jelinek <jakub@redhat.com>
To: Jakub Jelinek via Gcc-patches <gcc-patches@gcc.gnu.org>,
Richard Biener <rguenther@suse.de>,
Aldy Hernandez <aldyh@redhat.com>,
"Joseph S. Myers" <joseph@codesourcery.com>,
Siddhesh Poyarekar <siddhesh@gotplt.org>,
Andrew MacLeod <amacleod@redhat.com>,
richard.sandiford@arm.com
Subject: Re: [PATCH] v2: Add targetm.libm_function_max_error
Date: Fri, 28 Apr 2023 13:39:33 +0200 [thread overview]
Message-ID: <ZEuwdWWFqJmBkEeK@tucnak> (raw)
In-Reply-To: <mpt354k1byh.fsf@arm.com>
On Fri, Apr 28, 2023 at 12:29:58PM +0100, Richard Sandiford wrote:
> Jakub Jelinek via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
> > Hi!
> >
> > On Thu, Apr 27, 2023 at 10:34:59AM +0000, Richard Biener wrote:
> >> OK. As said the patch itself looks good to me, let's go ahead. We
> >> have plenty of time to backtrack until GCC 14.
> >
> > Thanks. Unfortunately when I started using it, I've discovered that the
> > CASE_CFN_xxx_ALL macros don't include the CFN_xxx cases, just
> > CFN_BUILT_IN_xxx* cases.
> >
> > So here is an updated version of the patch I'll bootstrap/regtest tonight
> > which instead uses CASE_CFN_xxx: CASE_CFN_xxx_FN:
>
> Shouldn't we change something in that case? The point of these macros
> is to wrap things up a single easy-to-use name, so something feels wrong
> if we're having to use a repeated pattern like this.
Maybe. But unfortunately not all builtins have those CFN_xxx enumerators,
some have just CFN_BUILT_IN_xxx{,L,F}, otherwise have
CFN_BUILT_IN_xxx{,L,F,F16,F32,F64,F128} and others have that plus CFN_xxx.
So we'd perhaps need some other macros for the all but CFN_xxx and perhaps
use ALL only for the cases where it is really all of them.
Jakub
prev parent reply other threads:[~2023-04-28 11:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 14:21 [PATCH] " Jakub Jelinek
2023-04-26 16:10 ` Michael Matz
2023-04-27 8:59 ` Jakub Jelinek
2023-04-27 11:05 ` Jakub Jelinek
2023-04-27 14:48 ` Michael Matz
2023-04-27 7:18 ` Richard Biener
2023-04-27 9:20 ` Jakub Jelinek
2023-04-27 10:34 ` Richard Biener
2023-04-27 11:08 ` [PATCH] v2: " Jakub Jelinek
2023-04-28 11:29 ` Richard Sandiford
2023-04-28 11:39 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEuwdWWFqJmBkEeK@tucnak \
--to=jakub@redhat.com \
--cc=aldyh@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=rguenther@suse.de \
--cc=richard.sandiford@arm.com \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).