public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: David Edelsohn <dje.gcc@gmail.com>,
	Tamar Christina <Tamar.Christina@arm.com>,
	GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 5/5] match.pd: Use splits in makefile and make configurable.
Date: Fri, 5 May 2023 17:17:54 +0200	[thread overview]
Message-ID: <ZFUeIhXyvZPg869m@tucnak> (raw)
In-Reply-To: <e7661aee-1b9e-4a2b-4c6d-3ec88ca4c781@gmail.com>

On Fri, May 05, 2023 at 09:04:16AM -0600, Jeff Law via Gcc-patches wrote:
> On 5/5/23 08:59, David Edelsohn via Gcc-patches wrote:
> > This patch has broken GCC bootstrap on AIX.  It appears to rely upon, or
> > complain about, the command "seq":
> > 
> > /nasfarm/edelsohn/install/GCC12/bin/g++ -std=c++11   -g -DIN_GCC
> > -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall
> > -Wno-narrowing -Wwrite-strings -Wcast-qual -Wno-format
> > -Wmissing-format-attribute -Wconditionally-supported -Woverloaded-virtual
> > -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings
> > -fno-common  -DHAVE_CONFIG_H  -DGENERATOR_FILE -static-libstdc++
> > -static-libgcc -Wl,-bbigtoc -Wl,-bmaxdata:0x40000000 -o build/genmatch \
> >      build/genmatch.o ../build-powerpc-ibm-aix7.2.5.0/libcpp/libcpp.a
> > build/errors.o build/vec.o build/hash-table.o build/sort.o
> > ../build-powerpc-ibm-aix7.2.5.0/libiberty/libiberty.a
> > /usr/bin/bash: seq: command not found
> > /usr/bin/bash: seq: command not found
> > build/genmatch --gimple \
> >      --header=tmp-gimple-match-auto.h --include=gimple-match-auto.h \
> >      /nasfarm/edelsohn/src/src/gcc/match.pd
> > 
> > All of the match files are dumped to stdout.
> Sigh.  So the question is do we make seq a requirement or do we implement an
> alternate to get the sequence or implement a fallback.

We require GNU make, so perhaps we could use something like
$(wordlist 1,$(NUM_MATCH_SPLITS),$(check_p_numbers))
instead of
$(shell seq 1 $(NUM_MATCH_SPLITS))
provided we move the check_p_numbers definition earlier (or perhaps bettter rename
it to something more generic, so that it is clear that is a variable holding
numbers from 1 to 9999.

	Jakub


  parent reply	other threads:[~2023-05-05 15:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05 14:59 David Edelsohn
2023-05-05 15:04 ` Jeff Law
2023-05-05 15:08   ` Tamar Christina
2023-05-05 15:13     ` Jeff Law
2023-05-05 15:17   ` Jakub Jelinek [this message]
2023-05-05 15:22     ` Tamar Christina
2023-05-05 15:33       ` Jakub Jelinek
2023-05-05 15:37         ` Tamar Christina
2023-05-05 15:41           ` David Edelsohn
2023-05-05 20:46           ` Jakub Jelinek
2023-05-05 23:32             ` Jeff Law
  -- strict thread matches above, loose matches on Subject: below --
2023-04-28 10:44 Tamar Christina
2023-04-30 19:46 ` Jeff Law
2023-05-02  7:08   ` Tamar Christina
2023-05-03 15:18     ` Kyrylo Tkachov
2023-05-04  9:56       ` Tamar Christina
2023-05-04 23:25         ` Jeff Law
2023-05-05 12:51           ` Tamar Christina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZFUeIhXyvZPg869m@tucnak \
    --to=jakub@redhat.com \
    --cc=Tamar.Christina@arm.com \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jeffreyalaw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).