From: Jeff Law <jeffreyalaw@gmail.com>
To: Tamar Christina <tamar.christina@arm.com>, gcc-patches@gcc.gnu.org
Cc: nd@arm.com, bonzini@gnu.org, neroden@gcc.gnu.org,
aoliva@gcc.gnu.org, Ralf.Wildenhues@gmx.de
Subject: Re: [PATCH 5/5] match.pd: Use splits in makefile and make configurable.
Date: Sun, 30 Apr 2023 13:46:05 -0600 [thread overview]
Message-ID: <f3ce2911-dca1-dad6-ec01-5fc835b8c181@gmail.com> (raw)
In-Reply-To: <patch-17230-tamar@arm.com>
On 4/28/23 04:44, Tamar Christina via Gcc-patches wrote:
> Hi All,
>
> This updates the build system to split up match.pd files into chunks of 10.
> This also introduces a new flag --with-matchpd-partitions which can be used to
> change the number of partitions.
>
> For the analysis of why 10 please look at the previous patch in the series.
>
> Bootstrapped Regtested on aarch64-none-linux-gnu and no issues.
>
> Ok for master?
>
> Thanks,
> Tamar
>
> gcc/ChangeLog:
>
> PR bootstrap/84402
> * Makefile.in (NUM_MATCH_SPLITS, MATCH_SPLITS_SEQ,
> GIMPLE_MATCH_PD_SEQ_SRC, GIMPLE_MATCH_PD_SEQ_O,
> GENERIC_MATCH_PD_SEQ_SRC, GENERIC_MATCH_PD_SEQ_O): New.
> (OBJS, MOSTLYCLEANFILES, .PRECIOUS): Use them.
> (s-match): Split into s-generic-match and s-gimple-match.
> * configure.ac (with-matchpd-partitions,
> DEFAULT_MATCHPD_PARTITIONS): New.
> * configure: Regenerate.
This looks pretty reasonable to me. Are there any patches left in this
series that need review? I'm very much looking forward to build time
provements related to this patch, particularly for targets that I
bootstrap with qemu emulation -- we take multiple hours to build
gimple-match and the ability to parallelize those component builds
should be a significant win.
jeff
next prev parent reply other threads:[~2023-04-30 19:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 10:44 Tamar Christina
2023-04-30 19:46 ` Jeff Law [this message]
2023-05-02 7:08 ` Tamar Christina
2023-05-03 15:18 ` Kyrylo Tkachov
2023-05-04 9:56 ` Tamar Christina
2023-05-04 23:25 ` Jeff Law
2023-05-05 12:51 ` Tamar Christina
2023-05-05 14:59 David Edelsohn
2023-05-05 15:04 ` Jeff Law
2023-05-05 15:08 ` Tamar Christina
2023-05-05 15:13 ` Jeff Law
2023-05-05 15:17 ` Jakub Jelinek
2023-05-05 15:22 ` Tamar Christina
2023-05-05 15:33 ` Jakub Jelinek
2023-05-05 15:37 ` Tamar Christina
2023-05-05 15:41 ` David Edelsohn
2023-05-05 20:46 ` Jakub Jelinek
2023-05-05 23:32 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3ce2911-dca1-dad6-ec01-5fc835b8c181@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=Ralf.Wildenhues@gmx.de \
--cc=aoliva@gcc.gnu.org \
--cc=bonzini@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
--cc=neroden@gcc.gnu.org \
--cc=tamar.christina@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).