From: Jakub Jelinek <jakub@redhat.com>
To: Hongtao Liu <crazylht@gmail.com>
Cc: Uros Bizjak <ubizjak@gmail.com>, liuhongt <hongtao.liu@intel.com>,
gcc-patches@gcc.gnu.org, hjl.tools@gmail.com
Subject: Re: [PATCH 1/2] [i386] Support type _Float16/__bf16 independent of SSE2.
Date: Wed, 19 Jul 2023 12:51:15 +0200 [thread overview]
Message-ID: <ZLfAI5xRpkKG9Ld+@tucnak> (raw)
In-Reply-To: <CAMZc-byEb5ueTuUZLkzuo9Tpg-4=R3k-O3EnE-Nw+n1Kk9_+gg@mail.gmail.com>
On Wed, Jul 19, 2023 at 01:58:21PM +0800, Hongtao Liu wrote:
> > LGTM, if you need someone to rubber-stamp the patch. I'm not really
> > versed in this part of the compiler, so please wait a day if someone
> > has anything to say about the patch.
> Thanks, pushed to trunk.
I see some regressions most likely with this change on i686-linux,
in particular:
+FAIL: gcc.dg/pr107547.c (test for excess errors)
+FAIL: gcc.dg/torture/floatn-convert.c -O0 (test for excess errors)
+UNRESOLVED: gcc.dg/torture/floatn-convert.c -O0 compilation failed to produce executable
+FAIL: gcc.dg/torture/floatn-convert.c -O1 (test for excess errors)
+UNRESOLVED: gcc.dg/torture/floatn-convert.c -O1 compilation failed to produce executable
+FAIL: gcc.dg/torture/floatn-convert.c -O2 (test for excess errors)
+UNRESOLVED: gcc.dg/torture/floatn-convert.c -O2 compilation failed to produce executable
+FAIL: gcc.dg/torture/floatn-convert.c -O2 -flto (test for excess errors)
+UNRESOLVED: gcc.dg/torture/floatn-convert.c -O2 -flto compilation failed to produce executable
+FAIL: gcc.dg/torture/floatn-convert.c -O2 -flto -flto-partition=none (test for excess errors)
+UNRESOLVED: gcc.dg/torture/floatn-convert.c -O2 -flto -flto-partition=none compilation failed to produce executable
+FAIL: gcc.dg/torture/floatn-convert.c -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions (test for excess errors)
+UNRESOLVED: gcc.dg/torture/floatn-convert.c -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions compilation failed to produce executable
+FAIL: gcc.dg/torture/floatn-convert.c -O3 -g (test for excess errors)
+UNRESOLVED: gcc.dg/torture/floatn-convert.c -O3 -g compilation failed to produce executable
+FAIL: gcc.dg/torture/floatn-convert.c -Os (test for excess errors)
+UNRESOLVED: gcc.dg/torture/floatn-convert.c -Os compilation failed to produce executable
+FAIL: gcc.target/i386/float16-7.c (test for errors, line 7)
Perhaps we need to tweak
gcc/testsuite/lib/target-supports.exp (add_options_for_float16)
so that it adds -msse2 for i?86-*-* x86_64-*-* (that would likely
fix up floatn-convert) and for the others perhaps
/* { dg-add-options float16 } */
?
Jakub
next prev parent reply other threads:[~2023-07-19 10:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 7:15 [PATCH] " liuhongt
2023-04-19 16:43 ` Mike Stump
2023-04-20 12:18 ` Jakub Jelinek
2023-04-21 13:53 ` [PATCH 1/2] " liuhongt
2023-04-21 13:53 ` [PATCH 2/2] [i386] def_or_undef __STDCPP_FLOAT16_T__ and __STDCPP_BFLOAT16_T__ for target attribute/pragmas liuhongt
2023-05-15 1:21 ` Hongtao Liu
2023-05-15 1:20 ` [PATCH 1/2] [i386] Support type _Float16/__bf16 independent of SSE2 Hongtao Liu
2023-07-17 8:35 ` Hongtao Liu
2023-07-17 11:38 ` Uros Bizjak
2023-07-19 5:58 ` Hongtao Liu
2023-07-19 10:51 ` Jakub Jelinek [this message]
2023-07-20 4:50 ` [PATCH] Fix fp16 related testcase failure for i686 liuhongt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLfAI5xRpkKG9Ld+@tucnak \
--to=jakub@redhat.com \
--cc=crazylht@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=hongtao.liu@intel.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).