From: Marek Polacek <polacek@redhat.com>
To: Jason Merrill <jason@redhat.com>
Cc: Patrick Palka <ppalka@redhat.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] c++: fix ICE with is_really_empty_class [PR110106]
Date: Tue, 25 Jul 2023 16:30:12 -0400 [thread overview]
Message-ID: <ZMAw1EGPMQwyPO9Z@redhat.com> (raw)
In-Reply-To: <ed95935a-4da2-a4bb-6829-3604374e54a1@redhat.com>
On Tue, Jul 25, 2023 at 04:24:39PM -0400, Jason Merrill wrote:
> On 7/25/23 15:59, Marek Polacek wrote:
> > Something like this, then? I see that cp_parser_initializer_clause et al
> > offer further opportunities (because they sometimes use a dummy too) but
> > this should be a good start.
>
> Looks good. Please do update the other callers as well, while you're
> looking at this.
Thanks. Can I push this part first?
next prev parent reply other threads:[~2023-07-25 20:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 21:14 Marek Polacek
2023-07-19 14:11 ` Patrick Palka
2023-07-20 18:13 ` Marek Polacek
2023-07-20 18:37 ` Jason Merrill
2023-07-20 19:51 ` Marek Polacek
2023-07-20 21:58 ` Marek Polacek
2023-07-21 17:44 ` Jason Merrill
2023-07-25 19:59 ` Marek Polacek
2023-07-25 20:24 ` Jason Merrill
2023-07-25 20:30 ` Marek Polacek [this message]
2023-07-26 2:03 ` Jason Merrill
2023-07-21 17:44 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMAw1EGPMQwyPO9Z@redhat.com \
--to=polacek@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).