public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] MATCH: extend min_value/max_value match to vectors
@ 2023-08-30 22:25 Andrew Pinski
  2023-08-31 12:16 ` Richard Biener
  2023-09-01 12:26 ` [committed] testsuite: Fix up pr110915* tests on i686-linux [PR110915] Jakub Jelinek
  0 siblings, 2 replies; 3+ messages in thread
From: Andrew Pinski @ 2023-08-30 22:25 UTC (permalink / raw)
  To: gcc-patches; +Cc: Andrew Pinski

This simple patch extends the min_value/max_value match to vector integer types.
Using uniform_integer_cst_p makes this easy.

OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions.

The testcases pr110915-*.c are the same as pr88784-*.c except using vector
types instead.

	PR tree-optimization/110915

gcc/ChangeLog:

	* match.pd (min_value, max_value): Extend to vector constants.

gcc/testsuite/ChangeLog:

	* gcc.dg/pr110915-1.c: New test.
	* gcc.dg/pr110915-10.c: New test.
	* gcc.dg/pr110915-11.c: New test.
	* gcc.dg/pr110915-12.c: New test.
	* gcc.dg/pr110915-2.c: New test.
	* gcc.dg/pr110915-3.c: New test.
	* gcc.dg/pr110915-4.c: New test.
	* gcc.dg/pr110915-5.c: New test.
	* gcc.dg/pr110915-6.c: New test.
	* gcc.dg/pr110915-7.c: New test.
	* gcc.dg/pr110915-8.c: New test.
	* gcc.dg/pr110915-9.c: New test.
---
 gcc/match.pd                       | 24 ++++++++++++++--------
 gcc/testsuite/gcc.dg/pr110915-1.c  | 31 ++++++++++++++++++++++++++++
 gcc/testsuite/gcc.dg/pr110915-10.c | 33 ++++++++++++++++++++++++++++++
 gcc/testsuite/gcc.dg/pr110915-11.c | 31 ++++++++++++++++++++++++++++
 gcc/testsuite/gcc.dg/pr110915-12.c | 31 ++++++++++++++++++++++++++++
 gcc/testsuite/gcc.dg/pr110915-2.c  | 31 ++++++++++++++++++++++++++++
 gcc/testsuite/gcc.dg/pr110915-3.c  | 33 ++++++++++++++++++++++++++++++
 gcc/testsuite/gcc.dg/pr110915-4.c  | 33 ++++++++++++++++++++++++++++++
 gcc/testsuite/gcc.dg/pr110915-5.c  | 32 +++++++++++++++++++++++++++++
 gcc/testsuite/gcc.dg/pr110915-6.c  | 32 +++++++++++++++++++++++++++++
 gcc/testsuite/gcc.dg/pr110915-7.c  | 32 +++++++++++++++++++++++++++++
 gcc/testsuite/gcc.dg/pr110915-8.c  | 32 +++++++++++++++++++++++++++++
 gcc/testsuite/gcc.dg/pr110915-9.c  | 33 ++++++++++++++++++++++++++++++
 13 files changed, 400 insertions(+), 8 deletions(-)
 create mode 100644 gcc/testsuite/gcc.dg/pr110915-1.c
 create mode 100644 gcc/testsuite/gcc.dg/pr110915-10.c
 create mode 100644 gcc/testsuite/gcc.dg/pr110915-11.c
 create mode 100644 gcc/testsuite/gcc.dg/pr110915-12.c
 create mode 100644 gcc/testsuite/gcc.dg/pr110915-2.c
 create mode 100644 gcc/testsuite/gcc.dg/pr110915-3.c
 create mode 100644 gcc/testsuite/gcc.dg/pr110915-4.c
 create mode 100644 gcc/testsuite/gcc.dg/pr110915-5.c
 create mode 100644 gcc/testsuite/gcc.dg/pr110915-6.c
 create mode 100644 gcc/testsuite/gcc.dg/pr110915-7.c
 create mode 100644 gcc/testsuite/gcc.dg/pr110915-8.c
 create mode 100644 gcc/testsuite/gcc.dg/pr110915-9.c

diff --git a/gcc/match.pd b/gcc/match.pd
index 6a7edde5736..c01362ee359 100644
--- a/gcc/match.pd
+++ b/gcc/match.pd
@@ -2750,16 +2750,24 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT)
 			       & (bitpos / BITS_PER_UNIT))); }))))
 
 (match min_value
- INTEGER_CST
- (if ((INTEGRAL_TYPE_P (type)
-       || POINTER_TYPE_P(type))
-      && wi::eq_p (wi::to_wide (t), wi::min_value (type)))))
+ uniform_integer_cst_p
+ (with {
+   tree int_cst = uniform_integer_cst_p (t);
+   tree inner_type = TREE_TYPE (int_cst);
+  }
+  (if ((INTEGRAL_TYPE_P (inner_type)
+        || POINTER_TYPE_P (inner_type))
+       && wi::eq_p (wi::to_wide (int_cst), wi::min_value (inner_type))))))
 
 (match max_value
- INTEGER_CST
- (if ((INTEGRAL_TYPE_P (type)
-       || POINTER_TYPE_P(type))
-      && wi::eq_p (wi::to_wide (t), wi::max_value (type)))))
+ uniform_integer_cst_p
+ (with {
+   tree int_cst = uniform_integer_cst_p (t);
+   tree itype = TREE_TYPE (int_cst);
+  }
+ (if ((INTEGRAL_TYPE_P (itype)
+       || POINTER_TYPE_P (itype))
+      && wi::eq_p (wi::to_wide (int_cst), wi::max_value (itype))))))
 
 /* x >  y  &&  x != XXX_MIN  -->  x > y
    x >  y  &&  x == XXX_MIN  -->  false . */
diff --git a/gcc/testsuite/gcc.dg/pr110915-1.c b/gcc/testsuite/gcc.dg/pr110915-1.c
new file mode 100644
index 00000000000..2e1e871b9a0
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr110915-1.c
@@ -0,0 +1,31 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-ifcombine" } */
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
+#include <limits.h>
+
+vector signed and1(vector unsigned x, vector unsigned y)
+{
+  /* (x > y) & (x != 0)  --> x > y */
+  return (x > y) & (x != 0);
+}
+
+vector signed and2(vector unsigned x, vector unsigned y)
+{
+  /* (x < y) & (x != UINT_MAX)  --> x < y */
+  return (x < y) & (x != UINT_MAX);
+}
+
+vector signed and3(vector signed x, vector signed y)
+{
+  /* (x > y) & (x != INT_MIN)  --> x > y */
+  return (x > y) & (x != INT_MIN);
+}
+
+vector signed and4(vector signed x, vector signed y)
+{
+  /* (x < y) & (x != INT_MAX)  --> x < y */
+  return (x < y) & (x != INT_MAX);
+}
+
+/* { dg-final { scan-tree-dump-not " != " "ifcombine" } } */
diff --git a/gcc/testsuite/gcc.dg/pr110915-10.c b/gcc/testsuite/gcc.dg/pr110915-10.c
new file mode 100644
index 00000000000..b0644bf3123
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr110915-10.c
@@ -0,0 +1,33 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-optimized" } */
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
+#include <limits.h>
+
+vector unsigned or1(vector unsigned x, vector unsigned y)
+{
+  /* (x <= y) | (x != 0))  --> true */
+  return (x <= y) | (x != 0);
+}
+
+vector unsigned or2(vector unsigned x, vector unsigned y)
+{
+  /* (x >= y) | (x != UINT_MAX)  --> true */
+  return (x >= y) | (x != UINT_MAX);
+}
+
+vector signed or3(vector signed x, vector signed y)
+{
+  /* (x <= y) | (x != INT_MIN)  --> true */
+  return (x <= y) | (x != INT_MIN);
+}
+
+vector signed or4(vector signed x, vector signed y)
+{
+  /* (x >= y) | (x != INT_MAX)  --> true */
+  return (x >= y) | (x != INT_MAX);
+}
+
+/* { dg-final { scan-tree-dump-not " != " "optimized" } } */
+/* { dg-final { scan-tree-dump-not " <= " "optimized" } } */
+/* { dg-final { scan-tree-dump-not " >= " "optimized" } } */
diff --git a/gcc/testsuite/gcc.dg/pr110915-11.c b/gcc/testsuite/gcc.dg/pr110915-11.c
new file mode 100644
index 00000000000..0288e53b16b
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr110915-11.c
@@ -0,0 +1,31 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-ifcombine" } */
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
+#include <limits.h>
+
+vector unsigned or1(vector unsigned x, vector unsigned y)
+{
+  /* (x <= y) | (x == 0)  --> x <= y */
+  return (x <= y) | (x == 0);
+}
+
+vector unsigned or2(vector unsigned x, vector unsigned y)
+{
+  /* (x >= y) | (x == UINT_MAX)  --> x >= y */
+  return (x >= y) | (x == UINT_MAX);
+}
+
+vector signed or3(vector signed x, vector signed y)
+{
+  /* (x <= y) | (x == INT_MIN)  --> x <= y */
+  return (x <= y) | (x == INT_MIN);
+}
+
+vector signed or4(vector signed x, vector signed y)
+{
+  /* (x >= y) | (x == INT_MAX)  --> x >= y */
+  return (x >= y) | (x == INT_MAX);
+}
+
+/* { dg-final { scan-tree-dump-not " == " "ifcombine" } } */
diff --git a/gcc/testsuite/gcc.dg/pr110915-12.c b/gcc/testsuite/gcc.dg/pr110915-12.c
new file mode 100644
index 00000000000..054a077ce3e
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr110915-12.c
@@ -0,0 +1,31 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-dce3" } */
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
+#include <limits.h>
+
+vector unsigned or1(vector unsigned x, vector unsigned y)
+{
+  /* (x <= y) | (x == 0)  --> x <= y */
+  return (x <= y) | (x == 0);
+}
+
+vector unsigned or2(vector unsigned x, vector unsigned y)
+{
+  /* (x >= y) | (x == UINT_MAX)  --> x >= y */
+  return (x >= y) | (x == UINT_MAX);
+}
+
+vector signed or3(vector signed x, vector signed y)
+{
+  /* (x <= y) | (x == INT_MIN)  --> x <= y */
+  return (x <= y) | (x == INT_MIN);
+}
+
+vector signed or4(vector signed x, vector signed y)
+{
+  /* (x >= y) | (x == INT_MAX)  --> x >= y */
+  return (x >= y) | (x == INT_MAX);
+}
+
+/* { dg-final { scan-tree-dump-not " == " "dce3" } } */
diff --git a/gcc/testsuite/gcc.dg/pr110915-2.c b/gcc/testsuite/gcc.dg/pr110915-2.c
new file mode 100644
index 00000000000..3962b152078
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr110915-2.c
@@ -0,0 +1,31 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-optimized" } */
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
+#include <limits.h>
+
+vector signed and1(vector unsigned x, vector unsigned y)
+{
+  /* (x > y)   &   (x != 0)  --> x > y */
+  return (x > y)   &   (x != 0);
+}
+
+vector signed and2(vector unsigned x, vector unsigned y)
+{
+  /* (x < y)   &   (x != UINT_MAX)  --> x < y */
+  return (x < y)   &   (x != UINT_MAX);
+}
+
+vector signed and3(vector signed x, vector signed y)
+{
+  /* (x > y)   &   (x != INT_MIN)  --> x > y */
+  return (x > y)   &   (x != INT_MIN);
+}
+
+vector signed and4(vector signed x, vector signed y)
+{
+  /* (x < y)   &   (x != INT_MAX)  --> x < y */
+  return (x < y)   &   (x != INT_MAX);
+}
+
+/* { dg-final { scan-tree-dump-not " != " "optimized" } } */
diff --git a/gcc/testsuite/gcc.dg/pr110915-3.c b/gcc/testsuite/gcc.dg/pr110915-3.c
new file mode 100644
index 00000000000..c6462b59526
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr110915-3.c
@@ -0,0 +1,33 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-ifcombine" } */
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
+#include <limits.h>
+
+vector signed and1(vector unsigned x, vector unsigned y)
+{
+  /* (x > y)   &   (x == 0)  --> false */
+  return (x > y)   &   (x == 0);
+}
+
+vector signed and2(vector unsigned x, vector unsigned y)
+{
+  /* (x < y)   &   (x == UINT_MAX)  --> false */
+  return (x < y)   &   (x == UINT_MAX);
+}
+
+vector signed and3(vector signed x, vector signed y)
+{
+  /* (x > y)   &   (x == INT_MIN)  --> false */
+  return (x > y)   &   (x == INT_MIN);
+}
+
+vector signed and4(vector signed x, vector signed y)
+{
+  /* (x < y)   &   (x == INT_MAX)  --> false */
+  return (x < y)   &   (x == INT_MAX);
+}
+
+/* { dg-final { scan-tree-dump-not " == " "ifcombine" } } */
+/* { dg-final { scan-tree-dump-not " > " "ifcombine" } } */
+/* { dg-final { scan-tree-dump-not " < " "ifcombine" } } */
diff --git a/gcc/testsuite/gcc.dg/pr110915-4.c b/gcc/testsuite/gcc.dg/pr110915-4.c
new file mode 100644
index 00000000000..5b28ccdd321
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr110915-4.c
@@ -0,0 +1,33 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-optimized" } */
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
+#include <limits.h>
+
+vector signed and1(vector unsigned x, vector unsigned y)
+{
+  /* (x > y)   &   (x == 0)  --> false */
+  return (x > y)   &   (x == 0);
+}
+
+vector signed and2(vector unsigned x, vector unsigned y)
+{
+  /* (x < y)   &   (x == UINT_MAX)  --> false */
+  return (x < y)   &   (x == UINT_MAX);
+}
+
+vector signed and3(vector signed x, vector signed y)
+{
+  /* (x > y)   &   (x == INT_MIN)  --> false */
+  return (x > y)   &   (x == INT_MIN);
+}
+
+vector signed and4(vector signed x, vector signed y)
+{
+  /* (x < y)   &   (x == INT_MAX)  --> false */
+  return (x < y)   &   (x == INT_MAX);
+}
+
+/* { dg-final { scan-tree-dump-not " == " "optimized" } } */
+/* { dg-final { scan-tree-dump-not " > " "optimized" } } */
+/* { dg-final { scan-tree-dump-not " < " "optimized" } } */
diff --git a/gcc/testsuite/gcc.dg/pr110915-5.c b/gcc/testsuite/gcc.dg/pr110915-5.c
new file mode 100644
index 00000000000..a8b871d5bca
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr110915-5.c
@@ -0,0 +1,32 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-ifcombine" } */
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
+#include <limits.h>
+
+vector signed and1(vector unsigned x, vector unsigned y)
+{
+  /* (x <= y)   &   (x == 0)  --> x == 0 */
+  return (x <= y)   &   (x == 0);
+}
+
+vector signed and2(vector unsigned x, vector unsigned y)
+{
+  /* (x >= y)   &   (x == UINT_MAX)  --> x == UINT_MAX */
+  return (x >= y)   &   (x == UINT_MAX);
+}
+
+vector signed and3(vector signed x, vector signed y)
+{
+  /* (x <= y)   &   (x == INT_MIN)  --> x == INT_MIN */
+  return (x <= y)   &   (x == INT_MIN);
+}
+
+vector signed and4(vector signed x, vector signed y)
+{
+  /* (x >= y)   &   (x == INT_MAX)  --> x == INT_MAX */
+  return (x >= y)   &   (x == INT_MAX);
+}
+
+/* { dg-final { scan-tree-dump-not " <= " "ifcombine" } } */
+/* { dg-final { scan-tree-dump-not " >= " "ifcombine" } } */
diff --git a/gcc/testsuite/gcc.dg/pr110915-6.c b/gcc/testsuite/gcc.dg/pr110915-6.c
new file mode 100644
index 00000000000..a3b9cc02a4b
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr110915-6.c
@@ -0,0 +1,32 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-optimized" } */
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
+#include <limits.h>
+
+vector signed and1(vector unsigned x, vector unsigned y)
+{
+  /* (x <= y)   &   (x == 0)  --> x == 0 */
+  return (x <= y)   &   (x == 0);
+}
+
+vector signed and2(vector unsigned x, vector unsigned y)
+{
+  /* (x >= y)   &   (x == UINT_MAX)  --> x == UINT_MAX */
+  return (x >= y)   &   (x == UINT_MAX);
+}
+
+vector signed and3(vector signed x, vector signed y)
+{
+  /* (x <= y)   &   (x == INT_MIN)  --> x == INT_MIN */
+  return (x <= y)   &   (x == INT_MIN);
+}
+
+vector signed and4(vector signed x, vector signed y)
+{
+  /* (x >= y)   &   (x == INT_MAX)  --> x == INT_MAX */
+  return (x >= y)   &   (x == INT_MAX);
+}
+
+/* { dg-final { scan-tree-dump-not " <= " "optimized" } } */
+/* { dg-final { scan-tree-dump-not " >= " "optimized" } } */
diff --git a/gcc/testsuite/gcc.dg/pr110915-7.c b/gcc/testsuite/gcc.dg/pr110915-7.c
new file mode 100644
index 00000000000..fd331e90e4a
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr110915-7.c
@@ -0,0 +1,32 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-ifcombine" } */
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
+#include <limits.h>
+
+vector signed or1(vector unsigned x, vector unsigned y)
+{
+  /* (x > y) | (x != 0)  --> x != 0 */
+  return (x > y) | (x != 0);
+}
+
+vector signed or2(vector unsigned x, vector unsigned y)
+{
+  /* (x < y) | (x != UINT_MAX)  --> x != UINT_MAX */
+  return (x < y) | (x != UINT_MAX);
+}
+
+vector signed or3(vector signed x, vector signed y)
+{
+  /* (x > y) | (x != INT_MIN)  --> x != INT_MIN */
+  return (x > y) | (x != INT_MIN);
+}
+
+vector signed or4(vector signed x, vector signed y)
+{
+  /* (x < y) | (x != INT_MAX)  --> x != INT_MAX */
+  return (x < y) | (x != INT_MAX);
+}
+
+/* { dg-final { scan-tree-dump-not " > " "ifcombine" } } */
+/* { dg-final { scan-tree-dump-not " < " "ifcombine" } } */
diff --git a/gcc/testsuite/gcc.dg/pr110915-8.c b/gcc/testsuite/gcc.dg/pr110915-8.c
new file mode 100644
index 00000000000..fae533cbf22
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr110915-8.c
@@ -0,0 +1,32 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-optimized" } */
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
+#include <limits.h>
+
+vector signed or1(vector unsigned x, vector unsigned y)
+{
+  /* (x > y) | (x != 0)  --> x != 0 */
+  return (x > y) | (x != 0);
+}
+
+vector signed or2(vector unsigned x, vector unsigned y)
+{
+  /* (x < y) | (x != UINT_MAX)  --> x != UINT_MAX */
+  return (x < y) | (x != UINT_MAX);
+}
+
+vector signed or3(vector signed x, vector signed y)
+{
+  /* (x > y) | (x != INT_MIN)  --> x != INT_MIN */
+  return (x > y) | (x != INT_MIN);
+}
+
+vector signed or4(vector signed x, vector signed y)
+{
+  /* (x < y) | (x != INT_MAX)  --> x != INT_MAX */
+  return (x < y) | (x != INT_MAX);
+}
+
+/* { dg-final { scan-tree-dump-not " > " "optimized" } } */
+/* { dg-final { scan-tree-dump-not " < " "optimized" } } */
diff --git a/gcc/testsuite/gcc.dg/pr110915-9.c b/gcc/testsuite/gcc.dg/pr110915-9.c
new file mode 100644
index 00000000000..07aa08ee00b
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr110915-9.c
@@ -0,0 +1,33 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-ifcombine" } */
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
+#include <limits.h>
+
+vector signed or1(vector unsigned x, vector unsigned y)
+{
+  /* (x <= y) | (x != 0)  --> true */
+  return (x <= y) | (x != 0);
+}
+
+vector signed or2(vector unsigned x, vector unsigned y)
+{
+  /* (x >= y) | (x != UINT_MAX)  --> true */
+  return (x >= y) | (x != UINT_MAX);
+}
+
+vector signed or3(vector signed x, vector signed y)
+{
+  /* (x <= y) | (x != INT_MIN)  --> true */
+  return (x <= y) | (x != INT_MIN);
+}
+
+vector signed or4(vector signed x, vector signed y)
+{
+  /* (x >= y) | (x != INT_MAX)  --> true */
+  return (x >= y) | (x != INT_MAX);
+}
+
+/* { dg-final { scan-tree-dump-not " != " "ifcombine" } } */
+/* { dg-final { scan-tree-dump-not " <= " "ifcombine" } } */
+/* { dg-final { scan-tree-dump-not " >= " "ifcombine" } } */
-- 
2.31.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] MATCH: extend min_value/max_value match to vectors
  2023-08-30 22:25 [PATCH] MATCH: extend min_value/max_value match to vectors Andrew Pinski
@ 2023-08-31 12:16 ` Richard Biener
  2023-09-01 12:26 ` [committed] testsuite: Fix up pr110915* tests on i686-linux [PR110915] Jakub Jelinek
  1 sibling, 0 replies; 3+ messages in thread
From: Richard Biener @ 2023-08-31 12:16 UTC (permalink / raw)
  To: Andrew Pinski; +Cc: gcc-patches

On Thu, Aug 31, 2023 at 12:27 AM Andrew Pinski via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> This simple patch extends the min_value/max_value match to vector integer types.
> Using uniform_integer_cst_p makes this easy.
>
> OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions.
>
> The testcases pr110915-*.c are the same as pr88784-*.c except using vector
> types instead.

OK.

>         PR tree-optimization/110915
>
> gcc/ChangeLog:
>
>         * match.pd (min_value, max_value): Extend to vector constants.
>
> gcc/testsuite/ChangeLog:
>
>         * gcc.dg/pr110915-1.c: New test.
>         * gcc.dg/pr110915-10.c: New test.
>         * gcc.dg/pr110915-11.c: New test.
>         * gcc.dg/pr110915-12.c: New test.
>         * gcc.dg/pr110915-2.c: New test.
>         * gcc.dg/pr110915-3.c: New test.
>         * gcc.dg/pr110915-4.c: New test.
>         * gcc.dg/pr110915-5.c: New test.
>         * gcc.dg/pr110915-6.c: New test.
>         * gcc.dg/pr110915-7.c: New test.
>         * gcc.dg/pr110915-8.c: New test.
>         * gcc.dg/pr110915-9.c: New test.
> ---
>  gcc/match.pd                       | 24 ++++++++++++++--------
>  gcc/testsuite/gcc.dg/pr110915-1.c  | 31 ++++++++++++++++++++++++++++
>  gcc/testsuite/gcc.dg/pr110915-10.c | 33 ++++++++++++++++++++++++++++++
>  gcc/testsuite/gcc.dg/pr110915-11.c | 31 ++++++++++++++++++++++++++++
>  gcc/testsuite/gcc.dg/pr110915-12.c | 31 ++++++++++++++++++++++++++++
>  gcc/testsuite/gcc.dg/pr110915-2.c  | 31 ++++++++++++++++++++++++++++
>  gcc/testsuite/gcc.dg/pr110915-3.c  | 33 ++++++++++++++++++++++++++++++
>  gcc/testsuite/gcc.dg/pr110915-4.c  | 33 ++++++++++++++++++++++++++++++
>  gcc/testsuite/gcc.dg/pr110915-5.c  | 32 +++++++++++++++++++++++++++++
>  gcc/testsuite/gcc.dg/pr110915-6.c  | 32 +++++++++++++++++++++++++++++
>  gcc/testsuite/gcc.dg/pr110915-7.c  | 32 +++++++++++++++++++++++++++++
>  gcc/testsuite/gcc.dg/pr110915-8.c  | 32 +++++++++++++++++++++++++++++
>  gcc/testsuite/gcc.dg/pr110915-9.c  | 33 ++++++++++++++++++++++++++++++
>  13 files changed, 400 insertions(+), 8 deletions(-)
>  create mode 100644 gcc/testsuite/gcc.dg/pr110915-1.c
>  create mode 100644 gcc/testsuite/gcc.dg/pr110915-10.c
>  create mode 100644 gcc/testsuite/gcc.dg/pr110915-11.c
>  create mode 100644 gcc/testsuite/gcc.dg/pr110915-12.c
>  create mode 100644 gcc/testsuite/gcc.dg/pr110915-2.c
>  create mode 100644 gcc/testsuite/gcc.dg/pr110915-3.c
>  create mode 100644 gcc/testsuite/gcc.dg/pr110915-4.c
>  create mode 100644 gcc/testsuite/gcc.dg/pr110915-5.c
>  create mode 100644 gcc/testsuite/gcc.dg/pr110915-6.c
>  create mode 100644 gcc/testsuite/gcc.dg/pr110915-7.c
>  create mode 100644 gcc/testsuite/gcc.dg/pr110915-8.c
>  create mode 100644 gcc/testsuite/gcc.dg/pr110915-9.c
>
> diff --git a/gcc/match.pd b/gcc/match.pd
> index 6a7edde5736..c01362ee359 100644
> --- a/gcc/match.pd
> +++ b/gcc/match.pd
> @@ -2750,16 +2750,24 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT)
>                                & (bitpos / BITS_PER_UNIT))); }))))
>
>  (match min_value
> - INTEGER_CST
> - (if ((INTEGRAL_TYPE_P (type)
> -       || POINTER_TYPE_P(type))
> -      && wi::eq_p (wi::to_wide (t), wi::min_value (type)))))
> + uniform_integer_cst_p
> + (with {
> +   tree int_cst = uniform_integer_cst_p (t);
> +   tree inner_type = TREE_TYPE (int_cst);
> +  }
> +  (if ((INTEGRAL_TYPE_P (inner_type)
> +        || POINTER_TYPE_P (inner_type))
> +       && wi::eq_p (wi::to_wide (int_cst), wi::min_value (inner_type))))))
>
>  (match max_value
> - INTEGER_CST
> - (if ((INTEGRAL_TYPE_P (type)
> -       || POINTER_TYPE_P(type))
> -      && wi::eq_p (wi::to_wide (t), wi::max_value (type)))))
> + uniform_integer_cst_p
> + (with {
> +   tree int_cst = uniform_integer_cst_p (t);
> +   tree itype = TREE_TYPE (int_cst);
> +  }
> + (if ((INTEGRAL_TYPE_P (itype)
> +       || POINTER_TYPE_P (itype))
> +      && wi::eq_p (wi::to_wide (int_cst), wi::max_value (itype))))))
>
>  /* x >  y  &&  x != XXX_MIN  -->  x > y
>     x >  y  &&  x == XXX_MIN  -->  false . */
> diff --git a/gcc/testsuite/gcc.dg/pr110915-1.c b/gcc/testsuite/gcc.dg/pr110915-1.c
> new file mode 100644
> index 00000000000..2e1e871b9a0
> --- /dev/null
> +++ b/gcc/testsuite/gcc.dg/pr110915-1.c
> @@ -0,0 +1,31 @@
> +/* { dg-do compile } */
> +/* { dg-options "-O2 -fdump-tree-ifcombine" } */
> +#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
> +
> +#include <limits.h>
> +
> +vector signed and1(vector unsigned x, vector unsigned y)
> +{
> +  /* (x > y) & (x != 0)  --> x > y */
> +  return (x > y) & (x != 0);
> +}
> +
> +vector signed and2(vector unsigned x, vector unsigned y)
> +{
> +  /* (x < y) & (x != UINT_MAX)  --> x < y */
> +  return (x < y) & (x != UINT_MAX);
> +}
> +
> +vector signed and3(vector signed x, vector signed y)
> +{
> +  /* (x > y) & (x != INT_MIN)  --> x > y */
> +  return (x > y) & (x != INT_MIN);
> +}
> +
> +vector signed and4(vector signed x, vector signed y)
> +{
> +  /* (x < y) & (x != INT_MAX)  --> x < y */
> +  return (x < y) & (x != INT_MAX);
> +}
> +
> +/* { dg-final { scan-tree-dump-not " != " "ifcombine" } } */
> diff --git a/gcc/testsuite/gcc.dg/pr110915-10.c b/gcc/testsuite/gcc.dg/pr110915-10.c
> new file mode 100644
> index 00000000000..b0644bf3123
> --- /dev/null
> +++ b/gcc/testsuite/gcc.dg/pr110915-10.c
> @@ -0,0 +1,33 @@
> +/* { dg-do compile } */
> +/* { dg-options "-O2 -fdump-tree-optimized" } */
> +#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
> +
> +#include <limits.h>
> +
> +vector unsigned or1(vector unsigned x, vector unsigned y)
> +{
> +  /* (x <= y) | (x != 0))  --> true */
> +  return (x <= y) | (x != 0);
> +}
> +
> +vector unsigned or2(vector unsigned x, vector unsigned y)
> +{
> +  /* (x >= y) | (x != UINT_MAX)  --> true */
> +  return (x >= y) | (x != UINT_MAX);
> +}
> +
> +vector signed or3(vector signed x, vector signed y)
> +{
> +  /* (x <= y) | (x != INT_MIN)  --> true */
> +  return (x <= y) | (x != INT_MIN);
> +}
> +
> +vector signed or4(vector signed x, vector signed y)
> +{
> +  /* (x >= y) | (x != INT_MAX)  --> true */
> +  return (x >= y) | (x != INT_MAX);
> +}
> +
> +/* { dg-final { scan-tree-dump-not " != " "optimized" } } */
> +/* { dg-final { scan-tree-dump-not " <= " "optimized" } } */
> +/* { dg-final { scan-tree-dump-not " >= " "optimized" } } */
> diff --git a/gcc/testsuite/gcc.dg/pr110915-11.c b/gcc/testsuite/gcc.dg/pr110915-11.c
> new file mode 100644
> index 00000000000..0288e53b16b
> --- /dev/null
> +++ b/gcc/testsuite/gcc.dg/pr110915-11.c
> @@ -0,0 +1,31 @@
> +/* { dg-do compile } */
> +/* { dg-options "-O2 -fdump-tree-ifcombine" } */
> +#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
> +
> +#include <limits.h>
> +
> +vector unsigned or1(vector unsigned x, vector unsigned y)
> +{
> +  /* (x <= y) | (x == 0)  --> x <= y */
> +  return (x <= y) | (x == 0);
> +}
> +
> +vector unsigned or2(vector unsigned x, vector unsigned y)
> +{
> +  /* (x >= y) | (x == UINT_MAX)  --> x >= y */
> +  return (x >= y) | (x == UINT_MAX);
> +}
> +
> +vector signed or3(vector signed x, vector signed y)
> +{
> +  /* (x <= y) | (x == INT_MIN)  --> x <= y */
> +  return (x <= y) | (x == INT_MIN);
> +}
> +
> +vector signed or4(vector signed x, vector signed y)
> +{
> +  /* (x >= y) | (x == INT_MAX)  --> x >= y */
> +  return (x >= y) | (x == INT_MAX);
> +}
> +
> +/* { dg-final { scan-tree-dump-not " == " "ifcombine" } } */
> diff --git a/gcc/testsuite/gcc.dg/pr110915-12.c b/gcc/testsuite/gcc.dg/pr110915-12.c
> new file mode 100644
> index 00000000000..054a077ce3e
> --- /dev/null
> +++ b/gcc/testsuite/gcc.dg/pr110915-12.c
> @@ -0,0 +1,31 @@
> +/* { dg-do compile } */
> +/* { dg-options "-O2 -fdump-tree-dce3" } */
> +#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
> +
> +#include <limits.h>
> +
> +vector unsigned or1(vector unsigned x, vector unsigned y)
> +{
> +  /* (x <= y) | (x == 0)  --> x <= y */
> +  return (x <= y) | (x == 0);
> +}
> +
> +vector unsigned or2(vector unsigned x, vector unsigned y)
> +{
> +  /* (x >= y) | (x == UINT_MAX)  --> x >= y */
> +  return (x >= y) | (x == UINT_MAX);
> +}
> +
> +vector signed or3(vector signed x, vector signed y)
> +{
> +  /* (x <= y) | (x == INT_MIN)  --> x <= y */
> +  return (x <= y) | (x == INT_MIN);
> +}
> +
> +vector signed or4(vector signed x, vector signed y)
> +{
> +  /* (x >= y) | (x == INT_MAX)  --> x >= y */
> +  return (x >= y) | (x == INT_MAX);
> +}
> +
> +/* { dg-final { scan-tree-dump-not " == " "dce3" } } */
> diff --git a/gcc/testsuite/gcc.dg/pr110915-2.c b/gcc/testsuite/gcc.dg/pr110915-2.c
> new file mode 100644
> index 00000000000..3962b152078
> --- /dev/null
> +++ b/gcc/testsuite/gcc.dg/pr110915-2.c
> @@ -0,0 +1,31 @@
> +/* { dg-do compile } */
> +/* { dg-options "-O2 -fdump-tree-optimized" } */
> +#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
> +
> +#include <limits.h>
> +
> +vector signed and1(vector unsigned x, vector unsigned y)
> +{
> +  /* (x > y)   &   (x != 0)  --> x > y */
> +  return (x > y)   &   (x != 0);
> +}
> +
> +vector signed and2(vector unsigned x, vector unsigned y)
> +{
> +  /* (x < y)   &   (x != UINT_MAX)  --> x < y */
> +  return (x < y)   &   (x != UINT_MAX);
> +}
> +
> +vector signed and3(vector signed x, vector signed y)
> +{
> +  /* (x > y)   &   (x != INT_MIN)  --> x > y */
> +  return (x > y)   &   (x != INT_MIN);
> +}
> +
> +vector signed and4(vector signed x, vector signed y)
> +{
> +  /* (x < y)   &   (x != INT_MAX)  --> x < y */
> +  return (x < y)   &   (x != INT_MAX);
> +}
> +
> +/* { dg-final { scan-tree-dump-not " != " "optimized" } } */
> diff --git a/gcc/testsuite/gcc.dg/pr110915-3.c b/gcc/testsuite/gcc.dg/pr110915-3.c
> new file mode 100644
> index 00000000000..c6462b59526
> --- /dev/null
> +++ b/gcc/testsuite/gcc.dg/pr110915-3.c
> @@ -0,0 +1,33 @@
> +/* { dg-do compile } */
> +/* { dg-options "-O2 -fdump-tree-ifcombine" } */
> +#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
> +
> +#include <limits.h>
> +
> +vector signed and1(vector unsigned x, vector unsigned y)
> +{
> +  /* (x > y)   &   (x == 0)  --> false */
> +  return (x > y)   &   (x == 0);
> +}
> +
> +vector signed and2(vector unsigned x, vector unsigned y)
> +{
> +  /* (x < y)   &   (x == UINT_MAX)  --> false */
> +  return (x < y)   &   (x == UINT_MAX);
> +}
> +
> +vector signed and3(vector signed x, vector signed y)
> +{
> +  /* (x > y)   &   (x == INT_MIN)  --> false */
> +  return (x > y)   &   (x == INT_MIN);
> +}
> +
> +vector signed and4(vector signed x, vector signed y)
> +{
> +  /* (x < y)   &   (x == INT_MAX)  --> false */
> +  return (x < y)   &   (x == INT_MAX);
> +}
> +
> +/* { dg-final { scan-tree-dump-not " == " "ifcombine" } } */
> +/* { dg-final { scan-tree-dump-not " > " "ifcombine" } } */
> +/* { dg-final { scan-tree-dump-not " < " "ifcombine" } } */
> diff --git a/gcc/testsuite/gcc.dg/pr110915-4.c b/gcc/testsuite/gcc.dg/pr110915-4.c
> new file mode 100644
> index 00000000000..5b28ccdd321
> --- /dev/null
> +++ b/gcc/testsuite/gcc.dg/pr110915-4.c
> @@ -0,0 +1,33 @@
> +/* { dg-do compile } */
> +/* { dg-options "-O2 -fdump-tree-optimized" } */
> +#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
> +
> +#include <limits.h>
> +
> +vector signed and1(vector unsigned x, vector unsigned y)
> +{
> +  /* (x > y)   &   (x == 0)  --> false */
> +  return (x > y)   &   (x == 0);
> +}
> +
> +vector signed and2(vector unsigned x, vector unsigned y)
> +{
> +  /* (x < y)   &   (x == UINT_MAX)  --> false */
> +  return (x < y)   &   (x == UINT_MAX);
> +}
> +
> +vector signed and3(vector signed x, vector signed y)
> +{
> +  /* (x > y)   &   (x == INT_MIN)  --> false */
> +  return (x > y)   &   (x == INT_MIN);
> +}
> +
> +vector signed and4(vector signed x, vector signed y)
> +{
> +  /* (x < y)   &   (x == INT_MAX)  --> false */
> +  return (x < y)   &   (x == INT_MAX);
> +}
> +
> +/* { dg-final { scan-tree-dump-not " == " "optimized" } } */
> +/* { dg-final { scan-tree-dump-not " > " "optimized" } } */
> +/* { dg-final { scan-tree-dump-not " < " "optimized" } } */
> diff --git a/gcc/testsuite/gcc.dg/pr110915-5.c b/gcc/testsuite/gcc.dg/pr110915-5.c
> new file mode 100644
> index 00000000000..a8b871d5bca
> --- /dev/null
> +++ b/gcc/testsuite/gcc.dg/pr110915-5.c
> @@ -0,0 +1,32 @@
> +/* { dg-do compile } */
> +/* { dg-options "-O2 -fdump-tree-ifcombine" } */
> +#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
> +
> +#include <limits.h>
> +
> +vector signed and1(vector unsigned x, vector unsigned y)
> +{
> +  /* (x <= y)   &   (x == 0)  --> x == 0 */
> +  return (x <= y)   &   (x == 0);
> +}
> +
> +vector signed and2(vector unsigned x, vector unsigned y)
> +{
> +  /* (x >= y)   &   (x == UINT_MAX)  --> x == UINT_MAX */
> +  return (x >= y)   &   (x == UINT_MAX);
> +}
> +
> +vector signed and3(vector signed x, vector signed y)
> +{
> +  /* (x <= y)   &   (x == INT_MIN)  --> x == INT_MIN */
> +  return (x <= y)   &   (x == INT_MIN);
> +}
> +
> +vector signed and4(vector signed x, vector signed y)
> +{
> +  /* (x >= y)   &   (x == INT_MAX)  --> x == INT_MAX */
> +  return (x >= y)   &   (x == INT_MAX);
> +}
> +
> +/* { dg-final { scan-tree-dump-not " <= " "ifcombine" } } */
> +/* { dg-final { scan-tree-dump-not " >= " "ifcombine" } } */
> diff --git a/gcc/testsuite/gcc.dg/pr110915-6.c b/gcc/testsuite/gcc.dg/pr110915-6.c
> new file mode 100644
> index 00000000000..a3b9cc02a4b
> --- /dev/null
> +++ b/gcc/testsuite/gcc.dg/pr110915-6.c
> @@ -0,0 +1,32 @@
> +/* { dg-do compile } */
> +/* { dg-options "-O2 -fdump-tree-optimized" } */
> +#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
> +
> +#include <limits.h>
> +
> +vector signed and1(vector unsigned x, vector unsigned y)
> +{
> +  /* (x <= y)   &   (x == 0)  --> x == 0 */
> +  return (x <= y)   &   (x == 0);
> +}
> +
> +vector signed and2(vector unsigned x, vector unsigned y)
> +{
> +  /* (x >= y)   &   (x == UINT_MAX)  --> x == UINT_MAX */
> +  return (x >= y)   &   (x == UINT_MAX);
> +}
> +
> +vector signed and3(vector signed x, vector signed y)
> +{
> +  /* (x <= y)   &   (x == INT_MIN)  --> x == INT_MIN */
> +  return (x <= y)   &   (x == INT_MIN);
> +}
> +
> +vector signed and4(vector signed x, vector signed y)
> +{
> +  /* (x >= y)   &   (x == INT_MAX)  --> x == INT_MAX */
> +  return (x >= y)   &   (x == INT_MAX);
> +}
> +
> +/* { dg-final { scan-tree-dump-not " <= " "optimized" } } */
> +/* { dg-final { scan-tree-dump-not " >= " "optimized" } } */
> diff --git a/gcc/testsuite/gcc.dg/pr110915-7.c b/gcc/testsuite/gcc.dg/pr110915-7.c
> new file mode 100644
> index 00000000000..fd331e90e4a
> --- /dev/null
> +++ b/gcc/testsuite/gcc.dg/pr110915-7.c
> @@ -0,0 +1,32 @@
> +/* { dg-do compile } */
> +/* { dg-options "-O2 -fdump-tree-ifcombine" } */
> +#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
> +
> +#include <limits.h>
> +
> +vector signed or1(vector unsigned x, vector unsigned y)
> +{
> +  /* (x > y) | (x != 0)  --> x != 0 */
> +  return (x > y) | (x != 0);
> +}
> +
> +vector signed or2(vector unsigned x, vector unsigned y)
> +{
> +  /* (x < y) | (x != UINT_MAX)  --> x != UINT_MAX */
> +  return (x < y) | (x != UINT_MAX);
> +}
> +
> +vector signed or3(vector signed x, vector signed y)
> +{
> +  /* (x > y) | (x != INT_MIN)  --> x != INT_MIN */
> +  return (x > y) | (x != INT_MIN);
> +}
> +
> +vector signed or4(vector signed x, vector signed y)
> +{
> +  /* (x < y) | (x != INT_MAX)  --> x != INT_MAX */
> +  return (x < y) | (x != INT_MAX);
> +}
> +
> +/* { dg-final { scan-tree-dump-not " > " "ifcombine" } } */
> +/* { dg-final { scan-tree-dump-not " < " "ifcombine" } } */
> diff --git a/gcc/testsuite/gcc.dg/pr110915-8.c b/gcc/testsuite/gcc.dg/pr110915-8.c
> new file mode 100644
> index 00000000000..fae533cbf22
> --- /dev/null
> +++ b/gcc/testsuite/gcc.dg/pr110915-8.c
> @@ -0,0 +1,32 @@
> +/* { dg-do compile } */
> +/* { dg-options "-O2 -fdump-tree-optimized" } */
> +#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
> +
> +#include <limits.h>
> +
> +vector signed or1(vector unsigned x, vector unsigned y)
> +{
> +  /* (x > y) | (x != 0)  --> x != 0 */
> +  return (x > y) | (x != 0);
> +}
> +
> +vector signed or2(vector unsigned x, vector unsigned y)
> +{
> +  /* (x < y) | (x != UINT_MAX)  --> x != UINT_MAX */
> +  return (x < y) | (x != UINT_MAX);
> +}
> +
> +vector signed or3(vector signed x, vector signed y)
> +{
> +  /* (x > y) | (x != INT_MIN)  --> x != INT_MIN */
> +  return (x > y) | (x != INT_MIN);
> +}
> +
> +vector signed or4(vector signed x, vector signed y)
> +{
> +  /* (x < y) | (x != INT_MAX)  --> x != INT_MAX */
> +  return (x < y) | (x != INT_MAX);
> +}
> +
> +/* { dg-final { scan-tree-dump-not " > " "optimized" } } */
> +/* { dg-final { scan-tree-dump-not " < " "optimized" } } */
> diff --git a/gcc/testsuite/gcc.dg/pr110915-9.c b/gcc/testsuite/gcc.dg/pr110915-9.c
> new file mode 100644
> index 00000000000..07aa08ee00b
> --- /dev/null
> +++ b/gcc/testsuite/gcc.dg/pr110915-9.c
> @@ -0,0 +1,33 @@
> +/* { dg-do compile } */
> +/* { dg-options "-O2 -fdump-tree-ifcombine" } */
> +#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
> +
> +#include <limits.h>
> +
> +vector signed or1(vector unsigned x, vector unsigned y)
> +{
> +  /* (x <= y) | (x != 0)  --> true */
> +  return (x <= y) | (x != 0);
> +}
> +
> +vector signed or2(vector unsigned x, vector unsigned y)
> +{
> +  /* (x >= y) | (x != UINT_MAX)  --> true */
> +  return (x >= y) | (x != UINT_MAX);
> +}
> +
> +vector signed or3(vector signed x, vector signed y)
> +{
> +  /* (x <= y) | (x != INT_MIN)  --> true */
> +  return (x <= y) | (x != INT_MIN);
> +}
> +
> +vector signed or4(vector signed x, vector signed y)
> +{
> +  /* (x >= y) | (x != INT_MAX)  --> true */
> +  return (x >= y) | (x != INT_MAX);
> +}
> +
> +/* { dg-final { scan-tree-dump-not " != " "ifcombine" } } */
> +/* { dg-final { scan-tree-dump-not " <= " "ifcombine" } } */
> +/* { dg-final { scan-tree-dump-not " >= " "ifcombine" } } */
> --
> 2.31.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [committed] testsuite: Fix up pr110915* tests on i686-linux [PR110915]
  2023-08-30 22:25 [PATCH] MATCH: extend min_value/max_value match to vectors Andrew Pinski
  2023-08-31 12:16 ` Richard Biener
@ 2023-09-01 12:26 ` Jakub Jelinek
  1 sibling, 0 replies; 3+ messages in thread
From: Jakub Jelinek @ 2023-09-01 12:26 UTC (permalink / raw)
  To: Andrew Pinski; +Cc: gcc-patches

On Wed, Aug 30, 2023 at 03:25:11PM -0700, Andrew Pinski via Gcc-patches wrote:
> This simple patch extends the min_value/max_value match to vector integer types.
> Using uniform_integer_cst_p makes this easy.

These tests FAIL on i686-linux, with
.../gcc/testsuite/gcc.dg/pr110915-1.c:8:1: warning: MMX vector return without MMX enabled changes the ABI [-Wpsabi]
.../gcc/testsuite/gcc.dg/pr110915-1.c:7:15: warning: MMX vector argument without MMX enabled changes the ABI [-Wpsabi]
excess warnings.  I've added -Wno-psabi to quiet that up, plus I think
it is undesirable to define macros like vector before including C library
headers in case the header would use that identifier in non-obfuscated
form somewhere.

Tested on x86_64-linux with
make check-gcc RUNTESTFLAGS='--target_board=unix\{-m32,-m32/-march=i686,-m64\} dg.exp=pr110915*'
which previously FAILed, committed to trunk as obvious.

2023-09-01  Jakub Jelinek  <jakub@redhat.com>

	PR tree-optimization/110915
	* gcc.dg/pr110915-1.c: Add -Wno-psabi to dg-options.  Move vector
	macro definition after limits.h inclusion.
	* gcc.dg/pr110915-2.c: Likewise.
	* gcc.dg/pr110915-3.c: Likewise.
	* gcc.dg/pr110915-4.c: Likewise.
	* gcc.dg/pr110915-5.c: Likewise.
	* gcc.dg/pr110915-6.c: Likewise.
	* gcc.dg/pr110915-7.c: Likewise.
	* gcc.dg/pr110915-8.c: Likewise.
	* gcc.dg/pr110915-9.c: Likewise.
	* gcc.dg/pr110915-10.c: Likewise.
	* gcc.dg/pr110915-11.c: Likewise.
	* gcc.dg/pr110915-12.c: Likewise.

--- gcc/testsuite/gcc.dg/pr110915-1.c.jj	2023-08-31 19:52:16.889305069 +0200
+++ gcc/testsuite/gcc.dg/pr110915-1.c	2023-09-01 14:12:47.937873487 +0200
@@ -1,9 +1,10 @@
 /* { dg-do compile } */
-/* { dg-options "-O2 -fdump-tree-ifcombine" } */
-#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+/* { dg-options "-O2 -fdump-tree-ifcombine -Wno-psabi" } */
 
 #include <limits.h>
 
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
 vector signed and1(vector unsigned x, vector unsigned y)
 {
   /* (x > y) & (x != 0)  --> x > y */
--- gcc/testsuite/gcc.dg/pr110915-2.c.jj	2023-08-31 19:52:16.889305069 +0200
+++ gcc/testsuite/gcc.dg/pr110915-2.c	2023-09-01 14:12:52.791808013 +0200
@@ -1,9 +1,10 @@
 /* { dg-do compile } */
-/* { dg-options "-O2 -fdump-tree-optimized" } */
-#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+/* { dg-options "-O2 -fdump-tree-optimized -Wno-psabi" } */
 
 #include <limits.h>
 
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
 vector signed and1(vector unsigned x, vector unsigned y)
 {
   /* (x > y)   &   (x != 0)  --> x > y */
--- gcc/testsuite/gcc.dg/pr110915-3.c.jj	2023-08-31 19:52:16.889305069 +0200
+++ gcc/testsuite/gcc.dg/pr110915-3.c	2023-09-01 14:12:57.514744307 +0200
@@ -1,9 +1,10 @@
 /* { dg-do compile } */
-/* { dg-options "-O2 -fdump-tree-ifcombine" } */
-#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+/* { dg-options "-O2 -fdump-tree-ifcombine -Wno-psabi" } */
 
 #include <limits.h>
 
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
 vector signed and1(vector unsigned x, vector unsigned y)
 {
   /* (x > y)   &   (x == 0)  --> false */
--- gcc/testsuite/gcc.dg/pr110915-4.c.jj	2023-08-31 19:52:16.889305069 +0200
+++ gcc/testsuite/gcc.dg/pr110915-4.c	2023-09-01 14:13:02.094682529 +0200
@@ -1,9 +1,10 @@
 /* { dg-do compile } */
-/* { dg-options "-O2 -fdump-tree-optimized" } */
-#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+/* { dg-options "-O2 -fdump-tree-optimized -Wno-psabi" } */
 
 #include <limits.h>
 
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
 vector signed and1(vector unsigned x, vector unsigned y)
 {
   /* (x > y)   &   (x == 0)  --> false */
--- gcc/testsuite/gcc.dg/pr110915-5.c.jj	2023-08-31 19:52:16.889305069 +0200
+++ gcc/testsuite/gcc.dg/pr110915-5.c	2023-09-01 14:13:06.609621628 +0200
@@ -1,9 +1,10 @@
 /* { dg-do compile } */
-/* { dg-options "-O2 -fdump-tree-ifcombine" } */
-#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+/* { dg-options "-O2 -fdump-tree-ifcombine -Wno-psabi" } */
 
 #include <limits.h>
 
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
 vector signed and1(vector unsigned x, vector unsigned y)
 {
   /* (x <= y)   &   (x == 0)  --> x == 0 */
--- gcc/testsuite/gcc.dg/pr110915-6.c.jj	2023-08-31 19:52:16.889305069 +0200
+++ gcc/testsuite/gcc.dg/pr110915-6.c	2023-09-01 14:13:11.175560039 +0200
@@ -1,9 +1,10 @@
 /* { dg-do compile } */
-/* { dg-options "-O2 -fdump-tree-optimized" } */
-#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+/* { dg-options "-O2 -fdump-tree-optimized -Wno-psabi" } */
 
 #include <limits.h>
 
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
 vector signed and1(vector unsigned x, vector unsigned y)
 {
   /* (x <= y)   &   (x == 0)  --> x == 0 */
--- gcc/testsuite/gcc.dg/pr110915-7.c.jj	2023-08-31 19:52:16.889305069 +0200
+++ gcc/testsuite/gcc.dg/pr110915-7.c	2023-09-01 14:13:15.838497142 +0200
@@ -1,9 +1,10 @@
 /* { dg-do compile } */
-/* { dg-options "-O2 -fdump-tree-ifcombine" } */
-#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+/* { dg-options "-O2 -fdump-tree-ifcombine -Wno-psabi" } */
 
 #include <limits.h>
 
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
 vector signed or1(vector unsigned x, vector unsigned y)
 {
   /* (x > y) | (x != 0)  --> x != 0 */
--- gcc/testsuite/gcc.dg/pr110915-8.c.jj	2023-08-31 19:52:16.889305069 +0200
+++ gcc/testsuite/gcc.dg/pr110915-8.c	2023-09-01 14:13:20.579433193 +0200
@@ -1,9 +1,10 @@
 /* { dg-do compile } */
-/* { dg-options "-O2 -fdump-tree-optimized" } */
-#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+/* { dg-options "-O2 -fdump-tree-optimized -Wno-psabi" } */
 
 #include <limits.h>
 
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
 vector signed or1(vector unsigned x, vector unsigned y)
 {
   /* (x > y) | (x != 0)  --> x != 0 */
--- gcc/testsuite/gcc.dg/pr110915-9.c.jj	2023-08-31 19:52:16.889305069 +0200
+++ gcc/testsuite/gcc.dg/pr110915-9.c	2023-09-01 14:13:27.147344600 +0200
@@ -1,9 +1,10 @@
 /* { dg-do compile } */
-/* { dg-options "-O2 -fdump-tree-ifcombine" } */
-#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+/* { dg-options "-O2 -fdump-tree-ifcombine -Wno-psabi" } */
 
 #include <limits.h>
 
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
 vector signed or1(vector unsigned x, vector unsigned y)
 {
   /* (x <= y) | (x != 0)  --> true */
--- gcc/testsuite/gcc.dg/pr110915-10.c.jj	2023-08-31 19:52:16.889305069 +0200
+++ gcc/testsuite/gcc.dg/pr110915-10.c	2023-09-01 14:12:30.660106543 +0200
@@ -1,9 +1,10 @@
 /* { dg-do compile } */
-/* { dg-options "-O2 -fdump-tree-optimized" } */
-#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+/* { dg-options "-O2 -fdump-tree-optimized -Wno-psabi" } */
 
 #include <limits.h>
 
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
 vector unsigned or1(vector unsigned x, vector unsigned y)
 {
   /* (x <= y) | (x != 0))  --> true */
--- gcc/testsuite/gcc.dg/pr110915-11.c.jj	2023-08-31 19:52:16.889305069 +0200
+++ gcc/testsuite/gcc.dg/pr110915-11.c	2023-09-01 14:12:36.510027635 +0200
@@ -1,9 +1,10 @@
 /* { dg-do compile } */
-/* { dg-options "-O2 -fdump-tree-ifcombine" } */
-#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+/* { dg-options "-O2 -fdump-tree-ifcombine -Wno-psabi" } */
 
 #include <limits.h>
 
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
 vector unsigned or1(vector unsigned x, vector unsigned y)
 {
   /* (x <= y) | (x == 0)  --> x <= y */
--- gcc/testsuite/gcc.dg/pr110915-12.c.jj	2023-08-31 19:52:16.889305069 +0200
+++ gcc/testsuite/gcc.dg/pr110915-12.c	2023-09-01 14:12:41.322962714 +0200
@@ -1,9 +1,10 @@
 /* { dg-do compile } */
-/* { dg-options "-O2 -fdump-tree-dce3" } */
-#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+/* { dg-options "-O2 -fdump-tree-dce3 -Wno-psabi" } */
 
 #include <limits.h>
 
+#define vector __attribute__((vector_size(sizeof(unsigned)*2)))
+
 vector unsigned or1(vector unsigned x, vector unsigned y)
 {
   /* (x <= y) | (x == 0)  --> x <= y */

	Jakub


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-09-01 12:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-30 22:25 [PATCH] MATCH: extend min_value/max_value match to vectors Andrew Pinski
2023-08-31 12:16 ` Richard Biener
2023-09-01 12:26 ` [committed] testsuite: Fix up pr110915* tests on i686-linux [PR110915] Jakub Jelinek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).