From: Michael Meissner <meissner@linux.ibm.com>
To: Richard Biener <richard.guenther@gmail.com>
Cc: Michael Meissner <meissner@linux.ibm.com>,
gcc-patches@gcc.gnu.org,
Segher Boessenkool <segher@kernel.crashing.org>,
"Kewen.Lin" <linkw@linux.ibm.com>,
David Edelsohn <dje.gcc@gmail.com>,
Peter Bergner <bergner@linux.ibm.com>
Subject: Re: [PATCH 0/4] Add vector pair support to PowerPC attribute((vector_size(32)))
Date: Mon, 20 Nov 2023 03:56:36 -0500 [thread overview]
Message-ID: <ZVsfRFlfoRQL9XRc@cowardly-lion.the-meissners.org> (raw)
In-Reply-To: <CAFiYyc3BaGffObe2ieZXQZji_1qXTXzVOSR6dz6D87i+sZvK2w@mail.gmail.com>
On Mon, Nov 20, 2023 at 08:24:35AM +0100, Richard Biener wrote:
> I wouldn't expose the "fake" larger modes to the vectorizer but rather
> adjust m_suggested_unroll_factor (which you already do to some extent).
Thanks. I figure I first need to fix the shuffle byes issue first and get a
clean test run (with the flag enabled by default), before delving into the
vectorization issues.
But testing has shown that at least in the loop I was looking at, that using
vector pair instructions (either through the built-ins I had previously posted
or with these patches), that even if I turn off unrolling completely for the
vector pair case, it still is faster than unrolling the loop 4 times for using
vector types (or auto vectorization). Note, of course the margin is much
smaller in this case.
vector double: (a * b) + c, unroll 4 loop time: 0.55483
vector double: (a * b) + c, unroll default loop time: 0.55638
vector double: (a * b) + c, unroll 0 loop time: 0.55686
vector double: (a * b) + c, unroll 2 loop time: 0.55772
vector32, w/vector pair: (a * b) + c, unroll 4 loop time: 0.48257
vector32, w/vector pair: (a * b) + c, unroll 2 loop time: 0.50782
vector32, w/vector pair: (a * b) + c, unroll default loop time: 0.50864
vector32, w/vector pair: (a * b) + c, unroll 0 loop time: 0.52224
Of course being micro-benchmarks, it doesn't mean that this translates to the
behavior on actual code.
--
Michael Meissner, IBM
PO Box 98, Ayer, Massachusetts, USA, 01432
email: meissner@linux.ibm.com
next prev parent reply other threads:[~2023-11-20 8:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 4:18 Michael Meissner
2023-11-20 4:20 ` [PATCH 1/4] Add basic vector pair mode support Michael Meissner
2023-11-20 4:23 ` [PATCH 1/4] Add vector pair modes to PowerPC (patch attached) Michael Meissner
2023-11-20 4:23 ` [PATCH 2/4] Vector pair floating point support for PowerPC Michael Meissner
2023-11-20 4:26 ` [PATCH 3/4] Add integer vector pair mode support to PowerPC Michael Meissner
2023-11-20 4:26 ` [PATCH 4/4] Add vector pair tests " Michael Meissner
2023-11-20 7:24 ` [PATCH 0/4] Add vector pair support to PowerPC attribute((vector_size(32))) Richard Biener
2023-11-20 8:56 ` Michael Meissner [this message]
2023-11-20 9:08 ` Richard Biener
2023-11-24 9:41 ` Kewen.Lin
2023-11-28 4:26 ` Michael Meissner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVsfRFlfoRQL9XRc@cowardly-lion.the-meissners.org \
--to=meissner@linux.ibm.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@linux.ibm.com \
--cc=richard.guenther@gmail.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).