From: Szabolcs Nagy <szabolcs.nagy@arm.com>
To: Florian Weimer <fweimer@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] aarch64: Avoid -Wincompatible-pointer-types warning in Linux unwinder
Date: Wed, 29 Nov 2023 15:50:44 +0000 [thread overview]
Message-ID: <ZWdd1J7kKXYvZS1Z@arm.com> (raw)
In-Reply-To: <874jht5tsq.fsf@oldenburg.str.redhat.com>
The 11/10/2023 19:48, Florian Weimer wrote:
> * config/aarch64/linux-unwind.h
> (aarch64_fallback_frame_state): Add cast to the expected type
> in sc assignment.
>
> (Almost a v2, but the other issue was already fixed via in r14-4183.)
>
> ---
> libgcc/config/aarch64/linux-unwind.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/libgcc/config/aarch64/linux-unwind.h b/libgcc/config/aarch64/linux-unwind.h
> index 00eba866049..18b3df71e7b 100644
> --- a/libgcc/config/aarch64/linux-unwind.h
> +++ b/libgcc/config/aarch64/linux-unwind.h
> @@ -77,7 +77,10 @@ aarch64_fallback_frame_state (struct _Unwind_Context *context,
> }
>
> rt_ = context->cfa;
> - sc = &rt_->uc.uc_mcontext;
> + /* Historically, the uc_mcontext member was of type struct sigcontext, but
> + glibc uses a different type now with member names in the implementation
> + namespace. */
> + sc = (struct sigcontext *) &rt_->uc.uc_mcontext;
FWIW this looks good to me.
(but i cannot approve patches)
(changing the type of sc to mcontext_t* is another option,
but then _GNU_SOURCE is required for the field names to
remain the same across glibc versions, while struct
sigcontext* is unlikely to cause API issues.)
>
> /* This define duplicates the definition in aarch64.md */
> #define SP_REGNUM 31
>
> base-commit: 3a6df3281a525ae6113f50d7b38b09fcd803801e
>
prev parent reply other threads:[~2023-11-29 15:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 18:48 Florian Weimer
2023-11-29 15:50 ` Szabolcs Nagy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWdd1J7kKXYvZS1Z@arm.com \
--to=szabolcs.nagy@arm.com \
--cc=fweimer@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).