public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] testsuite: Fix up gcc.target/s390/pr96127.c test for modern C [PR96127]
@ 2023-12-03 18:36 Jakub Jelinek
  2023-12-07  7:52 ` Andreas Krebbel
  0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2023-12-03 18:36 UTC (permalink / raw)
  To: Andreas Krebbel, Florian Weimer; +Cc: gcc-patches

Hi!

I've noticed this test regressed on s390x-linux with the addition of the
switch to modern C patchset.  Haven't tried to reproduce the ICE, but as it
was a backend ICE and FE after warning used to add such casts before (now
errors), I think this ought to keep the testcase testing what was intended
before.

Ok for trunk?

2023-12-03  Jakub Jelinek  <jakub@redhat.com>

	PR target/96127
	* gcc.target/s390/pr96127.c (c1): Add casts to long int *.

--- gcc/testsuite/gcc.target/s390/pr96127.c.jj	2020-07-28 15:39:10.058755540 +0200
+++ gcc/testsuite/gcc.target/s390/pr96127.c	2023-12-03 19:19:52.140110428 +0100
@@ -7,7 +7,7 @@ void
 c1 (int oz, int dk, int ub)
 {
   int *hd = 0;
-  long int *th = &dk;
+  long int *th = (long int *) &dk;
 
   while (ub < 1)
     {
@@ -17,7 +17,7 @@ c1 (int oz, int dk, int ub)
 
   while (oz < 2)
     {
-      long int *lq = &oz;
+      long int *lq = (long int *) &oz;
 
       (*hd < (*lq = *th)) < oz;
 

	Jakub


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] testsuite: Fix up gcc.target/s390/pr96127.c test for modern C [PR96127]
  2023-12-03 18:36 [PATCH] testsuite: Fix up gcc.target/s390/pr96127.c test for modern C [PR96127] Jakub Jelinek
@ 2023-12-07  7:52 ` Andreas Krebbel
  0 siblings, 0 replies; 2+ messages in thread
From: Andreas Krebbel @ 2023-12-07  7:52 UTC (permalink / raw)
  To: Jakub Jelinek, Florian Weimer; +Cc: gcc-patches

On 12/3/23 19:36, Jakub Jelinek wrote:
> Hi!
> 
> I've noticed this test regressed on s390x-linux with the addition of the
> switch to modern C patchset.  Haven't tried to reproduce the ICE, but as it
> was a backend ICE and FE after warning used to add such casts before (now
> errors), I think this ought to keep the testcase testing what was intended
> before.
> 
> Ok for trunk?

Ok, thanks!

Andreas


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-12-07  7:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-03 18:36 [PATCH] testsuite: Fix up gcc.target/s390/pr96127.c test for modern C [PR96127] Jakub Jelinek
2023-12-07  7:52 ` Andreas Krebbel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).