From: Jakub Jelinek <jakub@redhat.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, fortran <fortran@gcc.gnu.org>
Subject: Re: [patch] OpenMP/Fortran: Implement omp allocators/allocate for ptr/allocatables
Date: Fri, 8 Dec 2023 13:04:31 +0100 [thread overview]
Message-ID: <ZXMGT38/5ZS61+ZI@tucnak> (raw)
In-Reply-To: <60940754-edc6-4110-b7ba-5bed2133bbb6@codesourcery.com>
On Wed, Nov 08, 2023 at 05:58:10PM +0100, Tobias Burnus wrote:
> --- a/gcc/builtins.cc
> +++ b/gcc/builtins.cc
> @@ -11739,6 +11739,7 @@ builtin_fnspec (tree callee)
> return ".cO ";
> /* Realloc serves both as allocation point and deallocation point. */
> case BUILT_IN_REALLOC:
> + case BUILT_IN_GOMP_REALLOC:
> return ".Cw ";
I must say I've never been sure if one needs to specify those ". " for
integral arguments for which nothing is known; if they would need to be,
then also all the BUILT_IN_GOMP_* other cases would be wrong, but not just
those, also BUILT_IN_*_CHK (which have extra size_t argument) or
here BUILT_IN_REALLOC itself. So, let's hope it is ok as is.
Otherwise, the middle-end changes look just fine to me, and for Fortran
FE I'm afraid you know it much more than I do.
Jakub
next prev parent reply other threads:[~2023-12-08 12:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 16:58 Tobias Burnus
2023-12-08 12:04 ` Jakub Jelinek [this message]
2023-12-09 11:19 ` Thomas Schwinge
2023-12-09 15:14 ` Jakub Jelinek
2023-12-11 11:45 ` [Patch] OpenMP: Minor '!$omp allocators' cleanup - and still: " Tobias Burnus
2023-12-11 22:12 ` Thomas Schwinge
2023-12-11 23:45 ` Andrew MacLeod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXMGT38/5ZS61+ZI@tucnak \
--to=jakub@redhat.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).