Re: [PATCH 2/7] lto: Remove random_seed from section name.

[Jan Hubicka <hubicka@ucw.cz>]

> Bootstrapped/regtested on x86_64-pc-linux-gnu
> 
> gcc/ChangeLog:
> 
> 	* lto-streamer.cc (lto_get_section_name): Remove random_seed in WPA.

This is also OK. (since it lacks explanation - the random suffixes are
added for ld -r to work.  This never happens between WPA and ltrans, so
they only consume extra space and confuse the ltrans cache).
> ---
>  gcc/lto-streamer.cc | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/gcc/lto-streamer.cc b/gcc/lto-streamer.cc
> index 4968fd13413..53275e32618 100644
> --- a/gcc/lto-streamer.cc
> +++ b/gcc/lto-streamer.cc
> @@ -132,11 +132,17 @@ lto_get_section_name (int section_type, const char *name,
>       doesn't confuse the reader with merged sections.
>  
>       For options don't add a ID, the option reader cannot deal with them
> -     and merging should be ok here. */
> +     and merging should be ok here.
> +
> +     WPA output is sent to LTRANS directly inside of lto-wrapper, so name
> +     uniqueness for external tools is not needed.
> +     Randomness would inhibit incremental LTO.  */
>    if (section_type == LTO_section_opts)
>      strcpy (post, "");
>    else if (f != NULL) 
>      sprintf (post, "." HOST_WIDE_INT_PRINT_HEX_PURE, f->id);
> +  else if (flag_wpa)
> +    strcpy (post, ".0");
Con't post be just empty string?
>    else
>      sprintf (post, "." HOST_WIDE_INT_PRINT_HEX_PURE, get_random_seed (false)); 
>    char *res = concat (section_name_prefix, sep, add, post, NULL);
> -- 
> 2.42.1
>