* [PATCH] aarch64: Make ldp/stp pass off by default
@ 2024-01-10 14:45 Alex Coplan
2024-01-10 14:47 ` Richard Sandiford
0 siblings, 1 reply; 3+ messages in thread
From: Alex Coplan @ 2024-01-10 14:45 UTC (permalink / raw)
To: gcc-patches
Cc: Richard Earnshaw, Richard Sandiford, Kyrylo Tkachov, Jakub Jelinek
[-- Attachment #1: Type: text/plain, Size: 367 bytes --]
As discussed on IRC, this makes the aarch64 ldp/stp pass off by default. This
should stabilize the trunk and give some time to address the P1 regressions.
Sorry for the breakage.
Bootstrapped/regtested on aarch64-linux-gnu, OK for trunk?
Alex
gcc/ChangeLog:
* config/aarch64/aarch64.opt (-mearly-ldp-fusion): Set default
to 0.
(-mlate-ldp-fusion): Likewise.
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 814 bytes --]
diff --git a/gcc/config/aarch64/aarch64.opt b/gcc/config/aarch64/aarch64.opt
index ceed5cdb201..c495cb34fbf 100644
--- a/gcc/config/aarch64/aarch64.opt
+++ b/gcc/config/aarch64/aarch64.opt
@@ -290,12 +290,12 @@ Target Var(aarch64_track_speculation)
Generate code to track when the CPU might be speculating incorrectly.
mearly-ldp-fusion
-Target Var(flag_aarch64_early_ldp_fusion) Optimization Init(1)
+Target Var(flag_aarch64_early_ldp_fusion) Optimization Init(0)
Enable the copy of the AArch64 load/store pair fusion pass that runs before
register allocation.
mlate-ldp-fusion
-Target Var(flag_aarch64_late_ldp_fusion) Optimization Init(1)
+Target Var(flag_aarch64_late_ldp_fusion) Optimization Init(0)
Enable the copy of the AArch64 load/store pair fusion pass that runs after
register allocation.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] aarch64: Make ldp/stp pass off by default
2024-01-10 14:45 [PATCH] aarch64: Make ldp/stp pass off by default Alex Coplan
@ 2024-01-10 14:47 ` Richard Sandiford
2024-01-10 14:52 ` Jakub Jelinek
0 siblings, 1 reply; 3+ messages in thread
From: Richard Sandiford @ 2024-01-10 14:47 UTC (permalink / raw)
To: Alex Coplan; +Cc: gcc-patches, Richard Earnshaw, Kyrylo Tkachov, Jakub Jelinek
Alex Coplan <alex.coplan@arm.com> writes:
> As discussed on IRC, this makes the aarch64 ldp/stp pass off by default. This
> should stabilize the trunk and give some time to address the P1 regressions.
>
> Sorry for the breakage.
>
> Bootstrapped/regtested on aarch64-linux-gnu, OK for trunk?
>
> Alex
>
> gcc/ChangeLog:
>
> * config/aarch64/aarch64.opt (-mearly-ldp-fusion): Set default
> to 0.
> (-mlate-ldp-fusion): Likewise.
OK. Thanks for doing this, and for working through the PRs.
Richard
> diff --git a/gcc/config/aarch64/aarch64.opt b/gcc/config/aarch64/aarch64.opt
> index ceed5cdb201..c495cb34fbf 100644
> --- a/gcc/config/aarch64/aarch64.opt
> +++ b/gcc/config/aarch64/aarch64.opt
> @@ -290,12 +290,12 @@ Target Var(aarch64_track_speculation)
> Generate code to track when the CPU might be speculating incorrectly.
>
> mearly-ldp-fusion
> -Target Var(flag_aarch64_early_ldp_fusion) Optimization Init(1)
> +Target Var(flag_aarch64_early_ldp_fusion) Optimization Init(0)
> Enable the copy of the AArch64 load/store pair fusion pass that runs before
> register allocation.
>
> mlate-ldp-fusion
> -Target Var(flag_aarch64_late_ldp_fusion) Optimization Init(1)
> +Target Var(flag_aarch64_late_ldp_fusion) Optimization Init(0)
> Enable the copy of the AArch64 load/store pair fusion pass that runs after
> register allocation.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] aarch64: Make ldp/stp pass off by default
2024-01-10 14:47 ` Richard Sandiford
@ 2024-01-10 14:52 ` Jakub Jelinek
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Jelinek @ 2024-01-10 14:52 UTC (permalink / raw)
To: Alex Coplan, gcc-patches, Richard Earnshaw, Kyrylo Tkachov,
richard.sandiford
On Wed, Jan 10, 2024 at 02:47:29PM +0000, Richard Sandiford wrote:
> Alex Coplan <alex.coplan@arm.com> writes:
> > As discussed on IRC, this makes the aarch64 ldp/stp pass off by default. This
> > should stabilize the trunk and give some time to address the P1 regressions.
> >
> > Sorry for the breakage.
> >
> > Bootstrapped/regtested on aarch64-linux-gnu, OK for trunk?
> >
> > Alex
> >
> > gcc/ChangeLog:
> >
> > * config/aarch64/aarch64.opt (-mearly-ldp-fusion): Set default
> > to 0.
> > (-mlate-ldp-fusion): Likewise.
>
> OK. Thanks for doing this, and for working through the PRs.
Thanks. I'll repeat what I said on IRC, it is ok to reenable it say within
2-3 weeks if the fusion related P1s are addressed by then (or even earlier
if it is addressed then).
Jakub
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-10 14:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-10 14:45 [PATCH] aarch64: Make ldp/stp pass off by default Alex Coplan
2024-01-10 14:47 ` Richard Sandiford
2024-01-10 14:52 ` Jakub Jelinek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).