public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Andreas Krebbel <krebbel@linux.ibm.com>
Cc: Ilya Leoshkevich <iii@linux.ibm.com>,
	Andreas Krebbel <krebbel@gcc.gnu.org>,
	gcc-patches@gcc.gnu.org,
	Stefan Schulze Frielinghaus <stefansf@linux.ibm.com>,
	Juergen Christ <jchrist@linux.ibm.com>
Subject: Re: [PATCH] libsanitizer: Do not mention MSan and DFSan in an error message
Date: Thu, 4 Apr 2024 14:22:54 +0200	[thread overview]
Message-ID: <Zg6bnmPU/UU39XNy@tucnak> (raw)
In-Reply-To: <c3e09e90-558b-4fa6-891b-79bb76c6cc48@linux.ibm.com>

On Thu, Apr 04, 2024 at 02:19:08PM +0200, Andreas Krebbel wrote:
> On 4/4/24 13:38, Ilya Leoshkevich wrote:
> > Bootstrapped and regtested on s390x-redhat-linux.  Ok for master?
> > 
> > 
> > libsanitizer/ChangeLog:
> > 
> > 	* sanitizer_common/sanitizer_linux_s390.cpp (AvoidCVE_2016_2143):
> > 	Do not mention MSan and DFSan, which are not supported by GCC.
> 
> Ok, Thanks!

This then needs to be added to libsanitizer/LOCAL_PATCHES , otherwise
it will disappear on the next merge from upstream.

Though, I must say I'm not entirely convinced the change is worth the
hassle on every libsanitizer merge.

> > diff --git a/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp b/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp
> > index 74db831b0aa..65ba825fa97 100644
> > --- a/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp
> > +++ b/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp
> > @@ -212,7 +212,7 @@ void AvoidCVE_2016_2143() {
> >      return;
> >    Report(
> >      "ERROR: Your kernel seems to be vulnerable to CVE-2016-2143.  Using ASan,\n"
> > -    "MSan, TSan, DFSan or LSan with such kernel can and will crash your\n"
> > +    "TSan or LSan with such kernel can and will crash your\n"
> >      "machine, or worse.\n"
> >      "\n"
> >      "If you are certain your kernel is not vulnerable (you have compiled it\n"

	Jakub


  reply	other threads:[~2024-04-04 12:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-04 11:38 Ilya Leoshkevich
2024-04-04 12:19 ` Andreas Krebbel
2024-04-04 12:22   ` Jakub Jelinek [this message]
2024-04-04 13:24     ` Andreas Krebbel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zg6bnmPU/UU39XNy@tucnak \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=iii@linux.ibm.com \
    --cc=jchrist@linux.ibm.com \
    --cc=krebbel@gcc.gnu.org \
    --cc=krebbel@linux.ibm.com \
    --cc=stefansf@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).