public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Thomas Schwinge <tschwinge@baylibre.com>
Cc: gcc-patches@gcc.gnu.org, Richard Biener <rguenther@suse.de>,
	Jeff Law <jeffreyalaw@gmail.com>,
	Eric Botcazou <botcazou@adacore.com>,
	Tom de Vries <tdevries@suse.de>
Subject: Re: [PATCH] rtlanal: Fix set_noop_p for volatile loads or stores [PR114768]
Date: Fri, 19 Apr 2024 12:30:25 +0200	[thread overview]
Message-ID: <ZiJHwYOa7QekdT6q@tucnak> (raw)
In-Reply-To: <87wmot3b3s.fsf@euler.schwinge.ddns.net>

On Fri, Apr 19, 2024 at 12:23:03PM +0200, Thomas Schwinge wrote:
> On 2024-04-19T08:24:03+0200, Jakub Jelinek <jakub@redhat.com> wrote:
> > --- gcc/testsuite/gcc.dg/pr114768.c.jj	2024-04-18 15:37:49.139433678 +0200
> > +++ gcc/testsuite/gcc.dg/pr114768.c	2024-04-18 15:43:30.389730365 +0200
> > @@ -0,0 +1,10 @@
> > +/* PR rtl-optimization/114768 */
> > +/* { dg-do compile } */
> > +/* { dg-options "-O2 -fdump-rtl-final" } */
> > +/* { dg-final { scan-rtl-dump "\\\(mem/v:" "final" { target { ! { nvptx*-*-* } } } } } */
> > +
> > +void
> > +foo (int *p)
> > +{
> > +  *p = *(volatile int *) p;
> > +}
> 
> Why exclude nvptx target here?  As far as I can see, it does behave in
> the exactly same way as expected; see 'diff' of before vs. after the
> 'gcc/rtlanal.cc' code changes:

I wasn't sure if the non-RA targets (for which we don't have an effective
target) even have final dump.
If they do as you show, then guess the target guard can go.

	Jakub


  reply	other threads:[~2024-04-19 10:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-19  6:24 Jakub Jelinek
2024-04-19  6:33 ` Richard Biener
2024-04-19 10:23 ` Thomas Schwinge
2024-04-19 10:30   ` Jakub Jelinek [this message]
2024-04-19 10:39     ` Enable 'gcc.dg/pr114768.c' for nvptx target [PR114768] (was: [PATCH] rtlanal: Fix set_noop_p for volatile loads or stores [PR114768]) Thomas Schwinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZiJHwYOa7QekdT6q@tucnak \
    --to=jakub@redhat.com \
    --cc=botcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jeffreyalaw@gmail.com \
    --cc=rguenther@suse.de \
    --cc=tdevries@suse.de \
    --cc=tschwinge@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).