public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Alex Coplan <alex.coplan@arm.com>
To: Marek Polacek <polacek@redhat.com>
Cc: gcc-patches@gcc.gnu.org, Jason Merrill <jason@redhat.com>,
	Joseph Myers <josmyers@redhat.com>,
	Iain Sandoe <iain@sandoe.co.uk>
Subject: Re: [PATCH] wwwdocs: Add note to changes.html for __has_{feature,extension}
Date: Fri, 26 Apr 2024 11:12:54 +0100	[thread overview]
Message-ID: <Zit+Jv+7ypV2GJ8F@arm.com> (raw)
In-Reply-To: <Zh_twGAVLPs_1eaD@redhat.com>

On 17/04/2024 11:41, Marek Polacek wrote:
> On Mon, Apr 15, 2024 at 11:13:27AM +0100, Alex Coplan wrote:
> > On 04/04/2024 11:00, Alex Coplan wrote:
> > > Hi,
> > > 
> > > This adds a note to the GCC 14 release notes mentioning support for
> > > __has_{feature,extension} (PR60512).
> > > 
> > > OK to commit?
> > 
> > Ping.  Is this changes.html patch OK?  I guess it needs a review from C++
> > maintainers since it adds to the C++ section.
> > 
> > > 
> > > Thanks,
> > > Alex
> > 
> > > diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
> > > index 9fd224c1..facead8d 100644
> > > --- a/htdocs/gcc-14/changes.html
> > > +++ b/htdocs/gcc-14/changes.html
> > > @@ -242,6 +242,12 @@ a work-in-progress.</p>
> > >        <code>constinit</code> and optimized dynamic initialization</li>
> > >      </ul>
> > >    </li>
> > > +  <li>The Clang language extensions <code>__has_feature</code> and
> > > +    <code>__has_extension</code> have been implemented in GCC.  These
> > > +    are available from C, C++, and Objective-C(++).
> 
> Since the extension is for the whole c-family, not just C++, I think it
> belongs to a "C family" section.  See e.g. <https://gcc.gnu.org/gcc-13/changes.html>.

Thanks, I agree that makes more sense.  How about this version instead then:

diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
index fce0fb44..42353955 100644
--- a/htdocs/gcc-14/changes.html
+++ b/htdocs/gcc-14/changes.html
@@ -303,7 +303,15 @@ a work-in-progress.</p>
   <li>Further clean up and improvements to the GNAT code.</li>
 </ul>
 
-<!-- <h3 id="c-family">C family</h3> -->
+<h3 id="c-family">C family</h3>
+<ul>
+  <li>The Clang language extensions <code>__has_feature</code> and
+    <code>__has_extension</code> have been implemented in GCC.  These
+    are available from C, C++, and Objective-C(++).
+    This is primarily intended to aid the portability of code written
+    against Clang.
+  </li>
+</ul>
 
 <h4 id="c">C</h3>
 
Alex

> 
> Marek
> 

  reply	other threads:[~2024-04-26 10:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-04 10:00 Alex Coplan
2024-04-15 10:13 ` Alex Coplan
2024-04-15 20:22   ` Eric Gallager
2024-04-17 15:41   ` Marek Polacek
2024-04-26 10:12     ` Alex Coplan [this message]
2024-04-26 13:14       ` Marek Polacek
2024-04-26 13:31         ` Alex Coplan
2024-05-01 11:27         ` Gerald Pfeifer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zit+Jv+7ypV2GJ8F@arm.com \
    --to=alex.coplan@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=iain@sandoe.co.uk \
    --cc=jason@redhat.com \
    --cc=josmyers@redhat.com \
    --cc=polacek@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).