Re: [PATCH] wwwdocs: Add note to changes.html for __has_{feature,extension}

[Marek Polacek <polacek@redhat.com>]

On Fri, Apr 26, 2024 at 11:12:54AM +0100, Alex Coplan wrote:
> On 17/04/2024 11:41, Marek Polacek wrote:
> > On Mon, Apr 15, 2024 at 11:13:27AM +0100, Alex Coplan wrote:
> > > On 04/04/2024 11:00, Alex Coplan wrote:
> > > > Hi,
> > > > 
> > > > This adds a note to the GCC 14 release notes mentioning support for
> > > > __has_{feature,extension} (PR60512).
> > > > 
> > > > OK to commit?
> > > 
> > > Ping.  Is this changes.html patch OK?  I guess it needs a review from C++
> > > maintainers since it adds to the C++ section.
> > > 
> > > > 
> > > > Thanks,
> > > > Alex
> > > 
> > > > diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
> > > > index 9fd224c1..facead8d 100644
> > > > --- a/htdocs/gcc-14/changes.html
> > > > +++ b/htdocs/gcc-14/changes.html
> > > > @@ -242,6 +242,12 @@ a work-in-progress.</p>
> > > >        <code>constinit</code> and optimized dynamic initialization</li>
> > > >      </ul>
> > > >    </li>
> > > > +  <li>The Clang language extensions <code>__has_feature</code> and
> > > > +    <code>__has_extension</code> have been implemented in GCC.  These
> > > > +    are available from C, C++, and Objective-C(++).
> > 
> > Since the extension is for the whole c-family, not just C++, I think it
> > belongs to a "C family" section.  See e.g. <https://gcc.gnu.org/gcc-13/changes.html>.
> 
> Thanks, I agree that makes more sense.  How about this version instead then:

Thanks, I think you can go ahead with this.
 
> diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
> index fce0fb44..42353955 100644
> --- a/htdocs/gcc-14/changes.html
> +++ b/htdocs/gcc-14/changes.html
> @@ -303,7 +303,15 @@ a work-in-progress.</p>
>    <li>Further clean up and improvements to the GNAT code.</li>
>  </ul>
>  
> -<!-- <h3 id="c-family">C family</h3> -->
> +<h3 id="c-family">C family</h3>
> +<ul>
> +  <li>The Clang language extensions <code>__has_feature</code> and
> +    <code>__has_extension</code> have been implemented in GCC.  These
> +    are available from C, C++, and Objective-C(++).
> +    This is primarily intended to aid the portability of code written
> +    against Clang.
> +  </li>
> +</ul>
>  
>  <h4 id="c">C</h3>

Marek