From: Dimitar Dimitrov <dimitar@dinux.eu>
To: 陈硕 <shuo.chen@rivai.ai>
Cc: 丁乐华 <lehua.ding@rivai.ai>, gcc-patches <gcc-patches@gcc.gnu.org>,
钟居哲 <juzhe.zhong@rivai.ai>, 夏晋 <jin.xia@rivai.ai>,
vmakarov <vmakarov@redhat.com>,
"richard.sandiford" <richard.sandiford@arm.com>
Subject: Re: [PATCH 2/4] df: Add DF_LIVE_SUBREG problem
Date: Wed, 8 May 2024 18:57:24 +0300 [thread overview]
Message-ID: <Zjug5DBqNcn0Crr7@kendros.lan> (raw)
In-Reply-To: <tencent_0F02D17C7DDF14454B388CA6@qq.com>
On Wed, May 08, 2024 at 11:34:48AM +0800, 陈硕 wrote:
> Hi Dimitar
>
>
> I send a patch just now, modifies accordingly
>
>
> some comments:
>
>
> >Nit: Should have two spaces after the dot, per GNU coding style. I'd suggest
> >to run the contrib/check_GNU_style.py script on your patches.
> Do you mean "star" by "dot", i.e. "/*----" should be "/* ----"?
No, I was referring to the following paragraph from
https://www.gnu.org/prep/standards/standards.html :
"Please put two spaces after the end of a sentence in your comments, ..."
To fix, simply add a second space after the dot, e.g.:
- Like DF_LR, but include tracking subreg liveness. Currently used to provide
+ Like DF_LR, but include tracking subreg liveness. Currently used to provide
For reference, here is the output from the style checker:
$ git show | ./contrib/check_GNU_style.py -
=== ERROR type #4: dot, space, space, new sentence (24 error(s)) ===
...
gcc/df-problems.cc:1350:52: Like DF_LR, but include tracking subreg liveness.█Currently used to provide
>
>
> >These names seem a bit too short for global variables. Perhaps tuck
> >them in a namespace?
> >
> >Also, since these must remain empty, shouldn't they be declared as const?
> >
> >namespace df {
> > const bitmap_head empty_bitmap;
> > const subregs_live empty_live;
> >}
>
>
>
> May be better if "namespace df" contains all DF related code? as a minor modification, I add a prefix "df_" to the variables.
> Meanwhile, const seems inapropriate here, since it's returned as normal pointer rather than const pointer in some funtions,
>
> change to const would break this return value type check, and a const_cast would make the const meanlingless.
>
>
> more details see in the patch
Thanks for considering my suggestion.
Regards,
Dimitar
>
>
> regards
> Shuo
>
>
>
next prev parent reply other threads:[~2024-05-08 15:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 10:05 [PATCH V2 0/4] Add DF_LIVE_SUBREG data and apply to IRA and LRA Lehua Ding
2024-04-24 10:05 ` [PATCH 1/4] df: Add -ftrack-subreg-liveness option Lehua Ding
2024-04-24 10:05 ` [PATCH 2/4] df: Add DF_LIVE_SUBREG problem Lehua Ding
2024-04-25 20:56 ` Dimitar Dimitrov
2024-05-08 2:46 ` Lehua Ding
2024-05-08 3:34 ` 陈硕
2024-05-08 15:57 ` Dimitar Dimitrov [this message]
2024-05-08 22:54 ` 钟居哲
2024-04-24 10:05 ` [PATCH 3/4] ira: Apply DF_LIVE_SUBREG data Lehua Ding
2024-04-24 10:05 ` [PATCH 4/4] lra: " Lehua Ding
-- strict thread matches above, loose matches on Subject: below --
2024-02-03 10:50 [PATCH 0/4] Add DF_LIVE_SUBREG data and apply to IRA and LRA Lehua Ding
2024-02-03 10:50 ` [PATCH 2/4] df: Add DF_LIVE_SUBREG problem Lehua Ding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zjug5DBqNcn0Crr7@kendros.lan \
--to=dimitar@dinux.eu \
--cc=gcc-patches@gcc.gnu.org \
--cc=jin.xia@rivai.ai \
--cc=juzhe.zhong@rivai.ai \
--cc=lehua.ding@rivai.ai \
--cc=richard.sandiford@arm.com \
--cc=shuo.chen@rivai.ai \
--cc=vmakarov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).