From: David Malcolm <dmalcolm@redhat.com>
To: Lewis Hyatt <lhyatt@gmail.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libcpp: Improve the diagnostic for poisoned identifiers [PR36887]
Date: Mon, 23 Oct 2023 10:15:05 -0400 [thread overview]
Message-ID: <a1709523490b0e4494e38670db3828a846d571c7.camel@redhat.com> (raw)
In-Reply-To: <20230920041202.4099349-1-lhyatt@gmail.com>
On Wed, 2023-09-20 at 00:12 -0400, Lewis Hyatt wrote:
> Hello-
>
> This patch implements the PR's request to add more information to the
> diagnostic issued for using a poisoned identifier. Bootstrapped +
> regtested
> all languages on x86-64 Linux. Does it look OK please? Thanks!
Thanks!
Patch looks good to me; please go ahead and push it.
Dave
next prev parent reply other threads:[~2023-10-23 14:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 4:12 Lewis Hyatt
2023-10-23 14:15 ` David Malcolm [this message]
2023-10-26 8:49 ` Christophe Lyon
2023-10-26 16:18 ` Lewis Hyatt
2023-10-26 16:48 ` Christophe Lyon
2023-10-26 17:43 ` Lewis Hyatt
2023-10-26 18:29 ` Christophe Lyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1709523490b0e4494e38670db3828a846d571c7.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=lhyatt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).