Re: Adding a new thread model to GCC

[LIU Hao <lh_mouse@126.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2132 bytes --]

在 2022-10-04 21:13, Xi Ruoyao 写道:
> 
> In GCC development we usually include the configure regeneration in the
> patch because the scripts are also version controlled.
> 

There is a reason for not doing that: Generated contents can't be reviewed.

In mingw-w64 we do the opposite: The person who commits a patch is responsible for update configure, 
Makefile.in, etc. The patch itself doesn't include generated contents.


> It's better to include the ID in the subject and ChangeLog of the patch.
> Like:
> 
>     [PATCH 1/3] libgfortran: Use `__gthread_t` instead of `pthread_t` [PR 105764]
>     
>     It used to cause errors if a thread model other than `posix` was selected,
>     which looks like a leftover from a79878585a1c5e32bafbc6d1e73f91fd6e4293bf.
>     
>     libgfortran/ChangeLog:
>     
>     	PR libgfortran/105764
>     	* io/async.h (struct async_unit): Use `__gthread_t` instead
>     	of `pthread_t`.
> 

Yes I think this change is good.


> 
> And, from https://gcc.gnu.org/contribute.html#patches:
> 
> "It is strongly discouraged to post patches as MIME parts of type
> application/whatever, disposition attachment or encoded as base64 or
> quoted-printable."
> 
> Just try "git send-email", it will do the correct thing.  Mimicking its
> behavior in a mail client is also possible but error-prune (the mail
> client can destroy your patch by replacing your tabs with spaces, etc.)
> 

It's 'discouraged'. It is not forbidden. I expect everywhere people who receive emails to accept 
attachments. Thunderbird has a nice feature to display text attachments inline, so there is no need 
to download it and open it with an external editor, or whatever.


And, I never get `git send-mail` work on my machine:

    ```
    Send this email? ([y]es|[n]o|[e]dit|[q]uit|[a]ll): y
    Unable to initialize SMTP properly. Check config and use --smtp-debug. VA
    LUES: server=smtp.126.com encryption=tls hello=localhost.localdomain port
    =465 at /usr/lib/git-core/git-send-email line 1684, <FIN> line 3.
    ```




-- 
Best regards,
LIU Hao


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]