From: Xi Ruoyao <xry111@xry111.site>
To: LIU Hao <lh_mouse@126.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Adding a new thread model to GCC
Date: Wed, 05 Oct 2022 09:23:55 +0800 [thread overview]
Message-ID: <5821cc8835d5db2f185df37c5c31865015e6d350.camel@xry111.site> (raw)
In-Reply-To: <a23ad853-2cc7-63af-99e6-362ade66fcd8@126.com>
On Tue, 2022-10-04 at 21:45 +0800, LIU Hao wrote:
> 在 2022-10-04 21:13, Xi Ruoyao 写道:
> >
> > In GCC development we usually include the configure regeneration in the
> > patch because the scripts are also version controlled.
> >
>
> There is a reason for not doing that: Generated contents can't be reviewed.
>
> In mingw-w64 we do the opposite: The person who commits a patch is responsible for update configure,
> Makefile.in, etc. The patch itself doesn't include generated contents.
The reviewer can simply skip the changes in configure. But including
the configure allows the potential testers to test the change without
autoconf-2.69 installed.
Maybe we can make a compromise: put the line "configure: Regenerate." in
the ChangeLog, but do not actually include the change. Now if the
committer forgot to regenerate it, the git hook will reject the push
immediately.
(Just my 2 cents.)
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2022-10-05 1:24 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 18:34 LIU Hao
2022-10-01 20:02 ` Bernhard Reutner-Fischer
2022-10-02 12:54 ` LIU Hao
2022-10-03 5:03 ` Bernhard Reutner-Fischer
2022-10-04 8:06 ` LIU Hao
2022-10-04 19:45 ` Bernhard Reutner-Fischer
2022-10-04 12:44 ` LIU Hao
2022-10-04 13:13 ` Xi Ruoyao
2022-10-04 13:45 ` LIU Hao
2022-10-05 1:23 ` Xi Ruoyao [this message]
2022-10-10 15:56 ` LIU Hao
2022-10-11 13:22 ` LIU Hao
2022-10-14 9:39 ` Jonathan Yong
2022-10-19 13:55 ` Jonathan Yong
2022-10-19 19:53 ` Bernhard Reutner-Fischer
2022-10-20 1:25 ` LIU Hao
2022-10-21 9:58 ` Jonathan Wakely
2022-10-21 10:09 ` i.nixman
2022-10-21 10:48 ` Jonathan Wakely
2022-10-21 10:55 ` i.nixman
2022-10-21 11:36 ` LIU Hao
2022-10-21 11:54 ` i.nixman
2022-10-21 12:19 ` LIU Hao
2022-10-21 12:34 ` i.nixman
2022-10-24 3:40 ` LIU Hao
2022-10-24 20:50 ` Jacek Caban
2022-10-21 12:13 ` Jacek Caban
2022-10-21 12:29 ` LIU Hao
2022-10-21 12:40 ` Jacek Caban
2022-10-21 11:44 ` Eric Botcazou
2022-10-21 11:55 ` i.nixman
2022-10-21 12:30 ` Jacek Caban
2022-10-23 0:36 ` NightStrike
2022-10-24 6:53 ` i.nixman
2022-10-24 8:15 ` Eric Botcazou
2022-10-24 8:20 ` i.nixman
2022-10-31 9:18 ` Eric Botcazou
2022-10-31 15:22 ` i.nixman
2022-12-18 11:14 ` Jonathan Yong
2022-11-01 5:22 ` i.nixman
2022-11-01 9:09 ` Eric Botcazou
2022-11-02 12:05 ` i.nixman
2022-11-02 21:27 ` Eric Botcazou
2022-11-02 21:40 ` i.nixman
2022-12-16 17:18 ` Jonathan Wakely
2022-12-16 19:20 ` Eric Botcazou
2022-12-22 12:21 ` Jonathan Yong
2022-12-22 12:28 ` i.nixman
2022-12-23 23:59 ` Jonathan Yong
2022-12-24 5:58 ` NightStrike
2022-12-24 6:27 ` i.nixman
2022-12-24 13:50 ` i.nixman
2022-12-24 15:42 ` i.nixman
2022-12-24 15:57 ` i.nixman
2022-12-24 21:22 ` i.nixman
2022-12-25 1:10 ` Jonathan Yong
2023-01-09 21:56 ` Eric Botcazou
2022-12-24 6:22 ` i.nixman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5821cc8835d5db2f185df37c5c31865015e6d350.camel@xry111.site \
--to=xry111@xry111.site \
--cc=gcc-patches@gcc.gnu.org \
--cc=lh_mouse@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).