From: Jason Merrill <jason@redhat.com>
To: Patrick Palka <ppalka@redhat.com>,
Nathaniel Shead <nathanieloshead@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] c++: Check if allocation functions are xobj members [PR114078]
Date: Mon, 22 Apr 2024 23:15:31 -0400 [thread overview]
Message-ID: <a4fcd148-00ad-4065-b25a-55b624810823@redhat.com> (raw)
In-Reply-To: <7557fd6d-964a-ce4e-3051-62c070fe5be6@idea>
On 4/21/24 19:59, Patrick Palka wrote:
> On Sat, 20 Apr 2024, Nathaniel Shead wrote:
>
>> Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk?
>>
>> -- >8 --
>>
>> A class allocation member function is implicitly 'static' by
>> [class.free] p3, so cannot have an explicit object parameter.
>>
>> PR c++/114078
>>
>> gcc/cp/ChangeLog:
>>
>> * decl.cc (grokdeclarator): Check allocation functions for xobj
>> parameters.
>>
>> gcc/testsuite/ChangeLog:
>>
>> * g++.dg/cpp23/explicit-obj-ops-alloc.C: New test.
>
> LGTM
Agreed, OK.
prev parent reply other threads:[~2024-04-23 3:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-20 8:39 Nathaniel Shead
2024-04-22 2:59 ` Patrick Palka
2024-04-23 3:15 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4fcd148-00ad-4065-b25a-55b624810823@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nathanieloshead@gmail.com \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).