From: Christophe Lyon <christophe.lyon@arm.com>
To: "Torbjörn SVENSSON" <torbjorn.svensson@foss.st.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] arm: Allow to override location of .gnu.sgstubs section
Date: Wed, 19 Oct 2022 11:52:08 +0200 [thread overview]
Message-ID: <a6aff33a-6f79-a48e-11ba-48969d71548f@arm.com> (raw)
In-Reply-To: <20221019094214.1734353-1-torbjorn.svensson@foss.st.com>
Hi Torbjörn,
This looks like a nice improvement to me ;-)
On 10/19/22 11:42, Torbjörn SVENSSON via Gcc-patches wrote:
> Depending on the DejaGNU board definition, the .gnu.sgstubs section
> might be placed on different locations in order to suite the target.
typo: suite -> suit
> With this patch, the start location of the section is overrideable
> from the board definition with the fallback of the previously
> hardcoded location.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/arm/cmse/bitfield-1.c: Use overridable location.
> * gcc.target/arm/cmse/bitfield-2.c: Likewise.
> * gcc.target/arm/cmse/bitfield-3.c: Likewise.
> * gcc.target/arm/cmse/cmse-20.c: Likewise.
> * gcc.target/arm/cmse/struct-1.c: Likewise.
> * gcc.target/arm/cmse/cmse.exp (cmse_sgstubs): New.
>
> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
> ---
> gcc/testsuite/gcc.target/arm/cmse/bitfield-1.c | 2 +-
> gcc/testsuite/gcc.target/arm/cmse/bitfield-2.c | 2 +-
> gcc/testsuite/gcc.target/arm/cmse/bitfield-3.c | 2 +-
> gcc/testsuite/gcc.target/arm/cmse/cmse-20.c | 2 +-
> gcc/testsuite/gcc.target/arm/cmse/cmse.exp | 11 +++++++++++
> gcc/testsuite/gcc.target/arm/cmse/struct-1.c | 2 +-
> 6 files changed, 16 insertions(+), 5 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/arm/cmse/bitfield-1.c b/gcc/testsuite/gcc.target/arm/cmse/bitfield-1.c
> index 5685f744435..c1221bef29f 100644
> --- a/gcc/testsuite/gcc.target/arm/cmse/bitfield-1.c
> +++ b/gcc/testsuite/gcc.target/arm/cmse/bitfield-1.c
> @@ -1,5 +1,5 @@
> /* This test is executed only if the execution engine supports CMSE instructions. */
> -/* { dg-options "--save-temps -mcmse -Wl,--section-start,.gnu.sgstubs=0x00400000" } */
> +/* { dg-options "--save-temps -mcmse -Wl,--section-start,.gnu.sgstubs=[cmse_sgstubs]" } */
>
> typedef struct
> {
> diff --git a/gcc/testsuite/gcc.target/arm/cmse/bitfield-2.c b/gcc/testsuite/gcc.target/arm/cmse/bitfield-2.c
> index 7a794d44644..79e9a3efc93 100644
> --- a/gcc/testsuite/gcc.target/arm/cmse/bitfield-2.c
> +++ b/gcc/testsuite/gcc.target/arm/cmse/bitfield-2.c
> @@ -1,5 +1,5 @@
> /* This test is executed only if the execution engine supports CMSE instructions. */
> -/* { dg-options "--save-temps -mcmse -Wl,--section-start,.gnu.sgstubs=0x00400000" } */
> +/* { dg-options "--save-temps -mcmse -Wl,--section-start,.gnu.sgstubs=[cmse_sgstubs]" } */
>
> typedef struct
> {
> diff --git a/gcc/testsuite/gcc.target/arm/cmse/bitfield-3.c b/gcc/testsuite/gcc.target/arm/cmse/bitfield-3.c
> index 5875f8dff48..d621a802ee1 100644
> --- a/gcc/testsuite/gcc.target/arm/cmse/bitfield-3.c
> +++ b/gcc/testsuite/gcc.target/arm/cmse/bitfield-3.c
> @@ -1,5 +1,5 @@
> /* This test is executed only if the execution engine supports CMSE instructions. */
> -/* { dg-options "--save-temps -mcmse -Wl,--section-start,.gnu.sgstubs=0x00400000" } */
> +/* { dg-options "--save-temps -mcmse -Wl,--section-start,.gnu.sgstubs=[cmse_sgstubs]" } */
>
> typedef struct
> {
> diff --git a/gcc/testsuite/gcc.target/arm/cmse/cmse-20.c b/gcc/testsuite/gcc.target/arm/cmse/cmse-20.c
> index 08e89bff637..bbea9358870 100644
> --- a/gcc/testsuite/gcc.target/arm/cmse/cmse-20.c
> +++ b/gcc/testsuite/gcc.target/arm/cmse/cmse-20.c
> @@ -1,5 +1,5 @@
> /* This test is executed only if the execution engine supports CMSE instructions. */
> -/* { dg-options "--save-temps -mcmse -Wl,--section-start,.gnu.sgstubs=0x00400000" } */
> +/* { dg-options "--save-temps -mcmse -Wl,--section-start,.gnu.sgstubs=[cmse_sgstubs]" } */
>
> #include <arm_cmse.h>
> #include <stdlib.h>
> diff --git a/gcc/testsuite/gcc.target/arm/cmse/cmse.exp b/gcc/testsuite/gcc.target/arm/cmse/cmse.exp
> index 436dd71ef89..1df5d56c6d5 100644
> --- a/gcc/testsuite/gcc.target/arm/cmse/cmse.exp
> +++ b/gcc/testsuite/gcc.target/arm/cmse/cmse.exp
> @@ -44,6 +44,17 @@ if {[is-effective-target arm_cmse_hw]} then {
> set saved-lto_torture_options ${LTO_TORTURE_OPTIONS}
> set LTO_TORTURE_OPTIONS ""
>
> +# Return the start address of the .gnu.sgstubs section.
> +proc cmse_sgstubs {} {
> + # Allow to override the location of .gnu.sgstubs section.
> + set tboard [target_info name]
> + if {[board_info $tboard exists cmse_sgstubs]} {
> + return [board_info $tboard cmse_sgstubs]
> + }
> +
> + return "0x00400000"
> +}
> +
I am not sure if/where this new cmse_sgstubs target-board property needs
to be documented?
Thanks,
Christophe
> # These are for both baseline and mainline.
> gcc-dg-runtest [lsort [glob $srcdir/$subdir/*.c]] \
> "" $DEFAULT_CFLAGS
> diff --git a/gcc/testsuite/gcc.target/arm/cmse/struct-1.c b/gcc/testsuite/gcc.target/arm/cmse/struct-1.c
> index 75a99f487e7..bebd059b13f 100644
> --- a/gcc/testsuite/gcc.target/arm/cmse/struct-1.c
> +++ b/gcc/testsuite/gcc.target/arm/cmse/struct-1.c
> @@ -1,5 +1,5 @@
> /* This test is executed only if the execution engine supports CMSE instructions. */
> -/* { dg-options "--save-temps -mcmse -Wl,--section-start,.gnu.sgstubs=0x00400000" } */
> +/* { dg-options "--save-temps -mcmse -Wl,--section-start,.gnu.sgstubs=[cmse_sgstubs]" } */
>
> typedef struct
> {
next prev parent reply other threads:[~2022-10-19 9:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 9:42 Torbjörn SVENSSON
2022-10-19 9:52 ` Christophe Lyon [this message]
2022-10-19 10:07 ` Torbjorn SVENSSON
2022-11-02 18:18 ` PING^1 " Torbjorn SVENSSON
2022-11-03 9:44 ` Kyrylo Tkachov
2022-11-04 7:59 ` Torbjorn SVENSSON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6aff33a-6f79-a48e-11ba-48969d71548f@arm.com \
--to=christophe.lyon@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=torbjorn.svensson@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).