public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* OpenMP patch ping
@ 2022-08-16 17:28 Tobias Burnus
  2022-09-06 15:01 ` Tobias Burnus
  0 siblings, 1 reply; 5+ messages in thread
From: Tobias Burnus @ 2022-08-16 17:28 UTC (permalink / raw)
  To: gcc-patches, Jakub Jelinek

I would like to ping the following OpenMP patches.

First two non-pings but just RFC:

- "Restore 'GOMP_offload_unregister_ver' functionality"
   https://gcc.gnu.org/pipermail/gcc-patches/2022-July/597918.html
   * QUESTION: See 'assert' question in email exchange
    (linked email message + emails before/after it in the thread)

- [Patch] OpenMP: Fix folding with simd's linear clause [PR106492]
   https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599308.html
   * Already committed as obvious to mainline + GCC 12
   * Question: Close PR or also backport to GCC 11? Other patch comments?


Now the patch pings – lightly ordered by complexity:

* [PATCH, OpenMP, C++] Allow classes with static members to be mappable
   https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598918.html
   * Modified as requested in the patch review

* [Patch] OpenMP: Fix var replacement with 'simd' and linear-step vars [PR106548]
   https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599832.html

* [Patch] Fortran: OpenMP fix declare simd inside modules and absent linear step [PR106566]
   https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599829.html

* [patch] libgomp/splay-tree.h: Fix splay_tree_prefix handling
   https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598694.html

* [Patch] OpenMP requires: Fix diagnostic filename corner case
   https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598697.html

* [PATCH] openmp: fix max_vf setting for amdgcn offloading
   https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598265.html

(Side note: we should at some point find a way to improve target-specific
handling; similar to the are-exceptions-supported issue of PR101544 but
there are more.)

* [PATCH] OpenMP, libgomp: Environment variable syntax extension.
   https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598770.html
   * Post-review Revised patch

* [Patch] OpenMP, libgomp, gimple: omp_get_max_teams, omp_set_num_teams, and omp_{gs}et_teams_thread_limit on offload devices
   https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599278.html
   * Revised patch; saw a light review before

* [Patch] OpenMP: Support reverse offload (middle end part)
   https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598662.html
(Does permanent host fallback for target regions; I have a WIP patch
for AMDGCN and nvptx)

* [PATCH 0/3] OpenMP SIMD routines
   https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599487.html

* [PATCH 0/5] [gfortran] Support for allocate directive (OpenMP 5.0)
   https://gcc.gnu.org/pipermail/gcc-patches/2022-January/588367.html
(already older - but I missed to ping it.)

* [PATCH 00/17] openmp, nvptx, amdgcn: 5.0 Memory Allocators
   https://gcc.gnu.org/pipermail/gcc-patches/2022-July/597976.html
   * Unified-Shared Memory & Pinned Memory

Depending on those:

* [PATCH] OpenMP, libgomp: Handle unified shared memory in omp_target_is_accessible.
   https://gcc.gnu.org/pipermail/gcc-patches/2022-May/594187.html

* [PATCH, OpenMP, Fortran] requires unified_shared_memory 1/2: adjust libgfortran memory allocators
   https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599703.html
   (Fortran part, required for ...)
* [PATCH, OpenMP, Fortran] requires unified_shared_memory 2/2: insert USM allocators into libgfortran
   https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599704.html

And finally:

* [PATCH, libgomp] Fix chunk_size<1 for dynamic schedule
   https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599332.html

Tobias

PS: I hope the list above and the one below is somewhat complete...

  * * *

PPS: Tracking patches pending (re)submissions, just that it is not
forgotten on our side:

* [PATCH, OpenMP, v4] Implement uses_allocators clause for target regions
   https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596587.html
   * Needs to be revised according to review comments

* Fortran allocatable components handling (needs to be slit into separate pieces and submitted
   separately)
   https://gcc.gnu.org/pipermail/gcc-patches/2022-April/593704.html

* [PATCH 00/16] OpenMP: lvalues in "map" clauses and struct handling rework
   https://gcc.gnu.org/pipermail/gcc-patches/2021-December/586600.html
   and January + February updates (search for metadirective)
+ patch review end of May, e.g.
   https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595762.html (+ 4 more emails)

* [PATCH 00/16] OpenMP: lvalues in "map" clauses and struct handling rework
   https://gcc.gnu.org/pipermail/gcc-patches/2021-November/585439.html
   + [PATCH v2 00/11] OpenMP 5.0: C & C++ "declare mapper" support (plus struct rework, etc.)
   https://gcc.gnu.org/pipermail/gcc-patches/2022-March/591973.html

* [PATCH 00/40] OpenACC "kernels" Improvements
   https://gcc.gnu.org/pipermail/gcc-patches/2021-December/586901.html
   (4 simple patches are in by now; could be reviewed, in principle)

-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

^ permalink raw reply	[flat|nested] 5+ messages in thread
* OpenMP Patch Ping
@ 2023-01-10 11:37 Tobias Burnus
  0 siblings, 0 replies; 5+ messages in thread
From: Tobias Burnus @ 2023-01-10 11:37 UTC (permalink / raw)
  To: Jakub Jelinek, gcc-patches

Hi all, hello Jakub,

Below is the updated list to last ping,
https://gcc.gnu.org/pipermail/gcc-patches/2022-November/607178.html

NOTE to the list below: I have stopped checking older patches. I know
some more are pending review, others need to be revised. I will re-check,
once the below listed patches have been reviewed. Cf. old list.

Thanks for the reviews done in between the last ping and now!

  * * *

Small patches
=============

* [Patch] Fortran: Extend align-clause checks of OpenMP's allocate clause
   https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608401.html
   Tue Dec 13 16:38:22 GMT 2022

* [Patch] OpenMP: Parse align clause in allocate directive in C/C++
   https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608404.html
   Tue Dec 13 17:44:27 GMT 2022

* Re: [Patch] libgomp.texi: Reverse-offload updates (was: [Patch] libgomp: Handle OpenMP's reverse offloads)
   https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608245.html
   Thu Nov 24 12:01:04 GMT 2022

(Side note: wwwdocs also needs to be updated for the latter patch and
some other patches done in the meanwhile.)


Fortran allocat(e,ors) prep patch
=================================

* [Patch] Fortran/OpenMP: Add parsing support for allocators/allocate directive (was: [Patch] Fortran/OpenMP: Add parsing support for allocators directive)
   https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608904.html
   Wed Dec 21 15:51:25 GMT 2022

(Remark: While written from scratch, it is kind of a follow-up to Abid's patch
    [PATCH 1/5] [gfortran] Add parsing support for allocate directive (OpenMP 5.0)
you/Jakub reviewed on Tue Oct 11 12:13:14 GMT 2022, i.e.
  https://gcc.gnu.org/pipermail/gcc-patches/2022-October/603258.html
- For the actual implementation of 'allocators', we still have to solve the issues
   raised in the review for '[PATCH 2/5] [gfortran] Translate allocate directive (OpenMP 5.0).'.
   at https://gcc.gnu.org/pipermail/gcc-patches/2022-October/603279.html (and earlier in the thread);
   implementing 'omp allocate' (Fortran/C/C++) seems to be easier but no one has started implementing
   it so far - only parsing support exists.
- The USM patches on semi-USM system run into a similar issue as 'allocators' and for it, some
   ME omp_allocate is added.)


Mapping related patches
=======================
(Complex but GCC needs a revision badly as it fixing several bugs and missing functionality.)

* Complete patch set was just re-submitted by Julian, overiew patch is
   [PATCH v6 00/11] OpenMP: C/C++ lvalue parsing, C/C++/Fortran "declare mapper" support
   https://gcc.gnu.org/pipermail/gcc-patches/2022-December/thread.html#609031
   Fri Dec 23 12:12:53 GMT 2022
* Note: For 10/11 of the set, there was a follow up this Monday
   [PATCH v6 10/11] OpenMP: Support OpenMP 5.0 "declare mapper" directives for C
   https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609566.html

[As it relates to one patch in the series:
   '[Patch] Fortran/OpenMP: Fix DT struct-component with 'alloc' and array descr'
That's mine, needs to be updated (WIP) and fixes array descriptor/alloc-string-length var
issues, where descriptor/string length may need to be handled explicitly on data entering map,
i.e. string lengths/allocator may require 'to:' instead of 'alloc:' - and on data exit mapping,
the current code might add a bogus 'alloc:'. - Idea is to handle this explicitly
in fortran/trans-openmp.cc instead of auto-adding it in the ME.
Status: WIP - removed in ME but not all cases are handled yet in FE.)


Fortran deep mapping (allocatable components)
====================
(Old patch of March 2022, but first part now properly but belated submitted - today):
[Patch][1/2] OpenMP: Add lang hooks + run-time filled map arrays for Fortran deep mapping of DT
https://gcc.gnu.org/pipermail/gcc-patches/2023-January/609637.html

Tobias

-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

^ permalink raw reply	[flat|nested] 5+ messages in thread
* OpenMP Patch Ping
@ 2022-11-24 12:01 Tobias Burnus
  0 siblings, 0 replies; 5+ messages in thread
From: Tobias Burnus @ 2022-11-24 12:01 UTC (permalink / raw)
  To: gcc-patches, Jakub Jelinek

Updated list as follow up to last ping at https://gcc.gnu.org/pipermail/gcc-patches/2022-September/601162.html


Recent patches:

Sandra's (Tue Nov 15 04:46:15 GMT 2022)
[PATCH v4] OpenMP: Generate SIMD clones for functions with "declare target"
https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606218.html


Julian's patches - I hope I got it right as I lost a bit track:

(Tue Nov 8 14:36:17 GMT 2022)
[PATCH v2 06/11] OpenMP: lvalue parsing for map clauses (C++)
https://gcc.gnu.org/pipermail/gcc-patches/2022-November/605367.html

(Fri Sep 30 13:30:22 GMT 2022)
[PATCH v3 06/11] OpenMP: Pointers and member mappings
https://gcc.gnu.org/pipermail/gcc-patches/2022-September/602609.html

(Tue Oct 18 10:39:01 GMT 2022)
[PATCH v5 0/4] OpenMP/OpenACC: Fortran array descriptor mappings
https://gcc.gnu.org/pipermail/gcc-patches/2022-October/thread.html#603790
(I think this is partially my task to review those.)


Approved but waiting for the Fortran patches (v5) to get approved.
[PATCH v3 08/11] OpenMP/OpenACC: Rework clause expansion and nested struct handling
https://gcc.gnu.org/pipermail/gcc-patches/2022-September/602010.html


Possibly requiring a second look/review despite my initial comment
(which might require revisions on the patch side as well):
OpenMP: Duplicate checking for map clauses in Fortran (PR107214)
https://gcc.gnu.org/pipermail/gcc-patches/2022-October/604033.html


Older patches:

* [PATCH 00/17] openmp, nvptx, amdgcn: 5.0 Memory Allocators
   https://gcc.gnu.org/pipermail/gcc-patches/2022-July/597976.html
   * Unified-Shared Memory & Pinned Memory

Depending on those:

* [PATCH] OpenMP, libgomp: Handle unified shared memory in omp_target_is_accessible.
   https://gcc.gnu.org/pipermail/gcc-patches/2022-May/594187.html

* [PATCH, OpenMP, Fortran] requires unified_shared_memory 1/2: adjust libgfortran memory allocators
   https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599703.html
   (Fortran part, required for ...)
* Re: [PATCH, OpenMP, Fortran] requires unified_shared_memory 2/2: insert USM allocators into libgfortran
   https://gcc.gnu.org/pipermail/gcc-patches/2022-September/601059.html

And finally:

* [PATCH, libgomp] Fix chunk_size<1 for dynamic schedule
   https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599332.html
(Side remark: some other debugging support like showing the mapping being done as stderr output or ... would be nice as well; might depend on a libgomp-debug.so and/or -f...(sanitize=openmp or ...); the other open-source compiler has something similar.)


  * * *


Pending libgomp/nvptx patches:

(Wed Sep 21 07:45:36 GMT 2022)
[PATCH, nvptx, 1/2] Reimplement libgomp barriers for nvptx
https://gcc.gnu.org/pipermail/gcc-patches/2022-September/601922.html

(Wed Sep 21 07:45:54 GMT 2022)
[PATCH, nvptx, 2/2] Reimplement libgomp barriers for nvptx: bar.red instruction support in GCC
https://gcc.gnu.org/pipermail/gcc-patches/2022-September/601925.html

Those were pinged 4 times :-(


Hopefully, I have not missed any patch

Tobias


PS: The following list covers pending patches, which have been reviewed but
but need to updated before being ready - hopefully, this list is also up to date:

* (No pending patch, but wwwdoc's changes-13.html + projects/gomp/ need an update before GCC 13)

* [Patch] OpenMP, libgomp, gimple: omp_get_max_teams, omp_set_num_teams, and
omp_{gs}et_teams_thread_limit on offload devices
Should be re-submitted any time soon (today, next few days)

* [Patch] OpenMP/Fortran: Permit end-clause on directive
   https://gcc.gnu.org/pipermail/gcc-patches/2022-August/600433.html
   Trivial patch modifications required - mostly LGTM already.

* [PATCH] libgomp: fix hang on fatal error
   https://gcc.gnu.org/pipermail/gcc-patches/2022-October/603616.html
(Patch rejected but alternative solutions were suggested.)

* Re: [Patch] OpenMP/Fortran: Use firstprivat not alloc for ptr attach for arrays
(Committed but failing occasionally:)
https://gcc.gnu.org/pipermail/gcc-patches/2022-November/605854.html

* "[PATCH 3/3] vect: inbranch SIMD clones"
   https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599490.html
   Review comments to be addressed.

* [PATCH 0/5] [gfortran] Support for allocate directive (OpenMP 5.0)
   https://gcc.gnu.org/pipermail/gcc-patches/2022-January/588367.html

* [PATCH] openmp: fix max_vf setting for amdgcn offloading
   https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598265.html
→ To be updated for review comments.
(Side note: we should at some point find a way to improve target-specific
handling; similar to the are-exceptions-supported issue of PR101544 but
there are more.)

* [PATCH, OpenMP, v4] Implement uses_allocators clause for target regions
   https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596587.html
   * Needs to be revised according to review comments

* Fortran allocatable components handling (needs to be split into separate pieces and submitted
   separately)
   https://gcc.gnu.org/pipermail/gcc-patches/2022-April/593704.html

* [PATCH 00/16] OpenMP: lvalues in "map" clauses and struct handling rework
   https://gcc.gnu.org/pipermail/gcc-patches/2021-December/586600.html
   and January + February updates (search for metadirective)
+ patch review end of May, e.g.
   https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595762.html  (+ 4 more emails)

* [PATCH 00/16] OpenMP: lvalues in "map" clauses and struct handling rework
   https://gcc.gnu.org/pipermail/gcc-patches/2021-November/585439.html
   + [PATCH v2 00/11] OpenMP 5.0: C & C++ "declare mapper" support (plus struct rework, etc.)
   https://gcc.gnu.org/pipermail/gcc-patches/2022-March/591973.html

* [PATCH 00/40] OpenACC "kernels" Improvements
   https://gcc.gnu.org/pipermail/gcc-patches/2021-December/586901.html
   (4 simple patches are in by now; could be reviewed, in principle)

-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

^ permalink raw reply	[flat|nested] 5+ messages in thread
* OpenMP patch ping
@ 2020-11-27 16:09 Tobias Burnus
  0 siblings, 0 replies; 5+ messages in thread
From: Tobias Burnus @ 2020-11-27 16:09 UTC (permalink / raw)
  To: Jakub Jelinek, gcc-patches

OpenMP-related patch pings:

Kwok's:
* Re: [PATCH] openmp: Implicit 'declare target' for C++ static initializers
   https://gcc.gnu.org/pipermail/gcc-patches/2020-November/559624.html
* RFC:
   Nested declare target support
   https://gcc.gnu.org/pipermail/gcc-patches/2020-November/559758.html

Chung-Lin's:
* [PATCH v2, OpenMP 5, C++] Implement implicit mapping of this[:1] (PR92120)
   https://gcc.gnu.org/pipermail/gcc-patches/2020-November/558975.html

My:
* [Patch] OpenMP: C/C++ parse 'omp allocate'
   https://gcc.gnu.org/pipermail/gcc-patches/2020-November/559930.html

If you have a comment to Julian's
* Re: [PATCH] nvptx: Cache stacks block for OpenMP kernel launch
   https://gcc.gnu.org/pipermail/gcc-patches/2020-November/559044.html

Tobias

-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-01-10 11:37 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-16 17:28 OpenMP patch ping Tobias Burnus
2022-09-06 15:01 ` Tobias Burnus
  -- strict thread matches above, loose matches on Subject: below --
2023-01-10 11:37 OpenMP Patch Ping Tobias Burnus
2022-11-24 12:01 Tobias Burnus
2020-11-27 16:09 OpenMP patch ping Tobias Burnus

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).