From: Andreas Krebbel <krebbel@linux.ibm.com>
To: Jeff Law <jeffreyalaw@gmail.com>, gcc-patches@gcc.gnu.org
Subject: Re: PING: New reg note REG_CFA_NORESTORE
Date: Wed, 11 Jan 2023 16:14:38 +0100 [thread overview]
Message-ID: <ab42ab16-6042-ae3d-7f4d-2680de708616@linux.ibm.com> (raw)
In-Reply-To: <a2c7efec-fa87-bd23-f151-bdca0e73d225@gmail.com>
On 12/27/22 19:23, Jeff Law wrote:
>
>
> On 12/13/22 01:55, Andreas Krebbel via Gcc-patches wrote:
>> Hi,
>>
>> I need a way to save registers on the stack and generate proper CFI for it. Since I do not intend to
>> restore them I needed a way to tell the CFI generation step about it:
>>
>> https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606128.html
>>
>> Is this ok for mainline?
> Presumably there's validation bits that want to validate that everything
> saved eventually gets restored?
>
> There's only one call to dwarf2out_frame_debug_cfa_restore, so ISTM that
> providing an initializer for the argument isn't needed and just creates
> an overload (and associated code) that isn't needed. Why not just
> remove the default initializer?
>
> Ok with that change or a good reason why you need to keep the initializer.
Right. I'll remove it. Thanks for having a look!
Bye,
Andreas
prev parent reply other threads:[~2023-01-11 15:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 8:55 Andreas Krebbel
2022-12-27 18:23 ` Jeff Law
2023-01-11 15:14 ` Andreas Krebbel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab42ab16-6042-ae3d-7f4d-2680de708616@linux.ibm.com \
--to=krebbel@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).