* PING: New reg note REG_CFA_NORESTORE
@ 2022-12-13 8:55 Andreas Krebbel
2022-12-27 18:23 ` Jeff Law
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Krebbel @ 2022-12-13 8:55 UTC (permalink / raw)
To: gcc-patches
Hi,
I need a way to save registers on the stack and generate proper CFI for it. Since I do not intend to
restore them I needed a way to tell the CFI generation step about it:
https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606128.html
Is this ok for mainline?
Bye,
Andreas
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PING: New reg note REG_CFA_NORESTORE
2022-12-13 8:55 PING: New reg note REG_CFA_NORESTORE Andreas Krebbel
@ 2022-12-27 18:23 ` Jeff Law
2023-01-11 15:14 ` Andreas Krebbel
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Law @ 2022-12-27 18:23 UTC (permalink / raw)
To: Andreas Krebbel, gcc-patches
On 12/13/22 01:55, Andreas Krebbel via Gcc-patches wrote:
> Hi,
>
> I need a way to save registers on the stack and generate proper CFI for it. Since I do not intend to
> restore them I needed a way to tell the CFI generation step about it:
>
> https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606128.html
>
> Is this ok for mainline?
Presumably there's validation bits that want to validate that everything
saved eventually gets restored?
There's only one call to dwarf2out_frame_debug_cfa_restore, so ISTM that
providing an initializer for the argument isn't needed and just creates
an overload (and associated code) that isn't needed. Why not just
remove the default initializer?
Ok with that change or a good reason why you need to keep the initializer.
jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PING: New reg note REG_CFA_NORESTORE
2022-12-27 18:23 ` Jeff Law
@ 2023-01-11 15:14 ` Andreas Krebbel
0 siblings, 0 replies; 3+ messages in thread
From: Andreas Krebbel @ 2023-01-11 15:14 UTC (permalink / raw)
To: Jeff Law, gcc-patches
On 12/27/22 19:23, Jeff Law wrote:
>
>
> On 12/13/22 01:55, Andreas Krebbel via Gcc-patches wrote:
>> Hi,
>>
>> I need a way to save registers on the stack and generate proper CFI for it. Since I do not intend to
>> restore them I needed a way to tell the CFI generation step about it:
>>
>> https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606128.html
>>
>> Is this ok for mainline?
> Presumably there's validation bits that want to validate that everything
> saved eventually gets restored?
>
> There's only one call to dwarf2out_frame_debug_cfa_restore, so ISTM that
> providing an initializer for the argument isn't needed and just creates
> an overload (and associated code) that isn't needed. Why not just
> remove the default initializer?
>
> Ok with that change or a good reason why you need to keep the initializer.
Right. I'll remove it. Thanks for having a look!
Bye,
Andreas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-11 15:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-13 8:55 PING: New reg note REG_CFA_NORESTORE Andreas Krebbel
2022-12-27 18:23 ` Jeff Law
2023-01-11 15:14 ` Andreas Krebbel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).