public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hp@bitrange.com>
To: YunQiang Su <yunqiang.su@cipunited.com>
Cc: gcc-patches@gcc.gnu.org, aurelien@aurel32.net,
	 adhemerval.zanella@linaro.org, jiaxun.yang@flygoat.com,
	macro@orcam.me.uk,  syq@debian.org, jakub@redhat.com,
	dodji@redhat.com, kcc@google.com,  dvyukov@google.com
Subject: Re: [PATCH] libsanitizer/mips: always build with largefile support
Date: Tue, 10 Jan 2023 19:53:07 -0500 (EST)	[thread overview]
Message-ID: <alpine.BSF.2.20.16.2301101947220.81573@arjuna.pair.com> (raw)
In-Reply-To: <20230106103632.3951217-1-yunqiang.su@cipunited.com>

On Fri, 6 Jan 2023, YunQiang Su wrote:

> -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 is always used for mips
> when build libsanitizer in LLVM. Thus
>    FIRST_32_SECOND_64((_MIPS_SIM == _ABIN32) ? 176 : 160, 216);
> instead of
>    FIRST_32_SECOND_64((_MIPS_SIM == _ABIN32) ? 160 : 144, 216);
> in sanitizer_platform_limits_posix.h.
> 
> To keep sync with LLVM and to make the code simple, we use the
> largefile options always.
> 
> libsanitizer/
> 	* configure.ac: set -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
> 	  always for mips*.
> 	* configure: Regenerate.

Hm, yes, that might be the most pragmatic way to solve the mips
stat-size issue...  But shouldn't then largefile-options also be 
forced when libsanitizer is *used*?  IOW, mips*-linux 
gcc-options be tweaked to include -D_LARGEFILE_SOURCE 
-D_FILE_OFFSET_BITS=64 conditional on sanitizer-options?

brgds, H-P

  reply	other threads:[~2023-01-11  0:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-06 10:36 YunQiang Su
2023-01-11  0:53 ` Hans-Peter Nilsson [this message]
2023-01-11 10:15   ` YunQiang Su

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.BSF.2.20.16.2301101947220.81573@arjuna.pair.com \
    --to=hp@bitrange.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=dodji@redhat.com \
    --cc=dvyukov@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=jiaxun.yang@flygoat.com \
    --cc=kcc@google.com \
    --cc=macro@orcam.me.uk \
    --cc=syq@debian.org \
    --cc=yunqiang.su@cipunited.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).