public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@embecosm.com>
To: "Jiang, Haochen" <haochen.jiang@intel.com>
Cc: Richard Biener <richard.guenther@gmail.com>,
	 "haochen.jiang" <haochenj@ecsmtp.sh.intel.com>,
	gcc-regression@gcc.gnu.org,  gcc-patches@gcc.gnu.org
Subject: [committed] testsuite: Limit bb-slp-pr95839-v8.c to 64-bit vector targets
Date: Sat, 22 Jul 2023 17:57:30 +0100 (BST)	[thread overview]
Message-ID: <alpine.DEB.2.20.2307221710120.28892@tpp.orcam.me.uk> (raw)
In-Reply-To: <SA1PR11MB594663D4CC2F193C470679DBEC3FA@SA1PR11MB5946.namprd11.prod.outlook.com>

Only run bb-slp-pr95839-v8.c with targets that support vectors of 64 
bits, removing regressions with 32-bit x86 targets:

FAIL: gcc.dg/vect/bb-slp-pr95839-v8.c scan-tree-dump slp2 "optimized: basic block"
FAIL: gcc.dg/vect/bb-slp-pr95839-v8.c -flto -ffat-lto-objects  scan-tree-dump slp2 "optimized: basic block"

	gcc/testsuite/
	* gcc.dg/vect/bb-slp-pr95839-v8.c: Limit to `vect64' targets.
---
On Fri, 21 Jul 2023, Jiang, Haochen wrote:

> > > > I think the issue is we disable V2SF on ia32 because of the conflict
> > > > with MMX which we don't want to use.
> > >
> > >  I'm not sure if I have a way to test with such a target.  Would you
> > > expect:
> > >
> > > /* { dg-require-effective-target vect64 } */
> > >
> > > to cover it?  If so, then I'll put it back as in the original version
> > > and post for Haochen to verify.
> 
> I suppose just commit to trunk and it should be ok since it is only -m32 
> issue.

 Thanks for mentioning `-m32', I was able to use it to verify this change 
and confirm that the qualifier does indeed work for this configuration.  
Committed as posted then and apologies for messing this up.

  Maciej
---
 gcc/testsuite/gcc.dg/vect/bb-slp-pr95839-v8.c |    1 +
 1 file changed, 1 insertion(+)

gcc-test-bb-slp-pr95839-v8-fix.diff
Index: gcc/gcc/testsuite/gcc.dg/vect/bb-slp-pr95839-v8.c
===================================================================
--- gcc.orig/gcc/testsuite/gcc.dg/vect/bb-slp-pr95839-v8.c
+++ gcc/gcc/testsuite/gcc.dg/vect/bb-slp-pr95839-v8.c
@@ -1,5 +1,6 @@
 /* { dg-do compile } */
 /* { dg-require-effective-target vect_float } */
+/* { dg-require-effective-target vect64 } */
 /* { dg-additional-options "-w -Wno-psabi" } */
 
 typedef float __attribute__((vector_size(8))) v2f32;

      reply	other threads:[~2023-07-22 16:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-20 11:44 [r14-2639 Regression] FAIL: gcc.dg/vect/bb-slp-pr95839-v8.c scan-tree-dump slp2 "optimized: basic block" on Linux/x86_64 haochen.jiang
2023-07-20 12:51 ` Richard Biener
2023-07-20 13:13   ` Maciej W. Rozycki
2023-07-20 13:27     ` Richard Biener
2023-07-21  1:51       ` Jiang, Haochen
2023-07-22 16:57         ` Maciej W. Rozycki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.2307221710120.28892@tpp.orcam.me.uk \
    --to=macro@embecosm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gcc-regression@gcc.gnu.org \
    --cc=haochen.jiang@intel.com \
    --cc=haochenj@ecsmtp.sh.intel.com \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).