From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Xi Ruoyao <xry111@xry111.site>
Cc: YunQiang Su <yunqiang.su@cipunited.com>,
gcc-patches@gcc.gnu.org, doko@debian.org,
Jeff Law <jeffreyalaw@gmail.com>
Subject: Re: [PATCH] MIPS: fix building on multiarch platform
Date: Wed, 21 Sep 2022 17:03:54 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2209211624400.41633@angie.orcam.me.uk> (raw)
In-Reply-To: <c8f6663967d170dd51e2bc33481618e1beffb313.camel@xry111.site>
On Wed, 21 Sep 2022, Xi Ruoyao wrote:
> > diff --git a/gcc/config/mips/mips.h b/gcc/config/mips/mips.h
> > index 74b6e11aabb..fe7f5b274b9 100644
> > --- a/gcc/config/mips/mips.h
> > +++ b/gcc/config/mips/mips.h
> > @@ -3427,6 +3427,7 @@ struct GTY(()) machine_function {
> >
> > /* If we are *not* using multilibs and the default ABI is not ABI_32
> > we
> > need to change these from /lib and /usr/lib. */
> > +#ifndef ENABLE_MULTIARCH
> > #if MIPS_ABI_DEFAULT == ABI_N32
> > #define STANDARD_STARTFILE_PREFIX_1 "/lib32/"
> > #define STANDARD_STARTFILE_PREFIX_2 "/usr/lib32/"
> > @@ -3434,6 +3435,7 @@ struct GTY(()) machine_function {
> > #define STANDARD_STARTFILE_PREFIX_1 "/lib64/"
> > #define STANDARD_STARTFILE_PREFIX_2 "/usr/lib64/"
> > #endif
> > +#endif
>
> Should we just remove STANDARD_STARTFILE_PREFIX_{1,2} unconditionally?
> I just took a look and the only Linux ports using these macros are MIPS
> and LoongArch (borrowed these macros from MIPS, I guess). On a non-
> multilib distro /usr/lib is likely used, and on multilib distros the
> macros are not used anyway.
See <https://gcc.gnu.org/ml/gcc-patches/2014-10/msg03377.html> for the
rationale. Has glibc switched since?
Maciej
next prev parent reply other threads:[~2022-09-21 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 11:31 YunQiang Su
2022-09-21 15:08 ` Xi Ruoyao
2022-09-21 16:03 ` Maciej W. Rozycki [this message]
2022-09-23 12:35 ` YunQiang Su
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2209211624400.41633@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=doko@debian.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=xry111@xry111.site \
--cc=yunqiang.su@cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).