GCN: Enable effective-target 'vect_long_long'

GCN: Enable effective-target 'vect_long_long'

[Thomas Schwinge]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

Hi!

OK to push the attached "GCN: Enable effective-target 'vect_long_long'"?
(Or is that not what you'd expect to see for GCN?  I haven't checked the
actual back end code...)


Grüße
 Thomas



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-GCN-Enable-effective-target-vect_long_long.patch --]
[-- Type: text/x-diff, Size: 1389 bytes --]

From d74cc9caadfe36652503782a8da172ae1975915c Mon Sep 17 00:00:00 2001
From: Thomas Schwinge <tschwinge@baylibre.com>
Date: Tue, 16 Apr 2024 14:10:15 +0200
Subject: [PATCH] GCN: Enable effective-target 'vect_long_long'

... as made apparent by a number of unexpectedly UNSUPPORTED test cases, which
now all turn into PASS, with just one exception:

    PASS: gcc.dg/vect/vect-early-break_124-pr114403.c (test for excess errors)
    PASS: gcc.dg/vect/vect-early-break_124-pr114403.c execution test
    FAIL: gcc.dg/vect/vect-early-break_124-pr114403.c scan-tree-dump vect "LOOP VECTORIZED"

..., which needs to be looked into, separately.

	gcc/testsuite/
	* lib/target-supports.exp (check_effective_target_vect_long_long):
	Enable for GCN.
---
 gcc/testsuite/lib/target-supports.exp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index 594837653bb..1a8459561c6 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -7692,7 +7692,8 @@ proc check_effective_target_vect_long_long { } {
 	     || ([istarget riscv*-*-*]
 		 && [check_effective_target_riscv_v])
 	     || ([istarget loongarch*-*-*]
-		 && [check_effective_target_loongarch_sx])}}]
+		 && [check_effective_target_loongarch_sx])
+	     || [istarget amdgcn-*-*] }}]
 }
 
 
-- 
2.34.1

Re: GCN: Enable effective-target 'vect_long_long'

[Andrew Stubbs]

On 16/04/2024 20:01, Thomas Schwinge wrote:
> Hi!
> 
> OK to push the attached "GCN: Enable effective-target 'vect_long_long'"?
> (Or is that not what you'd expect to see for GCN?  I haven't checked the
> actual back end code...)

I think if there are still missing int64 vector operations then they're 
exceptions, not the rule.

The patch looks good to me.

Andrew