* [PATCH 1/2] Fix contracts-tmpl-spec2.C on targets where plain char is unsigned by default
@ 2023-11-26 2:57 Andrew Pinski
2023-11-26 2:58 ` [PATCH 2/2] Fix gcc.target/aarch64/simd/vmulxd_{f64,f32}_2.c after after IPA-VRP improvement for return values Andrew Pinski
2024-02-07 16:23 ` [PATCH 1/2] Fix contracts-tmpl-spec2.C on targets where plain char is unsigned by default Torbjorn SVENSSON
0 siblings, 2 replies; 5+ messages in thread
From: Andrew Pinski @ 2023-11-26 2:57 UTC (permalink / raw)
To: gcc-patches
Since contracts-tmpl-spec2.C is just testing contracts, I thought it would be better
to just add `-fsigned-char` to the options rather than change the testcase to support
both cases.
Committed after testing on aarch64-linux-gnu.
gcc/testsuite/ChangeLog:
PR testsuite/108321
* g++.dg/contracts/contracts-tmpl-spec2.C: Add -fsigned-char
to options.
---
gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C b/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C
index 82117671b2d..fd3a25bd051 100644
--- a/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C
+++ b/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C
@@ -1,6 +1,6 @@
// basic test to ensure contracts work for class and member specializations
// { dg-do run }
-// { dg-options "-std=c++2a -fcontracts -fcontract-continuation-mode=on" }
+// { dg-options "-std=c++2a -fcontracts -fcontract-continuation-mode=on -fsigned-char" }
#include <cstdio>
// template specializations can have differing contracts
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] Fix gcc.target/aarch64/simd/vmulxd_{f64,f32}_2.c after after IPA-VRP improvement for return values
2023-11-26 2:57 [PATCH 1/2] Fix contracts-tmpl-spec2.C on targets where plain char is unsigned by default Andrew Pinski
@ 2023-11-26 2:58 ` Andrew Pinski
2024-02-07 16:23 ` [PATCH 1/2] Fix contracts-tmpl-spec2.C on targets where plain char is unsigned by default Torbjorn SVENSSON
1 sibling, 0 replies; 5+ messages in thread
From: Andrew Pinski @ 2023-11-26 2:58 UTC (permalink / raw)
To: gcc-patches
Just like the patch against gcc.target/aarch64/movk.c, the issue here
is the two functions, foo32 and foo64 needed to mark as noipa so that
IPA-VRP cannot propagate the return value.
gcc/testsuite/ChangeLog:
* gcc.target/aarch64/simd/vmulx.x (foo32): Mark as noipa rather
than noinline.
(foo4): Likewise.
---
gcc/testsuite/gcc.target/aarch64/simd/vmulx.x | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/testsuite/gcc.target/aarch64/simd/vmulx.x b/gcc/testsuite/gcc.target/aarch64/simd/vmulx.x
index 8968a64a95c..869e7485646 100644
--- a/gcc/testsuite/gcc.target/aarch64/simd/vmulx.x
+++ b/gcc/testsuite/gcc.target/aarch64/simd/vmulx.x
@@ -33,13 +33,13 @@
while (0) \
/* Functions used to return values that won't be optimised away. */
-float32_t __attribute__ ((noinline))
+float32_t __attribute__ ((noipa))
foo32 ()
{
return 1.0;
}
-float64_t __attribute__ ((noinline))
+float64_t __attribute__ ((noipa))
foo64 ()
{
return 1.0;
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] Fix contracts-tmpl-spec2.C on targets where plain char is unsigned by default
2023-11-26 2:57 [PATCH 1/2] Fix contracts-tmpl-spec2.C on targets where plain char is unsigned by default Andrew Pinski
2023-11-26 2:58 ` [PATCH 2/2] Fix gcc.target/aarch64/simd/vmulxd_{f64,f32}_2.c after after IPA-VRP improvement for return values Andrew Pinski
@ 2024-02-07 16:23 ` Torbjorn SVENSSON
2024-02-07 17:13 ` Andrew Pinski (QUIC)
1 sibling, 1 reply; 5+ messages in thread
From: Torbjorn SVENSSON @ 2024-02-07 16:23 UTC (permalink / raw)
To: Andrew Pinski, gcc-patches; +Cc: Yvan Roux
Hi,
Is it okay to backport 6e15e4e1abed02443a27a69455f4bfa49457c99e to
releases/gcc-13?
Without this backport, I see this failure on arm-none-eabi:
FAIL: g++.dg/contracts/contracts-tmpl-spec2.C output pattern test
Kind regards,
Torbjörn
On 2023-11-26 03:57, Andrew Pinski wrote:
> Since contracts-tmpl-spec2.C is just testing contracts, I thought it would be better
> to just add `-fsigned-char` to the options rather than change the testcase to support
> both cases.
>
> Committed after testing on aarch64-linux-gnu.
>
> gcc/testsuite/ChangeLog:
>
> PR testsuite/108321
> * g++.dg/contracts/contracts-tmpl-spec2.C: Add -fsigned-char
> to options.
> ---
> gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C b/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C
> index 82117671b2d..fd3a25bd051 100644
> --- a/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C
> +++ b/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C
> @@ -1,6 +1,6 @@
> // basic test to ensure contracts work for class and member specializations
> // { dg-do run }
> -// { dg-options "-std=c++2a -fcontracts -fcontract-continuation-mode=on" }
> +// { dg-options "-std=c++2a -fcontracts -fcontract-continuation-mode=on -fsigned-char" }
> #include <cstdio>
>
> // template specializations can have differing contracts
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 1/2] Fix contracts-tmpl-spec2.C on targets where plain char is unsigned by default
2024-02-07 16:23 ` [PATCH 1/2] Fix contracts-tmpl-spec2.C on targets where plain char is unsigned by default Torbjorn SVENSSON
@ 2024-02-07 17:13 ` Andrew Pinski (QUIC)
2024-02-07 17:36 ` Torbjorn SVENSSON
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Pinski (QUIC) @ 2024-02-07 17:13 UTC (permalink / raw)
To: Torbjorn SVENSSON, Andrew Pinski (QUIC), gcc-patches; +Cc: Yvan Roux
> -----Original Message-----
> From: Torbjorn SVENSSON <torbjorn.svensson@foss.st.com>
> Sent: Wednesday, February 7, 2024 8:23 AM
> To: Andrew Pinski (QUIC) <quic_apinski@quicinc.com>; gcc-
> patches@gcc.gnu.org
> Cc: Yvan Roux <yvan.roux@foss.st.com>
> Subject: Re: [PATCH 1/2] Fix contracts-tmpl-spec2.C on targets where plain
> char is unsigned by default
>
> Hi,
>
> Is it okay to backport 6e15e4e1abed02443a27a69455f4bfa49457c99e to
> releases/gcc-13?
From my point of view, this is ok to backport. It is just a testsuite change so I didn't think it was important enough to backport from an user of GCC point of view.
Thanks,
Andrew Pinski
>
> Without this backport, I see this failure on arm-none-eabi:
>
> FAIL: g++.dg/contracts/contracts-tmpl-spec2.C output pattern test
>
> Kind regards,
> Torbjörn
>
>
> On 2023-11-26 03:57, Andrew Pinski wrote:
> > Since contracts-tmpl-spec2.C is just testing contracts, I thought it
> > would be better to just add `-fsigned-char` to the options rather than
> > change the testcase to support both cases.
> >
> > Committed after testing on aarch64-linux-gnu.
> >
> > gcc/testsuite/ChangeLog:
> >
> > PR testsuite/108321
> > * g++.dg/contracts/contracts-tmpl-spec2.C: Add -fsigned-char
> > to options.
> > ---
> > gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C
> > b/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C
> > index 82117671b2d..fd3a25bd051 100644
> > --- a/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C
> > +++ b/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C
> > @@ -1,6 +1,6 @@
> > // basic test to ensure contracts work for class and member specializations
> > // { dg-do run }
> > -// { dg-options "-std=c++2a -fcontracts
> > -fcontract-continuation-mode=on" }
> > +// { dg-options "-std=c++2a -fcontracts
> > +-fcontract-continuation-mode=on -fsigned-char" }
> > #include <cstdio>
> >
> > // template specializations can have differing contracts
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] Fix contracts-tmpl-spec2.C on targets where plain char is unsigned by default
2024-02-07 17:13 ` Andrew Pinski (QUIC)
@ 2024-02-07 17:36 ` Torbjorn SVENSSON
0 siblings, 0 replies; 5+ messages in thread
From: Torbjorn SVENSSON @ 2024-02-07 17:36 UTC (permalink / raw)
To: Andrew Pinski (QUIC), gcc-patches; +Cc: Yvan Roux
On 2024-02-07 18:13, Andrew Pinski (QUIC) wrote:
>> -----Original Message-----
>> From: Torbjorn SVENSSON <torbjorn.svensson@foss.st.com>
>> Sent: Wednesday, February 7, 2024 8:23 AM
>> To: Andrew Pinski (QUIC) <quic_apinski@quicinc.com>; gcc-
>> patches@gcc.gnu.org
>> Cc: Yvan Roux <yvan.roux@foss.st.com>
>> Subject: Re: [PATCH 1/2] Fix contracts-tmpl-spec2.C on targets where plain
>> char is unsigned by default
>>
>> Hi,
>>
>> Is it okay to backport 6e15e4e1abed02443a27a69455f4bfa49457c99e to
>> releases/gcc-13?
>
> From my point of view, this is ok to backport. It is just a testsuite change so I didn't think it was important enough to backport from an user of GCC point of view.
Pushed as 0cdb04629641c51498f099db04021e8de51adedb.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-02-07 17:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-26 2:57 [PATCH 1/2] Fix contracts-tmpl-spec2.C on targets where plain char is unsigned by default Andrew Pinski
2023-11-26 2:58 ` [PATCH 2/2] Fix gcc.target/aarch64/simd/vmulxd_{f64,f32}_2.c after after IPA-VRP improvement for return values Andrew Pinski
2024-02-07 16:23 ` [PATCH 1/2] Fix contracts-tmpl-spec2.C on targets where plain char is unsigned by default Torbjorn SVENSSON
2024-02-07 17:13 ` Andrew Pinski (QUIC)
2024-02-07 17:36 ` Torbjorn SVENSSON
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).