From: "Martin Liška" <mliska@suse.cz>
To: "Torbjörn SVENSSON" <torbjorn.svensson@foss.st.com>,
gcc-patches@gcc.gnu.org
Cc: hubicka@ucw.cz, nathan@acm.org, ro@CeBiTec.Uni-Bielefeld.DE,
mikestump@comcast.net
Subject: Re: [PATCH] gcov: Respect tripplet when looking for gcov
Date: Fri, 9 Sep 2022 13:46:57 +0200 [thread overview]
Message-ID: <b38c22c4-3bd5-1b20-9e26-ac835f172aa6@suse.cz> (raw)
In-Reply-To: <20220909102707.2557434-1-torbjorn.svensson@foss.st.com>
On 9/9/22 12:27, Torbjörn SVENSSON wrote:
> When testing a cross toolchain outside the build tree, the binary name
> for gcov is prefixed with the tripplet.
Ok, thanks!
Martin
>
> gcc/testsuite/ChangeLog:
>
> * g++.dg/gcov/gcov.exp: Respect tripplet when looking for gcov
> * gcc.misc-tests/gcov.exp: Likewise
>
> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
> ---
> gcc/testsuite/g++.dg/gcov/gcov.exp | 4 ++--
> gcc/testsuite/gcc.misc-tests/gcov.exp | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/gcc/testsuite/g++.dg/gcov/gcov.exp b/gcc/testsuite/g++.dg/gcov/gcov.exp
> index 88acd95c361..04e7a016486 100644
> --- a/gcc/testsuite/g++.dg/gcov/gcov.exp
> +++ b/gcc/testsuite/g++.dg/gcov/gcov.exp
> @@ -24,9 +24,9 @@ global GXX_UNDER_TEST
>
> # Find gcov in the same directory as $GXX_UNDER_TEST.
> if { ![is_remote host] && [string match "*/*" [lindex $GXX_UNDER_TEST 0]] } {
> - set GCOV [file dirname [lindex $GXX_UNDER_TEST 0]]/gcov
> + set GCOV [file dirname [lindex $GXX_UNDER_TEST 0]]/[transform gcov]
> } else {
> - set GCOV gcov
> + set GCOV [transform gcov]
> }
>
> # Initialize harness.
> diff --git a/gcc/testsuite/gcc.misc-tests/gcov.exp b/gcc/testsuite/gcc.misc-tests/gcov.exp
> index 82376d90ac2..a55ce234f6e 100644
> --- a/gcc/testsuite/gcc.misc-tests/gcov.exp
> +++ b/gcc/testsuite/gcc.misc-tests/gcov.exp
> @@ -24,9 +24,9 @@ global GCC_UNDER_TEST
>
> # For now find gcov in the same directory as $GCC_UNDER_TEST.
> if { ![is_remote host] && [string match "*/*" [lindex $GCC_UNDER_TEST 0]] } {
> - set GCOV [file dirname [lindex $GCC_UNDER_TEST 0]]/gcov
> + set GCOV [file dirname [lindex $GCC_UNDER_TEST 0]]/[transform gcov]
> } else {
> - set GCOV gcov
> + set GCOV {transform gcov]
> }
>
> # Initialize harness.
next prev parent reply other threads:[~2022-09-09 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 10:27 Torbjörn SVENSSON
2022-09-09 11:46 ` Martin Liška [this message]
2022-09-09 11:56 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b38c22c4-3bd5-1b20-9e26-ac835f172aa6@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=mikestump@comcast.net \
--cc=nathan@acm.org \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
--cc=torbjorn.svensson@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).