From: Jeff Law <jeffreyalaw@gmail.com>
To: liuhongt <hongtao.liu@intel.com>, gcc-patches@gcc.gnu.org
Cc: vmakarov@redhat.com
Subject: Re: [PATCH] Check hard_regno_mode_ok before setting lowest memory move cost for the mode with different reg classes.
Date: Tue, 4 Apr 2023 19:29:04 -0600 [thread overview]
Message-ID: <b3a35c94-f2a9-3fc0-e1c4-e15f4fd81c5c@gmail.com> (raw)
In-Reply-To: <20230404051346.1223071-1-hongtao.liu@intel.com>
On 4/3/23 23:13, liuhongt via Gcc-patches wrote:
> There's a potential performance issue when backend returns some
> unreasonable value for the mode which can be never be allocate with
> reg class.
>
> Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}.
> Ok for trunk(or GCC14 stage1)?
>
> gcc/ChangeLog:
>
> PR rtl-optimization/109351
> * ira.cc (setup_class_subset_and_memory_move_costs): Check
> hard_regno_mode_ok before setting lowest memory move cost for
> the mode with different reg classes.
Not a regression *and* changing register allocation. This seems like it
should defer to gcc-14.
jeff
next prev parent reply other threads:[~2023-04-05 1:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 5:13 liuhongt
2023-04-05 1:29 ` Jeff Law [this message]
2023-04-05 12:58 ` Vladimir Makarov
2023-04-06 5:07 ` Liu, Hongtao
2023-04-19 5:53 ` Hongtao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3a35c94-f2a9-3fc0-e1c4-e15f4fd81c5c@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hongtao.liu@intel.com \
--cc=vmakarov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).