public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Malcolm <dmalcolm@redhat.com>
To: mirimnan017@gmail.com, gcc-patches@gcc.gnu.org
Cc: Immad Mir <mirimmad@outlook.com>
Subject: Re: [PATCH] analyzer: fix for ICE in sm-fd.cc [PR106551]
Date: Mon, 15 Aug 2022 11:48:31 -0400	[thread overview]
Message-ID: <b5b16e4ec8d5524623bb62ed9e72b849a1214ae3.camel@redhat.com> (raw)
In-Reply-To: <CY4PR1801MB1910D7C6854D6F85226BC689C6689@CY4PR1801MB1910.namprd18.prod.outlook.com>

On Mon, 2022-08-15 at 14:02 +0530, Immad Mir wrote:
> This patch fixes the ICE caused by valid_to_unchecked_state
> in sm-fd.cc by exiting early if first argument of any "dup"
> functions is invalid.
> 
> gcc/analyzer/ChangeLog:
>         PR analyzer/106551
>         * sm-fd.cc (check_for_dup): exit early if first
>         argument is invalid for all dup functions.
> 
> gcc/testsuite/ChangeLog:
>         PR analyzer/106551
>         * gcc.dg/analyzer/fd-dup-1.c: New testcase.
> 
> Signed-off-by: Immad Mir <mirimmad@outlook.com>

Thanks; looks good to me.

Dave


      reply	other threads:[~2022-08-15 15:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-15  8:32 Immad Mir
2022-08-15 15:48 ` David Malcolm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5b16e4ec8d5524623bb62ed9e72b849a1214ae3.camel@redhat.com \
    --to=dmalcolm@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mirimmad@outlook.com \
    --cc=mirimnan017@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).