From: Jeff Law <jeffreyalaw@gmail.com>
To: Richard Biener <rguenther@suse.de>, gcc-patches@gcc.gnu.org
Cc: richard.sandiford@arm.com
Subject: Re: [PATCH] tree-optimization/110742 - fix latent issue with permuting existing vectors
Date: Thu, 20 Jul 2023 15:31:27 -0600 [thread overview]
Message-ID: <b7048871-2e49-ace0-1902-68dda135ecac@gmail.com> (raw)
In-Reply-To: <20230720123851.61BA33857711@sourceware.org>
On 7/20/23 06:38, Richard Biener via Gcc-patches wrote:
> When we materialize a layout we push edge permutes to constant/external
> defs without checking we can actually do so. For externals defined
> by vector stmts rather than scalar components we can't.
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu.
>
> OK?
>
> Thanks,
> Richard.
>
> PR tree-optimization/110742
> * tree-vect-slp.cc (vect_optimize_slp_pass::get_result_with_layout):
> Do not materialize an edge permutation in an external node with
> vector defs.
> (vect_slp_analyze_node_operations_1): Guard purely internal
> nodes better.
>
> * g++.dg/torture/pr110742.C: New testcase.
OK
jeff
next parent reply other threads:[~2023-07-20 21:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230720123851.61BA33857711@sourceware.org>
2023-07-20 21:31 ` Jeff Law [this message]
[not found] <20230720123855.334A4385AF91@sourceware.org>
2023-07-20 14:08 ` Richard Sandiford
2023-07-20 14:57 ` Richard Biener
2023-07-20 16:58 ` Richard Sandiford
2023-07-20 17:10 ` Richard Biener
2023-07-20 17:40 ` Richard Sandiford
2023-07-21 6:12 ` Richard Biener
2023-07-20 12:38 Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7048871-2e49-ace0-1902-68dda135ecac@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).