From: Jeff Law <jeffreyalaw@gmail.com>
To: Robin Dapp <rdapp@linux.ibm.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] testsuite: Add vect_floatint_cvt to gcc.dg/vect/pr56541.c
Date: Wed, 5 May 2021 11:05:16 -0600 [thread overview]
Message-ID: <b85b2d85-5d2f-6a32-006d-91b1120064d6@gmail.com> (raw)
In-Reply-To: <cd7b8eb6-647c-8b41-2f54-2f7cb5b00ba6@linux.ibm.com>
On 5/5/2021 8:31 AM, Robin Dapp via Gcc-patches wrote:
> Hi,
>
> pr56541.c implicitly converts a float vector to an int (bool) vector:
>
> rMin = (rMax>0) ? rMin : rBig;
>
> It fails on some s390 targets because the do not support converting
> from vector float to int. Is adding a vect_floatint_cvt as in the
> attached patch the OK thing to do?
>
> Or better an xfail with ! vect_floatint_cvt?
>
> Regards
> Robin
>
> gcc/testsuite/ChangeLog:
>
> * gcc.dg/vect/pr56541.c: Add vect_floatint_cvt.
OK. I'd tend to use XFAIL for a compiler bug that we haven't fixed. In
this case the target doesn't support what the test is trying to do. So
skipping the test in one manner or another seems better.
jeff
next prev parent reply other threads:[~2021-05-05 17:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 14:31 Robin Dapp
2021-05-05 17:05 ` Jeff Law [this message]
2021-06-09 12:39 ` Robin Dapp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b85b2d85-5d2f-6a32-006d-91b1120064d6@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rdapp@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).