* [PATCH] IRA: Make sure array is big enough
@ 2022-10-25 10:01 Torbjörn SVENSSON
2022-10-26 20:26 ` Vladimir Makarov
0 siblings, 1 reply; 3+ messages in thread
From: Torbjörn SVENSSON @ 2022-10-25 10:01 UTC (permalink / raw)
To: gcc-patches; +Cc: vmakarov, yvan.roux, Torbjörn SVENSSON
In commit 081c96621da, the call to resize_reg_info() was moved before
the call to remove_scratches() and the latter one can increase the
number of regs and that would cause an out of bounds usage on the
reg_renumber global array.
Without this patch, the following testcase randomly fails with:
during RTL pass: ira
In file included from /src/gcc/testsuite/gcc.dg/compat//struct-by-value-5b_y.c:13:
/src/gcc/testsuite/gcc.dg/compat//struct-by-value-5b_y.c: In function 'checkgSf13':
/src/gcc/testsuite/gcc.dg/compat//fp-struct-test-by-value-y.h:28:1: internal compiler error: Segmentation fault
/src/gcc/testsuite/gcc.dg/compat//struct-by-value-5b_y.c:22:1: note: in expansion of macro 'TEST'
gcc/ChangeLog:
* ira.c: Resize array after reg number increased.
Co-Authored-By: Yvan ROUX <yvan.roux@foss.st.com>
Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
---
gcc/ira.cc | 1 +
1 file changed, 1 insertion(+)
diff --git a/gcc/ira.cc b/gcc/ira.cc
index 42c9cead9f8..d28a67b2546 100644
--- a/gcc/ira.cc
+++ b/gcc/ira.cc
@@ -5718,6 +5718,7 @@ ira (FILE *f)
regstat_free_ri ();
regstat_init_n_sets_and_refs ();
regstat_compute_ri ();
+ resize_reg_info ();
};
int max_regno_before_rm = max_reg_num ();
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] IRA: Make sure array is big enough
2022-10-25 10:01 [PATCH] IRA: Make sure array is big enough Torbjörn SVENSSON
@ 2022-10-26 20:26 ` Vladimir Makarov
2022-10-27 7:42 ` Torbjorn SVENSSON
0 siblings, 1 reply; 3+ messages in thread
From: Vladimir Makarov @ 2022-10-26 20:26 UTC (permalink / raw)
To: Torbjörn SVENSSON, gcc-patches; +Cc: yvan.roux
On 2022-10-25 06:01, Torbjörn SVENSSON wrote:
> In commit 081c96621da, the call to resize_reg_info() was moved before
> the call to remove_scratches() and the latter one can increase the
> number of regs and that would cause an out of bounds usage on the
> reg_renumber global array.
>
> Without this patch, the following testcase randomly fails with:
> during RTL pass: ira
> In file included from /src/gcc/testsuite/gcc.dg/compat//struct-by-value-5b_y.c:13:
> /src/gcc/testsuite/gcc.dg/compat//struct-by-value-5b_y.c: In function 'checkgSf13':
> /src/gcc/testsuite/gcc.dg/compat//fp-struct-test-by-value-y.h:28:1: internal compiler error: Segmentation fault
> /src/gcc/testsuite/gcc.dg/compat//struct-by-value-5b_y.c:22:1: note: in expansion of macro 'TEST'
>
> gcc/ChangeLog:
>
> * ira.c: Resize array after reg number increased.
The patch is ok to commit it into gcc-11,12 branches and master.
Thank you for fixing this.
> Co-Authored-By: Yvan ROUX <yvan.roux@foss.st.com>
> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
> ---
> gcc/ira.cc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gcc/ira.cc b/gcc/ira.cc
> index 42c9cead9f8..d28a67b2546 100644
> --- a/gcc/ira.cc
> +++ b/gcc/ira.cc
> @@ -5718,6 +5718,7 @@ ira (FILE *f)
> regstat_free_ri ();
> regstat_init_n_sets_and_refs ();
> regstat_compute_ri ();
> + resize_reg_info ();
> };
>
> int max_regno_before_rm = max_reg_num ();
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] IRA: Make sure array is big enough
2022-10-26 20:26 ` Vladimir Makarov
@ 2022-10-27 7:42 ` Torbjorn SVENSSON
0 siblings, 0 replies; 3+ messages in thread
From: Torbjorn SVENSSON @ 2022-10-27 7:42 UTC (permalink / raw)
To: Vladimir Makarov, gcc-patches; +Cc: yvan.roux
On 2022-10-26 22:26, Vladimir Makarov wrote:
>
> On 2022-10-25 06:01, Torbjörn SVENSSON wrote:
>> In commit 081c96621da, the call to resize_reg_info() was moved before
>> the call to remove_scratches() and the latter one can increase the
>> number of regs and that would cause an out of bounds usage on the
>> reg_renumber global array.
>>
>> Without this patch, the following testcase randomly fails with:
>> during RTL pass: ira
>> In file included from
>> /src/gcc/testsuite/gcc.dg/compat//struct-by-value-5b_y.c:13:
>> /src/gcc/testsuite/gcc.dg/compat//struct-by-value-5b_y.c: In function
>> 'checkgSf13':
>> /src/gcc/testsuite/gcc.dg/compat//fp-struct-test-by-value-y.h:28:1:
>> internal compiler error: Segmentation fault
>> /src/gcc/testsuite/gcc.dg/compat//struct-by-value-5b_y.c:22:1: note:
>> in expansion of macro 'TEST'
>>
>> gcc/ChangeLog:
>>
>> * ira.c: Resize array after reg number increased.
>
> The patch is ok to commit it into gcc-11,12 branches and master.
Thank you for the review!
Pushed to gcc-11, gcc-12 and master.
>
> Thank you for fixing this.
>
>> Co-Authored-By: Yvan ROUX <yvan.roux@foss.st.com>
>> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
>> ---
>> gcc/ira.cc | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/gcc/ira.cc b/gcc/ira.cc
>> index 42c9cead9f8..d28a67b2546 100644
>> --- a/gcc/ira.cc
>> +++ b/gcc/ira.cc
>> @@ -5718,6 +5718,7 @@ ira (FILE *f)
>> regstat_free_ri ();
>> regstat_init_n_sets_and_refs ();
>> regstat_compute_ri ();
>> + resize_reg_info ();
>> };
>> int max_regno_before_rm = max_reg_num ();
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-27 7:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-25 10:01 [PATCH] IRA: Make sure array is big enough Torbjörn SVENSSON
2022-10-26 20:26 ` Vladimir Makarov
2022-10-27 7:42 ` Torbjorn SVENSSON
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).