From: Jeff Law <jeffreyalaw@gmail.com>
To: Robin Dapp <rdapp.gcc@gmail.com>,
Kito Cheng <kito.cheng@sifive.com>,
"Li, Pan2" <pan2.li@intel.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai>,
"Wang, Yanzhang" <yanzhang.wang@intel.com>
Subject: Re: [PATCH v7] RISC-V: Support CALL for RVV floating-point dynamic rounding
Date: Wed, 26 Jul 2023 15:40:52 -0600 [thread overview]
Message-ID: <bc537a87-5297-846b-d6a4-141c6852784b@gmail.com> (raw)
In-Reply-To: <911144fa-47f1-4607-0795-fac42de680fe@gmail.com>
On 7/26/23 07:08, Robin Dapp via Gcc-patches wrote:
> So after thinking about it again - I'm still not really sure
> I like treating every function as essentially an fesetround.
> There is a reason why fesetround is special. Does LLVM behave
> the same way?
>
> But supposing we really, really want it and assuming there's consensus:
>
> + start_sequence ();
> + emit_insn (gen_frrmsi (DYNAMIC_FRM_RTL (cfun)));
> + rtx_insn *backup_insn = get_insns ();
> + end_sequence ();
>
> A comment here would be nice why we need a sequence for a single
> instruction. I'm not fully aware what insert_insn_end_basic_block
> does but won't a
>
> rtx_insn *last = BB_END (bb);
> emit_insn_before_noloc (gen_frrmsi (DYNAMIC_FRM_RTL (cfun)), last, bb);
>
> suffice? One way or another need these kinds of non-local
> constructs here don't seem entirely rock solid.
Typically an LCM algorithm needs to insert on edges rather than at the
end of blocks -- this is particularly important to preserve its property
that on no path through the CFG can we have more evaluations of the
expression after PRE/LCM than before PRE/LCM.
The other thing edge insertions do is simplify the abnormal critical
edge problems. I'd have to dig into the precise details, but in the
generic PRE/LCM code we clobber the available expressions on critical
edges so that we don't try to hold a value live across that edge.
Thus the insertion point will tend to be the normal edge of a block that
ends with a call to a potentially throwing function.
Inserting on the edge also significantly simplifies handling of
conditional branches ;-)
Jeff
next prev parent reply other threads:[~2023-07-26 21:40 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 3:28 [PATCH v1] " pan2.li
2023-07-19 3:31 ` juzhe.zhong
2023-07-19 6:30 ` Li, Pan2
2023-07-20 6:43 ` [PATCH v4] " pan2.li
2023-07-20 6:47 ` juzhe.zhong
2023-07-21 3:11 ` juzhe.zhong
2023-07-21 6:44 ` Li, Pan2
2023-07-23 13:11 ` [PATCH v5] " pan2.li
2023-07-24 0:53 ` juzhe.zhong
2023-07-24 1:51 ` Li, Pan2
2023-07-24 2:45 ` Li, Pan2
2023-07-24 2:42 ` [PATCH v6] " pan2.li
2023-07-24 10:28 ` Robin Dapp
2023-07-24 11:59 ` Li, Pan2
2023-07-24 12:03 ` Li, Pan2
2023-07-25 5:51 ` [PATCH v7] " pan2.li
2023-07-25 6:07 ` Li, Pan2
2023-07-25 8:38 ` Robin Dapp
2023-07-25 11:53 ` Li, Pan2
2023-07-25 13:23 ` Kito Cheng
2023-07-25 14:12 ` Robin Dapp
2023-07-26 13:08 ` Robin Dapp
2023-07-26 21:40 ` Jeff Law [this message]
2023-07-26 22:21 ` 钟居哲
2023-07-26 22:46 ` Jeff Law
2023-07-26 22:56 ` 钟居哲
2023-07-27 1:38 ` Li, Pan2
2023-07-27 8:19 ` Li, Pan2
2023-07-27 2:09 ` Li, Pan2
2023-07-27 7:25 ` Robin Dapp
2023-07-27 8:26 ` Li, Pan2
2023-07-27 8:41 ` Robin Dapp
2023-07-27 10:27 ` Li, Pan2
[not found] ` <63471C6E126E44CF+D1CEA4C9-0050-43CD-8DE3-26EBD7AEE6DA@rivai.ai>
2023-07-26 13:35 ` Li, Pan2
2023-07-26 13:43 ` Li, Pan2
2023-07-26 13:46 ` Robin Dapp
2023-07-26 13:57 ` Kito Cheng
2023-07-26 14:05 ` Kito Cheng
2023-07-26 14:10 ` Robin Dapp
2023-07-26 14:18 ` 钟居哲
2023-07-26 14:30 ` Li, Pan2
2023-07-26 15:34 ` Kito Cheng
2023-07-26 16:00 ` Palmer Dabbelt
2023-07-26 21:01 ` Robin Dapp
2023-07-28 1:15 ` [PATCH v8] " pan2.li
2023-07-28 10:05 ` Robin Dapp
2023-07-28 12:34 ` Li, Pan2
2023-08-01 7:50 ` Kito Cheng
2023-08-01 8:00 ` Li, Pan2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc537a87-5297-846b-d6a4-141c6852784b@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@sifive.com \
--cc=pan2.li@intel.com \
--cc=rdapp.gcc@gmail.com \
--cc=yanzhang.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).