From: Jeff Law <jeffreyalaw@gmail.com>
To: Jason Merrill <jason@redhat.com>,
gcc-patches@gcc.gnu.org, Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH RFA] opts: -Werror=foo always implies -Wfoo [PR106213]
Date: Wed, 3 Jan 2024 13:14:38 -0700 [thread overview]
Message-ID: <bf8a3a03-b2b6-4844-a935-c592cefa4e6d@gmail.com> (raw)
In-Reply-To: <20231219221731.2944661-1-jason@redhat.com>
On 12/19/23 15:17, Jason Merrill wrote:
> Tested x86_64-pc-linux-gnu, OK for trunk?
>
> -- 8< --
>
> -Werror=foo implying -Wfoo wasn't working for -Wdeprecated-copy-dtor,
> because it is specified as the value 2 of warn_deprecated_copy, which shows
> up as CLVC_EQUAL, which is not one of the three var_types handled by
> control_warning_option. It seems to me that we can just unconditionally
> handle_generated_option, and only have special argument handling for those
> types.
>
> PR c++/106213
>
> gcc/ChangeLog:
>
> * opts-common.cc (control_warning_option): Call
> handle_generated_option for all cl_var_types.
>
> gcc/testsuite/ChangeLog:
>
> * g++.dg/cpp0x/depr-copy5.C: New test.
OK
jeff
prev parent reply other threads:[~2024-01-03 20:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 22:17 Jason Merrill
2023-12-20 23:55 ` Joseph Myers
2024-01-03 20:14 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf8a3a03-b2b6-4844-a935-c592cefa4e6d@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).