From: Jan Beulich <jbeulich@suse.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Hongtao Liu <hongtao.liu@intel.com>,
Kirill Yukhin <kirill.yukhin@gmail.com>,
Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [PATCH] x86: replace "extendhfdf2" expander
Date: Fri, 14 Jul 2023 12:40:22 +0200 [thread overview]
Message-ID: <c2f90609-84d7-3ff6-4bcb-1de219f8b24d@suse.com> (raw)
In-Reply-To: <CAFULd4YAmBkOu6MetFy1=ruUca6vWatWhbJG4G6SnW4LGEF3_Q@mail.gmail.com>
On 14.07.2023 12:10, Uros Bizjak wrote:
> On Fri, Jul 14, 2023 at 11:44 AM Jan Beulich <jbeulich@suse.com> wrote:
>>
>> The corresponding insn serves this purpose quite fine, and leads to
>> slightly less (generated) code. All we need is the insn to not have a
>> leading * in its name, while retaining that * for "extendhfsf2".
>> Introduce a mode attribute in exchange to achieve that.
>>
>> gcc/
>>
>> * config/i386/i386.md (extendhfdf2): Delete expander.
>> (extendhf): New mode attribute.
>> (*extendhf<mode>2): Use it.
>
> No, please leave the expander, it is there due to extendhfsf2 that
> prevents effective macroization.
Well, okay then.
> FYI, there is no less generated code when the named pattern is used,
> the same code is generated from the named pattern as from the
> expander. Source code can be shrinked, but in this particular case,
> forced macroization complicates things more.
Hmm, I'm pretty sure I checked and found some reduction.
Jan
prev parent reply other threads:[~2023-07-14 10:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 9:44 Jan Beulich
2023-07-14 10:10 ` Uros Bizjak
2023-07-14 10:40 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2f90609-84d7-3ff6-4bcb-1de219f8b24d@suse.com \
--to=jbeulich@suse.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hongtao.liu@intel.com \
--cc=hubicka@ucw.cz \
--cc=kirill.yukhin@gmail.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).