From: Jeff Law <jeffreyalaw@gmail.com>
To: Andrew Pinski <pinskia@gmail.com>
Cc: Sam James <sam@gentoo.org>, Kito Cheng <kito.cheng@gmail.com>,
"juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai>,
gcc-patches <gcc-patches@gcc.gnu.org>,
palmer <palmer@dabbelt.com>, andrew <andrew@sifive.com>,
Jim Wilson <jim.wilson.gcc@gmail.com>
Subject: Re: [PATCH v4 2/2] gcc: Drop obsolete INCLUDE_PTHREAD_H (ping)
Date: Sun, 2 Apr 2023 14:07:51 -0600 [thread overview]
Message-ID: <c3d1d9ca-4313-b9c4-92ac-3369e75f221f@gmail.com> (raw)
In-Reply-To: <CA+=Sn1=+xCs18e=5wnuNhNr_vU0yY4YdQzFRJb82TbfbX_r0xQ@mail.gmail.com>
On 4/2/23 14:06, Andrew Pinski wrote:
> On Sun, Apr 2, 2023 at 12:55 PM Jeff Law via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
>>
>>
>>
>> On 3/31/23 12:44, Sam James wrote:
>>>
>>> Kito Cheng <kito.cheng@gmail.com> writes:
>>>
>>>> It's not the RISC-V part, so this requires a global maintainer there I think?
>>>>
>>>
>>> Someone able to look at the system.h bit? It should be trivial, there's
>>> no uses left and it was added purely for a bug like this in the past
>>> (see commit message).
>> You assert that pthread.h is no longer used... But ISTM you really need
>> to go back to when the include was added, understand why it was added
>> and explain why it is no longer needed.
>
> It was needed for the JIT front-end at the time used pthread_mutex_*
> and pthread.h could use a poisoned identifier (I think it was calloc);
> the INCLUDE_PTHREAD_H was added with r13-1350-g49d508065bdd36. The JIT
> front-end moved to using C++11's mutex in r13-4164-g0a62889c7a155f and
> moved away from using pthread.h but didn't remove INCLUDE_PTHREAD_H
> support.
>
> I hope that help explains why it is no longer needed and how it became
> even unused.
SO I'm confused, what does this have to do with RISC-V?
jeff
next prev parent reply other threads:[~2023-04-02 20:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 0:23 [PATCH v4 1/2] RISC-V: Avoid calloc() poisoning on musl Sam James
2023-03-14 0:23 ` [PATCH v4 2/2] gcc: Drop obsolete INCLUDE_PTHREAD_H Sam James
2023-03-14 0:27 ` juzhe.zhong
2023-03-14 13:45 ` Kito Cheng
2023-03-14 14:44 ` Jeff Law
2023-03-31 18:44 ` [PATCH v4 2/2] gcc: Drop obsolete INCLUDE_PTHREAD_H (ping) Sam James
2023-04-02 19:54 ` Jeff Law
2023-04-02 20:06 ` Andrew Pinski
2023-04-02 20:07 ` Jeff Law [this message]
2023-04-02 20:13 ` Andrew Pinski
2023-04-02 20:16 ` Sam James
2023-03-14 9:06 ` [PATCH v4 1/2] RISC-V: Avoid calloc() poisoning on musl Richard Biener
2023-03-14 13:44 ` Kito Cheng
2023-03-14 13:48 ` Kito Cheng
2023-03-14 22:06 ` Sam James
2023-03-14 21:39 ` Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3d1d9ca-4313-b9c4-92ac-3369e75f221f@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=andrew@sifive.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jim.wilson.gcc@gmail.com \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pinskia@gmail.com \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).