From: Sam James <sam@gentoo.org>
To: Kito Cheng <kito.cheng@gmail.com>
Cc: "juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai>,
gcc-patches <gcc-patches@gcc.gnu.org>,
palmer <palmer@dabbelt.com>, andrew <andrew@sifive.com>,
Jim Wilson <jim.wilson.gcc@gmail.com>,
Jeff Law <jeffreyalaw@gmail.com>
Subject: Re: [PATCH v4 2/2] gcc: Drop obsolete INCLUDE_PTHREAD_H (ping)
Date: Fri, 31 Mar 2023 19:44:38 +0100 [thread overview]
Message-ID: <87mt3syd2y.fsf@gentoo.org> (raw)
In-Reply-To: <CA+yXCZDVsUJKjABkqxnxNWu+Z96cHKdirm0Ov+ase1utN7A_0w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1538 bytes --]
Kito Cheng <kito.cheng@gmail.com> writes:
> It's not the RISC-V part, so this requires a global maintainer there I think?
>
Someone able to look at the system.h bit? It should be trivial, there's
no uses left and it was added purely for a bug like this in the past
(see commit message).
> On Tue, Mar 14, 2023 at 8:28 AM juzhe.zhong@rivai.ai
> <juzhe.zhong@rivai.ai> wrote:
>>
>> Thank you for fixing this. I am not familiar with this.
>> This generator code (genrvv-type-indexer.cc) is written by @kito.
>>
>> Kito ? Can you take a look at this?
>>
>>
>> juzhe.zhong@rivai.ai
>>
>> From: Sam James
>> Date: 2023-03-14 08:23
>> To: gcc-patches
>> CC: Kito Cheng; Palmer Dabbelt; Andrew Waterman; Jim Wilson; Ju-Zhe Zhong; Sam James
>> Subject: [PATCH v4 2/2] gcc: Drop obsolete INCLUDE_PTHREAD_H
>> This is no longer used since 0a62889c7a155f8ed971860d68870dc9c46bb004, so
>> let's clean it up.
>>
>> gcc/ChangeLog:
>> * system.h: Drop unused INCLUDE_PTHREAD_H.
>>
>> Signed-off-by: Sam James <sam@gentoo.org>
>> ---
>> gcc/system.h | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/gcc/system.h b/gcc/system.h
>> index cf45db3f97e..3fdad7abf1e 100644
>> --- a/gcc/system.h
>> +++ b/gcc/system.h
>> @@ -761,10 +761,6 @@ extern int vsnprintf (char *, size_t, const char *, va_list);
>> #endif
>> #endif
>> -#ifdef INCLUDE_PTHREAD_H
>> -#include <pthread.h>
>> -#endif
>> -
>> #ifdef INCLUDE_ISL
>> #ifdef HAVE_isl
>> #include <isl/options.h>
>> --
>> 2.40.0
>>
>>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 377 bytes --]
next prev parent reply other threads:[~2023-03-31 18:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 0:23 [PATCH v4 1/2] RISC-V: Avoid calloc() poisoning on musl Sam James
2023-03-14 0:23 ` [PATCH v4 2/2] gcc: Drop obsolete INCLUDE_PTHREAD_H Sam James
2023-03-14 0:27 ` juzhe.zhong
2023-03-14 13:45 ` Kito Cheng
2023-03-14 14:44 ` Jeff Law
2023-03-31 18:44 ` Sam James [this message]
2023-04-02 19:54 ` [PATCH v4 2/2] gcc: Drop obsolete INCLUDE_PTHREAD_H (ping) Jeff Law
2023-04-02 20:06 ` Andrew Pinski
2023-04-02 20:07 ` Jeff Law
2023-04-02 20:13 ` Andrew Pinski
2023-04-02 20:16 ` Sam James
2023-03-14 9:06 ` [PATCH v4 1/2] RISC-V: Avoid calloc() poisoning on musl Richard Biener
2023-03-14 13:44 ` Kito Cheng
2023-03-14 13:48 ` Kito Cheng
2023-03-14 22:06 ` Sam James
2023-03-14 21:39 ` Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt3syd2y.fsf@gentoo.org \
--to=sam@gentoo.org \
--cc=andrew@sifive.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=jim.wilson.gcc@gmail.com \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).